* [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <joe@perches.com>,
@ 2021-04-27 14:45 Ashish Kalra
2021-04-27 16:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Ashish Kalra @ 2021-04-27 14:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, Joe Perches, Abheek Dhawan, Johannes Weiner,
Romain Perier, Waiman Long, Allen Pais, Ivan Safonov,
linux-staging, linux-kernel
Cc: eashishkalra
Abheek Dhawan <adawesomeguy222@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Romain Perier <romain.perier@gmail.com>,
Waiman Long <longman@redhat.com>,
Allen Pais <apais@linux.microsoft.com>,
Ivan Safonov <insafonov@gmail.com>,
linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Upon running sparse, "warning: incorrect type in argument 1 (different
address spaces) is brought to notice for this file.let's correct data type for
variable data adding __user to make it cleaner and silence the Sparse
warning. This is version 2 of the patch, version 1 can be found at
https://lkml.org/lkml/2021/4/20/203
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57a..77e8d2913 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5..dfb2d2832 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <joe@perches.com>,
2021-04-27 14:45 [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <joe@perches.com>, Ashish Kalra
@ 2021-04-27 16:09 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-27 16:09 UTC (permalink / raw)
To: Ashish Kalra
Cc: Joe Perches, Abheek Dhawan, Johannes Weiner, Romain Perier,
Waiman Long, Allen Pais, Ivan Safonov, linux-staging,
linux-kernel
On Tue, Apr 27, 2021 at 02:45:56PM +0000, Ashish Kalra wrote:
> Abheek Dhawan <adawesomeguy222@gmail.com>,
> Johannes Weiner <hannes@cmpxchg.org>,
> Romain Perier <romain.perier@gmail.com>,
> Waiman Long <longman@redhat.com>,
> Allen Pais <apais@linux.microsoft.com>,
> Ivan Safonov <insafonov@gmail.com>,
> linux-staging@lists.linux.dev,
> linux-kernel@vger.kernel.org
Why is this here in the email body?
> Upon running sparse, "warning: incorrect type in argument 1 (different
> address spaces) is brought to notice for this file.let's correct data type for
> variable data adding __user to make it cleaner and silence the Sparse
> warning. This is version 2 of the patch, version 1 can be found at
> https://lkml.org/lkml/2021/4/20/203
Always use lore.kernel.org links, not a random other site that we have
no idea who runs it.
And no need to say this in that form, please list below the --- line
what changed from v1.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-27 16:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 14:45 [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <joe@perches.com>, Ashish Kalra
2021-04-27 16:09 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.