All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Qu Wenruo <wqu@suse.com>
Cc: u-boot@lists.denx.de, linux-btrfs@vger.kernel.org,
	Matwey Kornilov <matwey.kornilov@gmail.com>
Subject: Re: [PATCH U-boot v2] fs: btrfs: fix the false alert of decompression failure
Date: Tue, 27 Apr 2021 12:46:02 -0400	[thread overview]
Message-ID: <20210427164602.GS17669@bill-the-cat> (raw)
In-Reply-To: <20210417125213.132066-1-wqu@suse.com>

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

On Sat, Apr 17, 2021 at 08:52:13PM +0800, Qu Wenruo wrote:

> There are some cases where decompressed sectors can have padding zeros.
> 
> In kernel code, we have lines to address such situation:
> 
>         /*
>          * btrfs_getblock is doing a zero on the tail of the page too,
>          * but this will cover anything missing from the decompressed
>          * data.
>          */
>         if (bytes < destlen)
>                 memset(kaddr+bytes, 0, destlen-bytes);
>         kunmap_local(kaddr);
> 
> But not in U-boot code, thus we have some reports of U-boot failed to
> read compressed files in btrfs.
> 
> Fix it by doing the same thing of the kernel, for both inline and
> regular compressed extents.
> 
> Reported-by: Matwey Kornilov <matwey.kornilov@gmail.com>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1183717
> Fixes: a26a6bedafcf ("fs: btrfs: Introduce btrfs_read_extent_inline() and btrfs_read_extent_reg()")
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH U-boot v2] fs: btrfs: fix the false alert of decompression failure
Date: Tue, 27 Apr 2021 12:46:02 -0400	[thread overview]
Message-ID: <20210427164602.GS17669@bill-the-cat> (raw)
In-Reply-To: <20210417125213.132066-1-wqu@suse.com>

On Sat, Apr 17, 2021 at 08:52:13PM +0800, Qu Wenruo wrote:

> There are some cases where decompressed sectors can have padding zeros.
> 
> In kernel code, we have lines to address such situation:
> 
>         /*
>          * btrfs_getblock is doing a zero on the tail of the page too,
>          * but this will cover anything missing from the decompressed
>          * data.
>          */
>         if (bytes < destlen)
>                 memset(kaddr+bytes, 0, destlen-bytes);
>         kunmap_local(kaddr);
> 
> But not in U-boot code, thus we have some reports of U-boot failed to
> read compressed files in btrfs.
> 
> Fix it by doing the same thing of the kernel, for both inline and
> regular compressed extents.
> 
> Reported-by: Matwey Kornilov <matwey.kornilov@gmail.com>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1183717
> Fixes: a26a6bedafcf ("fs: btrfs: Introduce btrfs_read_extent_inline() and btrfs_read_extent_reg()")
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210427/fb1903d9/attachment.sig>

  reply	other threads:[~2021-04-27 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17 12:52 [PATCH U-boot v2] fs: btrfs: fix the false alert of decompression failure Qu Wenruo
2021-04-17 12:52 ` Qu Wenruo
2021-04-27 16:46 ` Tom Rini [this message]
2021-04-27 16:46   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427164602.GS17669@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=matwey.kornilov@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.