All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] Set exfat file system to skip symlink
@ 2021-04-28  2:50 zhanglianjie
  2021-04-28 19:03 ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: zhanglianjie @ 2021-04-28  2:50 UTC (permalink / raw)
  To: ltp

If the kernel configuration CONF_EXFAT_FS=m, then the exfat test
result is TCONF. If the kernel is not configured with CONF_EXFAT_FS=m,
then the exfat test result will be TBROK (TBROK makes subsequent tests
impossible). Because the exfat file system does not support symlink,
the test should skip calling symlink.

Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
---
 testcases/kernel/syscalls/chdir/chdir01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/chdir/chdir01.c b/testcases/kernel/syscalls/chdir/chdir01.c
index 23cd455d6..aa25adf6a 100644
--- a/testcases/kernel/syscalls/chdir/chdir01.c
+++ b/testcases/kernel/syscalls/chdir/chdir01.c
@@ -69,7 +69,7 @@ static void setup(void)

 	if (!TST_RET)
 		SAFE_SYMLINK(LINK_NAME2, LINK_NAME1);
-	else if (TST_RET == -1 && TST_ERR == EPERM)
+	else if (TST_RET == -1 && (TST_ERR == EPERM || TST_ERR == ENOSYS))
 		skip_symlinks = 1;
 	else
 		tst_brk(TBROK | TTERRNO, "Cannot create symlinks");
--
2.20.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH] Set exfat file system to skip symlink
  2021-04-28  2:50 [LTP] [PATCH] Set exfat file system to skip symlink zhanglianjie
@ 2021-04-28 19:03 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2021-04-28 19:03 UTC (permalink / raw)
  To: ltp

Hi,

good catch!

> If the kernel configuration CONF_EXFAT_FS=m, then the exfat test
you mean CONFIG_EXFAT_FS.

> result is TCONF. If the kernel is not configured with CONF_EXFAT_FS=m,
> then the exfat test result will be TBROK (TBROK makes subsequent tests
> impossible). Because the exfat file system does not support symlink,
> the test should skip calling symlink.

I reword the commit message and merged.
Thanks!

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-28 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28  2:50 [LTP] [PATCH] Set exfat file system to skip symlink zhanglianjie
2021-04-28 19:03 ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.