* [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image
@ 2021-04-28 3:40 Charles Hardin
2021-04-29 8:20 ` Stephane Viau
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Charles Hardin @ 2021-04-28 3:40 UTC (permalink / raw)
To: buildroot
From: Charles Hardin <ckhardin@gmail.com>
The silicon revision for the imx8 is C0 and this is the release
candidate for the new update images. It also seems to work on
some B0 early silicon in addition, so change the ahab container
to use mx8qxc0-ahab-container.img
Signed-off-by: Charles Hardin <ckhardin@gmail.com>
Signed-off-by: Charles Hardin <charles.hardin@chargepoint.com>
---
package/freescale-imx/imx-seco/imx-seco.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
index 245c3e3311..711315ea93 100644
--- a/package/freescale-imx/imx-seco/imx-seco.mk
+++ b/package/freescale-imx/imx-seco/imx-seco.mk
@@ -22,7 +22,7 @@ IMX_SECO_INSTALL_IMAGES = YES
# is done in post-image script.
ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
define IMX_SECO_INSTALL_IMAGES_CMDS
- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
+ cp $(@D)/firmware/seco/mx8qxc0-ahab-container.img \
$(BINARIES_DIR)/ahab-container.img
endef
else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-28 3:40 [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image Charles Hardin
@ 2021-04-29 8:20 ` Stephane Viau
2021-04-29 15:05 ` Charles Hardin
2021-04-30 16:41 ` [Buildroot] [PATCH v2] " Charles Hardin
2021-04-30 18:09 ` [Buildroot] [PATCH v3] " Charles Hardin
2 siblings, 1 reply; 9+ messages in thread
From: Stephane Viau @ 2021-04-29 8:20 UTC (permalink / raw)
To: buildroot
>
>The silicon revision for the imx8 is C0 and this is the release
>candidate for the new update images. It also seems to work on
>some B0 early silicon in addition, so change the ahab container
>to use mx8qxc0-ahab-container.img
The C0 firmware cannot be executed along with the B0 ROM for a couple
of reasons (different function address map and lacking features).
Warning:
Once we make the switch to mx8qxc0-ahab-container, all boards based
on a B0 silicon version won't boot anymore!
>
>Signed-off-by: Charles Hardin <ckhardin@gmail.com>
>Signed-off-by: Charles Hardin <charles.hardin@chargepoint.com>
[Stephane: tested on i.MX8 QXP EVK Rev C]
Tested-by: Stephane Viau <stephane.viau@oss.nxp.com>
BR,
Stephane.
>---
> package/freescale-imx/imx-seco/imx-seco.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
>index 245c3e3311..711315ea93 100644
>--- a/package/freescale-imx/imx-seco/imx-seco.mk
>+++ b/package/freescale-imx/imx-seco/imx-seco.mk
>@@ -22,7 +22,7 @@ IMX_SECO_INSTALL_IMAGES = YES
> # is done in post-image script.
> ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
> define IMX_SECO_INSTALL_IMAGES_CMDS
>- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
>+ cp $(@D)/firmware/seco/mx8qxc0-ahab-container.img \
> $(BINARIES_DIR)/ahab-container.img
> endef
> else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
>--
>2.21.1 (Apple Git-122.3)
>
>_______________________________________________
>buildroot mailing list
>buildroot at busybox.net
>http://lists.busybox.net/mailman/listinfo/buildroot
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-29 8:20 ` Stephane Viau
@ 2021-04-29 15:05 ` Charles Hardin
2021-04-30 7:37 ` Stephane Viau
0 siblings, 1 reply; 9+ messages in thread
From: Charles Hardin @ 2021-04-29 15:05 UTC (permalink / raw)
To: buildroot
On Thu, Apr 29, 2021 at 1:20 AM Stephane Viau (OSS) <
stephane.viau@oss.nxp.com> wrote:
> >
> >The silicon revision for the imx8 is C0 and this is the release
> >candidate for the new update images. It also seems to work on
> >some B0 early silicon in addition, so change the ahab container
> >to use mx8qxc0-ahab-container.img
>
> The C0 firmware cannot be executed along with the B0 ROM for a couple
> of reasons (different function address map and lacking features).
>
> Warning:
> Once we make the switch to mx8qxc0-ahab-container, all boards based
> on a B0 silicon version won't boot anymore!
>
>
That's how I found this - I had a C0 ROM and that doesn't boot with the b0
ahab,
so it needs to be setup to go one way or the other. I think C0 is the
production
GA release from NXP, so this is out there for people as needed that have
that
problem.
This was from the u-boot
CPU: Freescale i.MX8QXP revC A35 at 1200 MHz at 34C
> >
> >Signed-off-by: Charles Hardin <ckhardin@gmail.com>
>
>
> [Stephane: tested on i.MX8 QXP EVK Rev C]
> Tested-by: Stephane Viau <stephane.viau@oss.nxp.com>
>
> BR,
> Stephane.
>
> >---
> > package/freescale-imx/imx-seco/imx-seco.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/package/freescale-imx/imx-seco/imx-seco.mk
> b/package/freescale-imx/imx-seco/imx-seco.mk
> >index 245c3e3311..711315ea93 100644
> >--- a/package/freescale-imx/imx-seco/imx-seco.mk
> >+++ b/package/freescale-imx/imx-seco/imx-seco.mk
> >@@ -22,7 +22,7 @@ IMX_SECO_INSTALL_IMAGES = YES
> > # is done in post-image script.
> > ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
> > define IMX_SECO_INSTALL_IMAGES_CMDS
> >- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
> >+ cp $(@D)/firmware/seco/mx8qxc0-ahab-container.img \
> > $(BINARIES_DIR)/ahab-container.img
> > endef
> > else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> >--
> >2.21.1 (Apple Git-122.3)
> >
> >_______________________________________________
> >buildroot mailing list
> >buildroot at busybox.net
> >http://lists.busybox.net/mailman/listinfo/buildroot
> >
> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210429/52024a6d/attachment.html>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-29 15:05 ` Charles Hardin
@ 2021-04-30 7:37 ` Stephane Viau
0 siblings, 0 replies; 9+ messages in thread
From: Stephane Viau @ 2021-04-30 7:37 UTC (permalink / raw)
To: buildroot
Hi Charles,
>>>
>>>The silicon revision for the imx8 is C0 and this is the release
>>>candidate for the new update images. It also seems to work on
>>>some B0 early silicon in addition, so change the ahab container
>>>to use mx8qxc0-ahab-container.img
>>
>>The C0 firmware cannot be executed along with the B0 ROM for a couple
>>of reasons (different function address map and lacking features).
>>
>>Warning:
>>Once we make the switch to mx8qxc0-ahab-container, all boards based
>>on a B0 silicon version won't boot anymore!
>>
>
>That's how I found this - I had a C0 ROM and that doesn't boot with the b0 ahab,
>so it needs to be setup to go one way or the other. I think C0 is the production
>GA release from NXP, so this is out there for people as needed that have that
>problem.
It's true that the recommendation is to move onto C0 silicon version based on
the considerations mentioned in [1] ;
... and I personally have no issues with this switch (I have both B0 and C0 in hands
and would be happy to switch to C0).
However, I am wondering whether a Kconfig 'choice' would be a better option to
let the B0 users (if any?) pick mx8qxb0-ahab-container for backward compatibility?
BR,
Stephane.
[1] https://www.nxp.com/docs/en/application-note/AN12770.pdf
>
>This was from the u-boot
>
>
> CPU: Freescale i.MX8QXP revC A35 at 1200 MHz at 34C
>
>
>>>
>>>Signed-off-by: Charles Hardin <ckhardin at gmail.com<mailto:ckhardin@gmail.com>>
>>
>>
>>[Stephane: tested on i.MX8 QXP EVK Rev C]
>>Tested-by: Stephane Viau <stephane.viau at oss.nxp.com<mailto:stephane.viau@oss.nxp.com>>
>>
>>BR,
>>Stephane.
>>
>>>---
>>> package/freescale-imx/imx-seco/imx-seco.mk<http://imx-seco.mk> | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/package/freescale-imx/imx-seco/imx-seco.mk<http://imx-seco.mk> b/package/freescale-imx/imx-seco/imx-seco.mk<http://imx-seco.mk>
>>>index 245c3e3311..711315ea93 100644
>>>--- a/package/freescale-imx/imx-seco/imx-seco.mk<http://imx-seco.mk>
>>>+++ b/package/freescale-imx/imx-seco/imx-seco.mk<http://imx-seco.mk>
>>>@@ -22,7 +22,7 @@ IMX_SECO_INSTALL_IMAGES = YES
>>> # is done in post-image script.
>>> ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
>>> define IMX_SECO_INSTALL_IMAGES_CMDS
>>>- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
>>>+ cp $(@D)/firmware/seco/mx8qxc0-ahab-container.img \
>>> $(BINARIES_DIR)/ahab-container.img
>>> endef
>>> else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
>>>--
>>>2.21.1 (Apple Git-122.3)
>>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-28 3:40 [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image Charles Hardin
2021-04-29 8:20 ` Stephane Viau
@ 2021-04-30 16:41 ` Charles Hardin
2021-04-30 17:09 ` Stephane Viau
2021-04-30 18:09 ` [Buildroot] [PATCH v3] " Charles Hardin
2 siblings, 1 reply; 9+ messages in thread
From: Charles Hardin @ 2021-04-30 16:41 UTC (permalink / raw)
To: buildroot
From: Charles Hardin <ckhardin@gmail.com>
Update the selection of the ahab container image to use based upon
a choice in the Config.in - there are multiple ASIC revisions that
use AHAB and the firmware images need to match. This extends the
support beyond a default image for just the imx8 amd imx8x based
upon the current contents of the imx-seco firmware extraction.
Files from 3.7.4:
mx8dxla0-ahab-container.img
mx8dxla1-ahab-container.img
mx8qmb0-ahab-container.img
mx8qxb0-ahab-container.img
mx8qxc0-ahab-container.img
Signed-off-by: Charles Hardin <ckhardin@gmail.com>
---
Changes v1 -> v2:
- convert the image selection to a choice in Config.in
(suggested by Stephane)
---
package/freescale-imx/imx-seco/Config.in | 38 ++++++++++++++++++++++
package/freescale-imx/imx-seco/imx-seco.mk | 14 ++++----
2 files changed, 44 insertions(+), 8 deletions(-)
diff --git a/package/freescale-imx/imx-seco/Config.in b/package/freescale-imx/imx-seco/Config.in
index 1877664a0c..e5d835f8b1 100644
--- a/package/freescale-imx/imx-seco/Config.in
+++ b/package/freescale-imx/imx-seco/Config.in
@@ -7,3 +7,41 @@ config BR2_PACKAGE_IMX_SECO
This library is provided by Freescale as-is and doesn't have
an upstream.
+
+if BR2_PACKAGE_IMX_SECO
+choice
+ prompt "i.MX Seco Firmware Release"
+ help
+ Select the appropriate ahab container image to install
+ to match the asics revision.
+
+config BR2_PACKAGE_IMX_SECO_MX8DXLA0
+ bool "imx-seco-mx8dxla0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8DXLA1
+ bool "imx-seco-mx8dxla1"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8QMB0
+ bool "imx-seco-mx8qmb0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8QXB0
+ bool "imx-seco-mx8qxb0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+
+config BR2_PACKAGE_IMX_SECO_MX8QXC0
+ bool "imx-seco-mx8qxc0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+endchoice
+
+config BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE
+ string
+ default "mx8dxla0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA0
+ default "mx8dxla1-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA1
+ default "mx8qmb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QMB0
+ default "mx8qxb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXB0
+ default "mx8qxc0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXC0
+
+endif
diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
index 245c3e3311..b1a38b5943 100644
--- a/package/freescale-imx/imx-seco/imx-seco.mk
+++ b/package/freescale-imx/imx-seco/imx-seco.mk
@@ -18,18 +18,16 @@ endef
IMX_SECO_INSTALL_IMAGES = YES
+IMX_SECO_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE))
+ifeq ($(IMX_SECO_AHAB_CONTAINER_IMAGE),)
+$(error No iMX Seco AHAB Container Image file specified)
+endif
+
# SECO firmware is needed when generating imx8-boot-sd.bin which
# is done in post-image script.
-ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
-define IMX_SECO_INSTALL_IMAGES_CMDS
- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
- $(BINARIES_DIR)/ahab-container.img
-endef
-else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
define IMX_SECO_INSTALL_IMAGES_CMDS
- cp $(@D)/firmware/seco/mx8qmb0-ahab-container.img \
+ cp $(@D)/firmware/seco/$(IMX_SECO_AHAB_CONTAINER_IMAGE) \
$(BINARIES_DIR)/ahab-container.img
endef
-endif
$(eval $(generic-package))
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-30 16:41 ` [Buildroot] [PATCH v2] " Charles Hardin
@ 2021-04-30 17:09 ` Stephane Viau
2021-04-30 17:38 ` Yann E. MORIN
0 siblings, 1 reply; 9+ messages in thread
From: Stephane Viau @ 2021-04-30 17:09 UTC (permalink / raw)
To: buildroot
Hi Charles,
>
>
>From: Charles Hardin <ckhardin@gmail.com>
>
>Update the selection of the ahab container image to use based upon
>a choice in the Config.in - there are multiple ASIC revisions that
>use AHAB and the firmware images need to match. This extends the
>support beyond a default image for just the imx8 amd imx8x based
>upon the current contents of the imx-seco firmware extraction.
>
>Files from 3.7.4:
> mx8dxla0-ahab-container.img
> mx8dxla1-ahab-container.img
> mx8qmb0-ahab-container.img
> mx8qxb0-ahab-container.img
> mx8qxc0-ahab-container.img
>
>Signed-off-by: Charles Hardin <ckhardin@gmail.com>
>
>---
>Changes v1 -> v2:
> - convert the image selection to a choice in Config.in
> (suggested by Stephane)
Thank you for the quick feedback on this ; I appreciate it... and will try and test it ASAP!
>
>---
> package/freescale-imx/imx-seco/Config.in | 38 ++++++++++++++++++++++
> package/freescale-imx/imx-seco/imx-seco.mk | 14 ++++----
> 2 files changed, 44 insertions(+), 8 deletions(-)
>
>diff --git a/package/freescale-imx/imx-seco/Config.in b/package/freescale-imx/imx-seco/Config.in
>index 1877664a0c..e5d835f8b1 100644
>--- a/package/freescale-imx/imx-seco/Config.in
>+++ b/package/freescale-imx/imx-seco/Config.in
>@@ -7,3 +7,41 @@ config BR2_PACKAGE_IMX_SECO
>
> This library is provided by Freescale as-is and doesn't have
> an upstream.
>+
>+if BR2_PACKAGE_IMX_SECO
>+choice
>+ prompt "i.MX Seco Firmware Release"
>+ help
>+ Select the appropriate ahab container image to install
>+ to match the asics revision.
Should we default it to C0 when 8X is selected?:
default BR2_PACKAGE_IMX_SECO_MX8QXC0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
BR,
Stephane.
>+
>+config BR2_PACKAGE_IMX_SECO_MX8DXLA0
>+ bool "imx-seco-mx8dxla0"
>+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
>+
>+config BR2_PACKAGE_IMX_SECO_MX8DXLA1
>+ bool "imx-seco-mx8dxla1"
>+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
>+
>+config BR2_PACKAGE_IMX_SECO_MX8QMB0
>+ bool "imx-seco-mx8qmb0"
>+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
>+
>+config BR2_PACKAGE_IMX_SECO_MX8QXB0
>+ bool "imx-seco-mx8qxb0"
>+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
>+
>+config BR2_PACKAGE_IMX_SECO_MX8QXC0
>+ bool "imx-seco-mx8qxc0"
>+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
>+endchoice
>+
>+config BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE
>+ string
>+ default "mx8dxla0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA0
>+ default "mx8dxla1-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA1
>+ default "mx8qmb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QMB0
>+ default "mx8qxb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXB0
>+ default "mx8qxc0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXC0
>+
>+endif
>diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
>index 245c3e3311..b1a38b5943 100644
>--- a/package/freescale-imx/imx-seco/imx-seco.mk
>+++ b/package/freescale-imx/imx-seco/imx-seco.mk
>@@ -18,18 +18,16 @@ endef
>
> IMX_SECO_INSTALL_IMAGES = YES
>
>+IMX_SECO_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE))
>+ifeq ($(IMX_SECO_AHAB_CONTAINER_IMAGE),)
>+$(error No iMX Seco AHAB Container Image file specified)
>+endif
>+
> # SECO firmware is needed when generating imx8-boot-sd.bin which
> # is done in post-image script.
>-ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
>-define IMX_SECO_INSTALL_IMAGES_CMDS
>- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
>- $(BINARIES_DIR)/ahab-container.img
>-endef
>-else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> define IMX_SECO_INSTALL_IMAGES_CMDS
>- cp $(@D)/firmware/seco/mx8qmb0-ahab-container.img \
>+ cp $(@D)/firmware/seco/$(IMX_SECO_AHAB_CONTAINER_IMAGE) \
> $(BINARIES_DIR)/ahab-container.img
> endef
>-endif
>
> $(eval $(generic-package))
>--
>2.21.1 (Apple Git-122.3)
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-30 17:09 ` Stephane Viau
@ 2021-04-30 17:38 ` Yann E. MORIN
0 siblings, 0 replies; 9+ messages in thread
From: Yann E. MORIN @ 2021-04-30 17:38 UTC (permalink / raw)
To: buildroot
St?phane, Charles, All,
On 2021-04-30 17:09 +0000, Stephane Viau (OSS) spake thusly:
> >From: Charles Hardin <ckhardin@gmail.com>
> >Update the selection of the ahab container image to use based upon
> >a choice in the Config.in - there are multiple ASIC revisions that
> >use AHAB and the firmware images need to match. This extends the
> >support beyond a default image for just the imx8 amd imx8x based
> >upon the current contents of the imx-seco firmware extraction.
> >
> >Files from 3.7.4:
> > mx8dxla0-ahab-container.img
> > mx8dxla1-ahab-container.img
> > mx8qmb0-ahab-container.img
> > mx8qxb0-ahab-container.img
> > mx8qxc0-ahab-container.img
> >
> >Signed-off-by: Charles Hardin <ckhardin@gmail.com>
[--SNIP--]
> >diff --git a/package/freescale-imx/imx-seco/Config.in b/package/freescale-imx/imx-seco/Config.in
> >index 1877664a0c..e5d835f8b1 100644
> >--- a/package/freescale-imx/imx-seco/Config.in
> >+++ b/package/freescale-imx/imx-seco/Config.in
> >@@ -7,3 +7,41 @@ config BR2_PACKAGE_IMX_SECO
> >
> > This library is provided by Freescale as-is and doesn't have
> > an upstream.
> >+
> >+if BR2_PACKAGE_IMX_SECO
> >+choice
> >+ prompt "i.MX Seco Firmware Release"
> >+ help
> >+ Select the appropriate ahab container image to install
> >+ to match the asics revision.
>
> Should we default it to C0 when 8X is selected?:
> default BR2_PACKAGE_IMX_SECO_MX8QXC0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
If a default is selected, please add a blurb in the ocmmit log to
explain why it is orefered over the others, e.g.:
The IMX8X C0 HW variant is the most widespread, so that's the
default, but there are a few B0 still circulating so we still
keep the B0 option for those.
> BR,
> Stephane.
>
> >+
> >+config BR2_PACKAGE_IMX_SECO_MX8DXLA0
> >+ bool "imx-seco-mx8dxla0"
> >+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> >+
> >+config BR2_PACKAGE_IMX_SECO_MX8DXLA1
> >+ bool "imx-seco-mx8dxla1"
> >+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> >+
> >+config BR2_PACKAGE_IMX_SECO_MX8QMB0
> >+ bool "imx-seco-mx8qmb0"
> >+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> >+
> >+config BR2_PACKAGE_IMX_SECO_MX8QXB0
> >+ bool "imx-seco-mx8qxb0"
> >+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> >+
> >+config BR2_PACKAGE_IMX_SECO_MX8QXC0
> >+ bool "imx-seco-mx8qxc0"
> >+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> >+endchoice
Nitpick: empty line just before 'endchoice'.
> >+config BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE
> >+ string
> >+ default "mx8dxla0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA0
> >+ default "mx8dxla1-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA1
> >+ default "mx8qmb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QMB0
> >+ default "mx8qxb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXB0
> >+ default "mx8qxc0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXC0
> >+
> >+endif
> >diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
> >index 245c3e3311..b1a38b5943 100644
> >--- a/package/freescale-imx/imx-seco/imx-seco.mk
> >+++ b/package/freescale-imx/imx-seco/imx-seco.mk
> >@@ -18,18 +18,16 @@ endef
> >
> > IMX_SECO_INSTALL_IMAGES = YES
> >
> >+IMX_SECO_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE))
> >+ifeq ($(IMX_SECO_AHAB_CONTAINER_IMAGE),)
> >+$(error No iMX Seco AHAB Container Image file specified)
> >+endif
This can't happen: the selection is a choice, so at least one is
enabled, and thus IMX_SECO_AHAB_CONTAINER_IMAGE will always get a
value.
It can only be empty when a new choice entry is added, for which no
corresponding default is added for IMX_SECO_AHAB_CONTAINER_IMAGE.
Regards,
Yann E. MORIN.
> > # SECO firmware is needed when generating imx8-boot-sd.bin which
> > # is done in post-image script.
> >-ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
> >-define IMX_SECO_INSTALL_IMAGES_CMDS
> >- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
> >- $(BINARIES_DIR)/ahab-container.img
> >-endef
> >-else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> > define IMX_SECO_INSTALL_IMAGES_CMDS
> >- cp $(@D)/firmware/seco/mx8qmb0-ahab-container.img \
> >+ cp $(@D)/firmware/seco/$(IMX_SECO_AHAB_CONTAINER_IMAGE) \
> > $(BINARIES_DIR)/ahab-container.img
> > endef
> >-endif
> >
> > $(eval $(generic-package))
> >--
> >2.21.1 (Apple Git-122.3)
> >
> >
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v3] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-28 3:40 [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image Charles Hardin
2021-04-29 8:20 ` Stephane Viau
2021-04-30 16:41 ` [Buildroot] [PATCH v2] " Charles Hardin
@ 2021-04-30 18:09 ` Charles Hardin
2021-05-01 12:57 ` Yann E. MORIN
2 siblings, 1 reply; 9+ messages in thread
From: Charles Hardin @ 2021-04-30 18:09 UTC (permalink / raw)
To: buildroot
From: Charles Hardin <ckhardin@gmail.com>
Update the selection of the ahab container image to use based upon
a choice in the Config.in - there are multiple ASIC revisions that
use AHAB and the firmware images need to match. This extends the
support beyond a default image for just the imx8 amd imx8x based
upon the current contents of the imx-seco firmware extraction.
Files from 3.7.4:
mx8dxla0-ahab-container.img
mx8dxla1-ahab-container.img
mx8qmb0-ahab-container.img
mx8qxb0-ahab-container.img
mx8qxc0-ahab-container.img
The original defaults prior to this patch were mx8qmb0 for IMX8
and mx8qxb0 for the IMX8X selections. However, this patch will
change the default selection of the IMX8X from the B0 option to
C0 because the IMX8X C0 HW variant is widespread and the current
release of hardware silicon. Because there are still B0's in
circulation an option is being kept for that as well.
Signed-off-by: Charles Hardin <ckhardin@gmail.com>
---
Changes v2 -> v3
- add a newline for the endchoice (suggested by Yann)
- in this patch there is no way for contain image to be empty
so remove the protection and assume extensions of choice
will be done correctly in the future (suggested by Yann)
Changes v1 -> v2:
- convert the image selection to a choice in Config.in
(suggested by Stephane)
---
package/freescale-imx/imx-seco/Config.in | 43 ++++++++++++++++++++++
package/freescale-imx/imx-seco/imx-seco.mk | 11 ++----
2 files changed, 46 insertions(+), 8 deletions(-)
diff --git a/package/freescale-imx/imx-seco/Config.in b/package/freescale-imx/imx-seco/Config.in
index 1877664a0c..596683eb13 100644
--- a/package/freescale-imx/imx-seco/Config.in
+++ b/package/freescale-imx/imx-seco/Config.in
@@ -7,3 +7,46 @@ config BR2_PACKAGE_IMX_SECO
This library is provided by Freescale as-is and doesn't have
an upstream.
+
+if BR2_PACKAGE_IMX_SECO
+choice
+ prompt "i.MX Seco Firmware Release"
+ default BR2_PACKAGE_IMX_SECO_MX8QMB0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+ default BR2_PACKAGE_IMX_SECO_MX8QXC0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+ help
+ Select the appropriate ahab container image to install
+ to match the iMX asics revision.
+
+ Note - mismatches result in a failure to boot
+
+config BR2_PACKAGE_IMX_SECO_MX8DXLA0
+ bool "imx-seco-mx8dxla0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8DXLA1
+ bool "imx-seco-mx8dxla1"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8QMB0
+ bool "imx-seco-mx8qmb0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+
+config BR2_PACKAGE_IMX_SECO_MX8QXB0
+ bool "imx-seco-mx8qxb0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+
+config BR2_PACKAGE_IMX_SECO_MX8QXC0
+ bool "imx-seco-mx8qxc0"
+ depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+
+endchoice
+
+config BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE
+ string
+ default "mx8dxla0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA0
+ default "mx8dxla1-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA1
+ default "mx8qmb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QMB0
+ default "mx8qxb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXB0
+ default "mx8qxc0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXC0
+
+endif
diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
index 245c3e3311..79c9722c43 100644
--- a/package/freescale-imx/imx-seco/imx-seco.mk
+++ b/package/freescale-imx/imx-seco/imx-seco.mk
@@ -20,16 +20,11 @@ IMX_SECO_INSTALL_IMAGES = YES
# SECO firmware is needed when generating imx8-boot-sd.bin which
# is done in post-image script.
-ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
-define IMX_SECO_INSTALL_IMAGES_CMDS
- cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
- $(BINARIES_DIR)/ahab-container.img
-endef
-else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
+IMX_SECO_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE))
+
define IMX_SECO_INSTALL_IMAGES_CMDS
- cp $(@D)/firmware/seco/mx8qmb0-ahab-container.img \
+ cp $(@D)/firmware/seco/$(IMX_SECO_AHAB_CONTAINER_IMAGE) \
$(BINARIES_DIR)/ahab-container.img
endef
-endif
$(eval $(generic-package))
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v3] package/imx-seco: use the c0 revision for the imx8qxp ahab image
2021-04-30 18:09 ` [Buildroot] [PATCH v3] " Charles Hardin
@ 2021-05-01 12:57 ` Yann E. MORIN
0 siblings, 0 replies; 9+ messages in thread
From: Yann E. MORIN @ 2021-05-01 12:57 UTC (permalink / raw)
To: buildroot
Charles, All,
On 2021-04-30 11:09 -0700, Charles Hardin spake thusly:
> From: Charles Hardin <ckhardin@gmail.com>
>
> Update the selection of the ahab container image to use based upon
> a choice in the Config.in - there are multiple ASIC revisions that
> use AHAB and the firmware images need to match. This extends the
> support beyond a default image for just the imx8 amd imx8x based
> upon the current contents of the imx-seco firmware extraction.
>
> Files from 3.7.4:
> mx8dxla0-ahab-container.img
> mx8dxla1-ahab-container.img
> mx8qmb0-ahab-container.img
> mx8qxb0-ahab-container.img
> mx8qxc0-ahab-container.img
>
> The original defaults prior to this patch were mx8qmb0 for IMX8
> and mx8qxb0 for the IMX8X selections. However, this patch will
> change the default selection of the IMX8X from the B0 option to
> C0 because the IMX8X C0 HW variant is widespread and the current
> release of hardware silicon. Because there are still B0's in
> circulation an option is being kept for that as well.
>
> Signed-off-by: Charles Hardin <ckhardin@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v2 -> v3
> - add a newline for the endchoice (suggested by Yann)
> - in this patch there is no way for contain image to be empty
> so remove the protection and assume extensions of choice
> will be done correctly in the future (suggested by Yann)
>
> Changes v1 -> v2:
> - convert the image selection to a choice in Config.in
> (suggested by Stephane)
>
>
> ---
> package/freescale-imx/imx-seco/Config.in | 43 ++++++++++++++++++++++
> package/freescale-imx/imx-seco/imx-seco.mk | 11 ++----
> 2 files changed, 46 insertions(+), 8 deletions(-)
>
> diff --git a/package/freescale-imx/imx-seco/Config.in b/package/freescale-imx/imx-seco/Config.in
> index 1877664a0c..596683eb13 100644
> --- a/package/freescale-imx/imx-seco/Config.in
> +++ b/package/freescale-imx/imx-seco/Config.in
> @@ -7,3 +7,46 @@ config BR2_PACKAGE_IMX_SECO
>
> This library is provided by Freescale as-is and doesn't have
> an upstream.
> +
> +if BR2_PACKAGE_IMX_SECO
> +choice
> + prompt "i.MX Seco Firmware Release"
> + default BR2_PACKAGE_IMX_SECO_MX8QMB0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> + default BR2_PACKAGE_IMX_SECO_MX8QXC0 if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> + help
> + Select the appropriate ahab container image to install
> + to match the iMX asics revision.
> +
> + Note - mismatches result in a failure to boot
> +
> +config BR2_PACKAGE_IMX_SECO_MX8DXLA0
> + bool "imx-seco-mx8dxla0"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> +
> +config BR2_PACKAGE_IMX_SECO_MX8DXLA1
> + bool "imx-seco-mx8dxla1"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> +
> +config BR2_PACKAGE_IMX_SECO_MX8QMB0
> + bool "imx-seco-mx8qmb0"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> +
> +config BR2_PACKAGE_IMX_SECO_MX8QXB0
> + bool "imx-seco-mx8qxb0"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> +
> +config BR2_PACKAGE_IMX_SECO_MX8QXC0
> + bool "imx-seco-mx8qxc0"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> +
> +endchoice
> +
> +config BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE
> + string
> + default "mx8dxla0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA0
> + default "mx8dxla1-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8DXLA1
> + default "mx8qmb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QMB0
> + default "mx8qxb0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXB0
> + default "mx8qxc0-ahab-container.img" if BR2_PACKAGE_IMX_SECO_MX8QXC0
> +
> +endif
> diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
> index 245c3e3311..79c9722c43 100644
> --- a/package/freescale-imx/imx-seco/imx-seco.mk
> +++ b/package/freescale-imx/imx-seco/imx-seco.mk
> @@ -20,16 +20,11 @@ IMX_SECO_INSTALL_IMAGES = YES
>
> # SECO firmware is needed when generating imx8-boot-sd.bin which
> # is done in post-image script.
> -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
> -define IMX_SECO_INSTALL_IMAGES_CMDS
> - cp $(@D)/firmware/seco/mx8qxb0-ahab-container.img \
> - $(BINARIES_DIR)/ahab-container.img
> -endef
> -else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> +IMX_SECO_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_IMX_SECO_AHAB_CONTAINER_IMAGE))
> +
> define IMX_SECO_INSTALL_IMAGES_CMDS
> - cp $(@D)/firmware/seco/mx8qmb0-ahab-container.img \
> + cp $(@D)/firmware/seco/$(IMX_SECO_AHAB_CONTAINER_IMAGE) \
> $(BINARIES_DIR)/ahab-container.img
> endef
> -endif
>
> $(eval $(generic-package))
> --
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-05-01 12:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 3:40 [Buildroot] [PATCH 1/1] package/imx-seco: use the c0 revision for the imx8qxp ahab image Charles Hardin
2021-04-29 8:20 ` Stephane Viau
2021-04-29 15:05 ` Charles Hardin
2021-04-30 7:37 ` Stephane Viau
2021-04-30 16:41 ` [Buildroot] [PATCH v2] " Charles Hardin
2021-04-30 17:09 ` Stephane Viau
2021-04-30 17:38 ` Yann E. MORIN
2021-04-30 18:09 ` [Buildroot] [PATCH v3] " Charles Hardin
2021-05-01 12:57 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.