From: Felix Kuehling <Felix.Kuehling@amd.com> To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH 1/2] drm/ttm: Don't evict SG BOs Date: Wed, 28 Apr 2021 01:33:37 -0400 [thread overview] Message-ID: <20210428053338.11560-1-Felix.Kuehling@amd.com> (raw) SG BOs do not occupy space that is managed by TTM. So do not evict them. This fixes unexpected evictions of KFD's userptr BOs. KFD only expects userptr "evictions" in the form of MMU notifiers. Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index de1ec838cf8b..0b953654fdbf 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -655,6 +655,10 @@ int ttm_mem_evict_first(struct ttm_device *bdev, list_for_each_entry(bo, &man->lru[i], lru) { bool busy; + /* Don't evict SG BOs */ + if (bo->ttm && bo->ttm->sg) + continue; + if (!ttm_bo_evict_swapout_allowable(bo, ctx, &locked, &busy)) { if (busy && !busy_bo && ticket != -- 2.31.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Felix Kuehling <Felix.Kuehling@amd.com> To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH 1/2] drm/ttm: Don't evict SG BOs Date: Wed, 28 Apr 2021 01:33:37 -0400 [thread overview] Message-ID: <20210428053338.11560-1-Felix.Kuehling@amd.com> (raw) SG BOs do not occupy space that is managed by TTM. So do not evict them. This fixes unexpected evictions of KFD's userptr BOs. KFD only expects userptr "evictions" in the form of MMU notifiers. Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index de1ec838cf8b..0b953654fdbf 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -655,6 +655,10 @@ int ttm_mem_evict_first(struct ttm_device *bdev, list_for_each_entry(bo, &man->lru[i], lru) { bool busy; + /* Don't evict SG BOs */ + if (bo->ttm && bo->ttm->sg) + continue; + if (!ttm_bo_evict_swapout_allowable(bo, ctx, &locked, &busy)) { if (busy && !busy_bo && ticket != -- 2.31.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2021-04-28 5:34 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-28 5:33 Felix Kuehling [this message] 2021-04-28 5:33 ` [PATCH 1/2] drm/ttm: Don't evict SG BOs Felix Kuehling 2021-04-28 5:33 ` [PATCH 2/2] drm/ttm: Fix swapout in ttm_tt_populate Felix Kuehling 2021-04-28 5:33 ` Felix Kuehling 2021-04-28 7:03 ` Christian König 2021-04-28 7:03 ` Christian König 2021-04-28 7:04 ` [PATCH 1/2] drm/ttm: Don't evict SG BOs Christian König 2021-04-28 7:04 ` Christian König 2021-04-28 7:49 ` Felix Kuehling 2021-04-28 7:49 ` Felix Kuehling 2021-04-28 9:05 ` Christian König 2021-04-28 9:05 ` Christian König 2021-04-28 15:19 ` Felix Kuehling 2021-04-28 15:19 ` Felix Kuehling 2021-04-28 16:33 ` Christian König 2021-04-28 16:33 ` Christian König 2021-04-28 16:49 ` Felix Kuehling 2021-04-28 16:49 ` Felix Kuehling 2021-04-28 16:58 ` Christian König 2021-04-28 16:58 ` Christian König 2021-04-28 17:02 ` Felix Kuehling 2021-04-28 17:02 ` Felix Kuehling
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210428053338.11560-1-Felix.Kuehling@amd.com \ --to=felix.kuehling@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=dri-devel@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.