All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL
@ 2021-04-28  7:20 Zhao Gongyi
  2021-04-28 14:20 ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Zhao Gongyi @ 2021-04-28  7:20 UTC (permalink / raw)
  To: ltp

For those:
	testcases/kernel/syscalls/fcntl/fcntl16.c
	testcases/kernel/syscalls/fcntl/fcntl18.c
	testcases/kernel/syscalls/fcntl/fcntl19.c
	testcases/kernel/syscalls/fcntl/fcntl20.c
	testcases/kernel/syscalls/fcntl/fcntl21.c
	testcases/kernel/syscalls/getpgid/getpgid01.c
	testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
	testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
	testcases/kernel/syscalls/writev/writev05.c
	testcases/kernel/syscalls/writev/writev06.c

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 testcases/kernel/syscalls/fcntl/fcntl16.c     | 12 ++---
 testcases/kernel/syscalls/fcntl/fcntl18.c     | 12 ++---
 testcases/kernel/syscalls/fcntl/fcntl19.c     | 28 ++++++------
 testcases/kernel/syscalls/fcntl/fcntl20.c     | 28 ++++++------
 testcases/kernel/syscalls/fcntl/fcntl21.c     | 44 +++++++++----------
 testcases/kernel/syscalls/getpgid/getpgid01.c | 10 ++---
 .../kernel/syscalls/modify_ldt/modify_ldt01.c | 14 +++---
 .../kernel/syscalls/modify_ldt/modify_ldt02.c | 12 ++---
 testcases/kernel/syscalls/writev/writev05.c   |  4 +-
 testcases/kernel/syscalls/writev/writev06.c   |  4 +-
 10 files changed, 84 insertions(+), 84 deletions(-)

diff --git a/testcases/kernel/syscalls/fcntl/fcntl16.c b/testcases/kernel/syscalls/fcntl/fcntl16.c
index a77a81298..f12474f79 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl16.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl16.c
@@ -673,10 +673,10 @@ int main(int ac, char **av)
 		 */
 		tst_resm(TINFO, "Entering block 1");
 		if (run_test(O_CREAT | O_RDWR | O_TRUNC, 0777, 0, 11)) {
-			tst_resm(TINFO, "Test case 1: without mandatory "
+			tst_resm(TFAIL, "Test case 1: without mandatory "
 				 "locking FAILED");
 		} else {
-			tst_resm(TINFO, "Test case 1: without manadatory "
+			tst_resm(TPASS, "Test case 1: without manadatory "
 				 "locking PASSED");
 		}
 		tst_resm(TINFO, "Exiting block 1");
@@ -689,11 +689,11 @@ int main(int ac, char **av)
 		tst_resm(TINFO, "Entering block 2");
 		if (NO_NFS && run_test(O_CREAT | O_RDWR | O_TRUNC, S_ISGID |
 			     S_IRUSR | S_IWUSR, 0, 11)) {
-			tst_resm(TINFO, "Test case 2: with mandatory record "
+			tst_resm(TFAIL, "Test case 2: with mandatory record "
 				 "locking FAILED");
 		} else {
 			if (NO_NFS)
-				tst_resm(TINFO, "Test case 2: with mandatory"
+				tst_resm(TPASS, "Test case 2: with mandatory"
 					 " record locking PASSED");
 			else
 				tst_resm(TCONF, "Test case 2: NFS does not"
@@ -709,11 +709,11 @@ int main(int ac, char **av)
 		tst_resm(TINFO, "Entering block 3");
 		if (NO_NFS && run_test(O_CREAT | O_RDWR | O_TRUNC | O_NDELAY,
 			     S_ISGID | S_IRUSR | S_IWUSR, 0, 11)) {
-			tst_resm(TINFO, "Test case 3: mandatory locking with "
+			tst_resm(TFAIL, "Test case 3: mandatory locking with "
 				 "NODELAY FAILED");
 		} else {
 			if (NO_NFS)
-				tst_resm(TINFO, "Test case 3: mandatory"
+				tst_resm(TPASS, "Test case 3: mandatory"
 					 " locking with NODELAY PASSED");
 			else
 				tst_resm(TCONF, "Test case 3: NFS does not"
diff --git a/testcases/kernel/syscalls/fcntl/fcntl18.c b/testcases/kernel/syscalls/fcntl/fcntl18.c
index 5eefbd128..18d00ccbf 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl18.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl18.c
@@ -88,9 +88,9 @@ int main(int ac, char **av)
 		fail = 1;
 	}
 	if (fail) {
-		tst_resm(TINFO, "Block 1 FAILED");
+		tst_resm(TFAIL, "Block 1 FAILED");
 	} else {
-		tst_resm(TINFO, "Block 1 PASSED");
+		tst_resm(TPASS, "Block 1 PASSED");
 	}
 	tst_resm(TINFO, "Exit block 1");
 #else
@@ -111,9 +111,9 @@ int main(int ac, char **av)
 		fail = 1;
 	}
 	if (fail) {
-		tst_resm(TINFO, "Block 2 FAILED");
+		tst_resm(TFAIL, "Block 2 FAILED");
 	} else {
-		tst_resm(TINFO, "Block 2 PASSED");
+		tst_resm(TPASS, "Block 2 PASSED");
 	}
 	tst_resm(TINFO, "Exit block 2");
 #else
@@ -150,9 +150,9 @@ int main(int ac, char **av)
 			fail = 1;
 		}
 		if (fail) {
-			tst_resm(TINFO, "Block 3 FAILED");
+			tst_resm(TFAIL, "Block 3 FAILED");
 		} else {
-			tst_resm(TINFO, "Block 3 PASSED");
+			tst_resm(TPASS, "Block 3 PASSED");
 		}
 	}
 	tst_resm(TINFO, "Exit block 3");
diff --git a/testcases/kernel/syscalls/fcntl/fcntl19.c b/testcases/kernel/syscalls/fcntl/fcntl19.c
index 88c91d6ea..441ef00b5 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl19.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl19.c
@@ -353,9 +353,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 1: FAILED");
+			tst_resm(TFAIL, "Test block 1: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 1: PASSED");
+			tst_resm(TPASS, "Test block 1: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");

@@ -396,9 +396,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 2: FAILED");
+			tst_resm(TFAIL, "Test block 2: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 2: PASSED");
+			tst_resm(TPASS, "Test block 2: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 2");

@@ -440,9 +440,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 3: FAILED");
+			tst_resm(TFAIL, "Test block 3: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 3: PASSED");
+			tst_resm(TPASS, "Test block 3: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 3");

@@ -490,9 +490,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 4: FAILED");
+			tst_resm(TFAIL, "Test block 4: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 4: PASSED");
+			tst_resm(TPASS, "Test block 4: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 4");

@@ -534,9 +534,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 5: FAILED");
+			tst_resm(TFAIL, "Test block 5: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 5: PASSED");
+			tst_resm(TPASS, "Test block 5: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 5");

@@ -578,9 +578,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 6: FAILED");
+			tst_resm(TFAIL, "Test block 6: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 6: PASSED");
+			tst_resm(TPASS, "Test block 6: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 6");

@@ -623,9 +623,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 7: FAILED");
+			tst_resm(TFAIL, "Test block 7: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 7: PASSED");
+			tst_resm(TPASS, "Test block 7: PASSED");
 		}

 		tst_resm(TINFO, "Exit block 7");
diff --git a/testcases/kernel/syscalls/fcntl/fcntl20.c b/testcases/kernel/syscalls/fcntl/fcntl20.c
index 99fd78313..2b8b654c4 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl20.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl20.c
@@ -352,9 +352,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 1: FAILED");
+			tst_resm(TFAIL, "Test block 1: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 1: PASSED");
+			tst_resm(TPASS, "Test block 1: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");

@@ -395,9 +395,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 2: FAILED");
+			tst_resm(TFAIL, "Test block 2: FAILED");
 		else
-			tst_resm(TINFO, "Test block 2: PASSED");
+			tst_resm(TPASS, "Test block 2: PASSED");
 		tst_resm(TINFO, "Exit block 2");

 /* //block3: */
@@ -438,9 +438,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 3: FAILED");
+			tst_resm(TFAIL, "Test block 3: FAILED");
 		else
-			tst_resm(TINFO, "Test block 3: PASSED");
+			tst_resm(TPASS, "Test block 3: PASSED");
 		tst_resm(TINFO, "Exit block 3");

 /* //block4: */
@@ -487,9 +487,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 4: FAILED");
+			tst_resm(TFAIL, "Test block 4: FAILED");
 		else
-			tst_resm(TINFO, "Test block 4: PASSED");
+			tst_resm(TPASS, "Test block 4: PASSED");
 		tst_resm(TINFO, "Exit block 4");

 /* //block5: */
@@ -530,9 +530,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 5: FAILED");
+			tst_resm(TFAIL, "Test block 5: FAILED");
 		else
-			tst_resm(TINFO, "Test block 5: PASSED");
+			tst_resm(TPASS, "Test block 5: PASSED");
 		tst_resm(TINFO, "Exit block 5");

 /* //block6: */
@@ -573,9 +573,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 6: FAILED");
+			tst_resm(TFAIL, "Test block 6: FAILED");
 		else
-			tst_resm(TINFO, "Test block 6: PASSED");
+			tst_resm(TPASS, "Test block 6: PASSED");
 		tst_resm(TINFO, "Exit block 6");

 /* //block7: */
@@ -617,9 +617,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail)
-			tst_resm(TINFO, "Test block 7: FAILED");
+			tst_resm(TFAIL, "Test block 7: FAILED");
 		else
-			tst_resm(TINFO, "Test block 7: PASSED");
+			tst_resm(TPASS, "Test block 7: PASSED");

 		tst_resm(TINFO, "Exit block 7");

diff --git a/testcases/kernel/syscalls/fcntl/fcntl21.c b/testcases/kernel/syscalls/fcntl/fcntl21.c
index 8f1a67cf6..bf310ace8 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl21.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl21.c
@@ -347,9 +347,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 1: FAILED");
+			tst_resm(TFAIL, "Test block 1: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 1: PASSED");
+			tst_resm(TPASS, "Test block 1: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");

@@ -378,9 +378,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 2: FAILED");
+			tst_resm(TFAIL, "Test block 2: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 2: PASSED");
+			tst_resm(TPASS, "Test block 2: PASSED");
 		}

 		tst_resm(TINFO, "Exit block 2");
@@ -429,9 +429,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 3: FAILED");
+			tst_resm(TFAIL, "Test block 3: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 3 : PASSED");
+			tst_resm(TPASS, "Test block 3 : PASSED");
 		}
 		tst_resm(TINFO, "Exit block 3");

@@ -479,9 +479,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 4: FAILED");
+			tst_resm(TFAIL, "Test block 4: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 4: PASSED");
+			tst_resm(TPASS, "Test block 4: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 4");

@@ -529,9 +529,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 5: FAILED");
+			tst_resm(TFAIL, "Test block 5: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 5: PASSED");
+			tst_resm(TPASS, "Test block 5: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 5");

@@ -579,9 +579,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 6 FAILED");
+			tst_resm(TFAIL, "Test block 6 FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 6 PASSED");
+			tst_resm(TPASS, "Test block 6 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 6");

@@ -634,9 +634,9 @@ int main(int ac, char **av)
 		 */
 		unlock_file();
 		if (fail) {
-			tst_resm(TINFO, "Test block 7: FAILED");
+			tst_resm(TFAIL, "Test block 7: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 7: PASSED");
+			tst_resm(TPASS, "Test block 7: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 7");

@@ -686,9 +686,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 8: FAILED");
+			tst_resm(TFAIL, "Test block 8: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 8: PASSED");
+			tst_resm(TPASS, "Test block 8: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 8");

@@ -739,9 +739,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 9: FAILED");
+			tst_resm(TFAIL, "Test block 9: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 9: PASSED");
+			tst_resm(TPASS, "Test block 9: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 9");

@@ -793,9 +793,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 10: FAILED");
+			tst_resm(TFAIL, "Test block 10: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 10: PASSED");
+			tst_resm(TPASS, "Test block 10: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 10");

@@ -849,9 +849,9 @@ int main(int ac, char **av)
 		unlock_file();

 		if (fail) {
-			tst_resm(TINFO, "Test block 11: FAILED");
+			tst_resm(TFAIL, "Test block 11: FAILED");
 		} else {
-			tst_resm(TINFO, "Test block 11: PASSED");
+			tst_resm(TPASS, "Test block 11: PASSED");
 		}
 		tst_resm(TINFO, "Exit block 11");

diff --git a/testcases/kernel/syscalls/getpgid/getpgid01.c b/testcases/kernel/syscalls/getpgid/getpgid01.c
index 9af523d88..424dcd8bf 100644
--- a/testcases/kernel/syscalls/getpgid/getpgid01.c
+++ b/testcases/kernel/syscalls/getpgid/getpgid01.c
@@ -77,9 +77,9 @@ int main(int ac, char **av)
 			while ((pgid_0 = wait(&ex_stat)) != -1) ;

 			if (WEXITSTATUS(ex_stat) == 0)
-				tst_resm(TINFO, "%s PASSED", TCID);
+				tst_resm(TPASS, "%s PASSED", TCID);
 			else
-				tst_resm(TINFO, "%s FAILED", TCID);
+				tst_resm(TFAIL, "%s FAILED", TCID);

 			exit(0);
 		}
@@ -92,7 +92,7 @@ int main(int ac, char **av)
 		}

 		if (fail)
-			tst_resm(TINFO, "Test block 1: getpgid(0) FAILED");
+			tst_resm(TFAIL, "Test block 1: getpgid(0) FAILED");
 		else
 			tst_resm(TPASS, "Test block 1: getpgid(0) PASSED");
 		tst_resm(TINFO, "Exit block 1");
@@ -155,7 +155,7 @@ int main(int ac, char **av)
 		}

 		if (fail)
-			tst_resm(TINFO, "Test block 4: getpgid(1) FAILED");
+			tst_resm(TFAIL, "Test block 4: getpgid(1) FAILED");
 		else
 			tst_resm(TPASS, "Test block 4: getpgid(1) PASSED");
 		tst_resm(TINFO, "Exit block 4");
@@ -170,7 +170,7 @@ int main(int ac, char **av)
 		}

 		if (fail)
-			tst_resm(TINFO, "Test block 5: getpgid(1) FAILED");
+			tst_resm(TFAIL, "Test block 5: getpgid(1) FAILED");
 		else
 			tst_resm(TPASS, "Test block 5: getpgid(1) PASSED");
 		tst_resm(TINFO, "Exit block 5");
diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c b/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
index 248111814..dc489988d 100644
--- a/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
+++ b/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
@@ -134,9 +134,9 @@ int main(int ac, char **av)
 		}

 		if (flag) {
-			tst_resm(TINFO, "block 1 FAILED");
+			tst_resm(TFAIL, "block 1 FAILED");
 		} else {
-			tst_resm(TINFO, "block 1 PASSED");
+			tst_resm(TPASS, "block 1 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");
 		free(ptr);
@@ -165,9 +165,9 @@ int main(int ac, char **av)
 		}

 		if (flag) {
-			tst_resm(TINFO, "block 2 FAILED");
+			tst_resm(TFAIL, "block 2 FAILED");
 		} else {
-			tst_resm(TINFO, "block 2 PASSED");
+			tst_resm(TPASS, "block 2 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 2");

@@ -177,7 +177,7 @@ int main(int ac, char **av)
 		 * Create a new LDT segment.
 		 */
 		if (create_segment(seg, sizeof(seg)) == -1) {
-			tst_brkm(TINFO, cleanup, "Creation of segment failed");
+			tst_brkm(TBROK, cleanup, "Creation of segment failed");
 		}

 		/*
@@ -200,9 +200,9 @@ int main(int ac, char **av)
 		}

 		if (flag) {
-			tst_resm(TINFO, "block 3 FAILED");
+			tst_resm(TFAIL, "block 3 FAILED");
 		} else {
-			tst_resm(TINFO, "block 3 PASSED");
+			tst_resm(TPASS, "block 3 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 3");

diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
index c953ac420..d5b56aa9c 100644
--- a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
+++ b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
@@ -113,7 +113,7 @@ int main(int ac, char **av)

 		seg[0] = 12345;
 		if (create_segment(seg, sizeof(seg)) == -1) {
-			tst_brkm(TINFO, cleanup, "Creation of segment failed");
+			tst_brkm(TBROK, cleanup, "Creation of segment failed");
 		}

 		val = read_segment(0);
@@ -125,9 +125,9 @@ int main(int ac, char **av)
 		}

 		if (flag) {
-			tst_resm(TINFO, "block 1 FAILED");
+			tst_resm(TFAIL, "block 1 FAILED");
 		} else {
-			tst_resm(TINFO, "block 1 PASSED");
+			tst_resm(TPASS, "block 1 PASSED");
 		}

 		tst_resm(TINFO, "Exit block 1");
@@ -137,7 +137,7 @@ int main(int ac, char **av)
 		flag = 0;

 		if (create_segment(0, 10) == -1) {
-			tst_brkm(TINFO, cleanup, "Creation of segment failed");
+			tst_brkm(TBROK, cleanup, "Creation of segment failed");
 		}

 		tst_old_flush();
@@ -155,9 +155,9 @@ int main(int ac, char **av)
 		}

 		if (flag) {
-			tst_resm(TINFO, "block 2 FAILED");
+			tst_resm(TFAIL, "block 2 FAILED");
 		} else {
-			tst_resm(TINFO, "block 2 PASSED");
+			tst_resm(TPASS, "block 2 PASSED");
 		}
 	}
 	cleanup();
diff --git a/testcases/kernel/syscalls/writev/writev05.c b/testcases/kernel/syscalls/writev/writev05.c
index 910fa23b8..8fc3c9967 100644
--- a/testcases/kernel/syscalls/writev/writev05.c
+++ b/testcases/kernel/syscalls/writev/writev05.c
@@ -179,9 +179,9 @@ int main(int argc, char **argv)
 			fail = 1;
 		}
 		if (fail) {
-			tst_resm(TINFO, "block 1 FAILED");
+			tst_resm(TFAIL, "block 1 FAILED");
 		} else {
-			tst_resm(TINFO, "block 1 PASSED");
+			tst_resm(TPASS, "block 1 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");
 	}
diff --git a/testcases/kernel/syscalls/writev/writev06.c b/testcases/kernel/syscalls/writev/writev06.c
index 6fe7206e8..3cab2ef05 100644
--- a/testcases/kernel/syscalls/writev/writev06.c
+++ b/testcases/kernel/syscalls/writev/writev06.c
@@ -138,9 +138,9 @@ int main(int argc, char **argv)
 			fail = 1;
 		}
 		if (fail) {
-			tst_resm(TINFO, "block 1 FAILED");
+			tst_resm(TFAIL, "block 1 FAILED");
 		} else {
-			tst_resm(TINFO, "block 1 PASSED");
+			tst_resm(TPASS, "block 1 PASSED");
 		}
 		tst_resm(TINFO, "Exit block 1");
 	}
--
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL
  2021-04-28  7:20 [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL Zhao Gongyi
@ 2021-04-28 14:20 ` Cyril Hrubis
  0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2021-04-28 14:20 UTC (permalink / raw)
  To: ltp

Hi!
> diff --git a/testcases/kernel/syscalls/fcntl/fcntl16.c b/testcases/kernel/syscalls/fcntl/fcntl16.c
> index a77a81298..f12474f79 100644
> --- a/testcases/kernel/syscalls/fcntl/fcntl16.c
> +++ b/testcases/kernel/syscalls/fcntl/fcntl16.c
> @@ -673,10 +673,10 @@ int main(int ac, char **av)
>  		 */
>  		tst_resm(TINFO, "Entering block 1");
>  		if (run_test(O_CREAT | O_RDWR | O_TRUNC, 0777, 0, 11)) {
> -			tst_resm(TINFO, "Test case 1: without mandatory "
> +			tst_resm(TFAIL, "Test case 1: without mandatory "
>  				 "locking FAILED");
>  		} else {
> -			tst_resm(TINFO, "Test case 1: without manadatory "
> +			tst_resm(TPASS, "Test case 1: without manadatory "
>  				 "locking PASSED");
>  		}

I would be happier if we fixed the run_test() function to report
TFAIL/TPASS in all cases and just called run_test() from the main().

It shouldn't be even a big change since we report most of the failures
there, what we need is to change one TINFO into TFAIL and report TPASS
at the end of the function.

>  		tst_resm(TINFO, "Exiting block 1");

Also can we please get rid of the useless entering/exitting block
messages?


And the same applies for the rest of the tests changed by this patch.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL
@ 2021-04-29 13:05 zhaogongyi
  0 siblings, 0 replies; 3+ messages in thread
From: zhaogongyi @ 2021-04-29 13:05 UTC (permalink / raw)
  To: ltp

Hi Cyril,

I have split the commit to 4 separate commits and resubmit according your review. 

Pleas see:
https://patchwork.ozlabs.org/project/ltp/patch/20210429125322.31559-1-zhaogongyi@huawei.com/
https://patchwork.ozlabs.org/project/ltp/patch/20210429125255.31510-1-zhaogongyi@huawei.com/
https://patchwork.ozlabs.org/project/ltp/patch/20210429125237.31461-1-zhaogongyi@huawei.com/
https://patchwork.ozlabs.org/project/ltp/patch/20210429125220.31412-1-zhaogongyi@huawei.com/

And for the files fcntl19.c/fcntl20.c/fcntl21.c, there are some difficult problems to cleanup, it would be fixed in latter patches.


Thanks so much!

Best Regards,
Gongyi


> Hi!
> > diff --git a/testcases/kernel/syscalls/fcntl/fcntl16.c
> > b/testcases/kernel/syscalls/fcntl/fcntl16.c
> > index a77a81298..f12474f79 100644
> > --- a/testcases/kernel/syscalls/fcntl/fcntl16.c
> > +++ b/testcases/kernel/syscalls/fcntl/fcntl16.c
> > @@ -673,10 +673,10 @@ int main(int ac, char **av)
> >  		 */
> >  		tst_resm(TINFO, "Entering block 1");
> >  		if (run_test(O_CREAT | O_RDWR | O_TRUNC, 0777, 0, 11)) {
> > -			tst_resm(TINFO, "Test case 1: without mandatory "
> > +			tst_resm(TFAIL, "Test case 1: without mandatory "
> >  				 "locking FAILED");
> >  		} else {
> > -			tst_resm(TINFO, "Test case 1: without manadatory "
> > +			tst_resm(TPASS, "Test case 1: without manadatory "
> >  				 "locking PASSED");
> >  		}
> 
> I would be happier if we fixed the run_test() function to report
> TFAIL/TPASS in all cases and just called run_test() from the main().
> 
> It shouldn't be even a big change since we report most of the failures
> there, what we need is to change one TINFO into TFAIL and report TPASS at
> the end of the function.
> 
> >  		tst_resm(TINFO, "Exiting block 1");
> 
> Also can we please get rid of the useless entering/exitting block
> messages?
> 
> 
> And the same applies for the rest of the tests changed by this patch.
> 
> --
> Cyril Hrubis
> chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-29 13:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28  7:20 [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL Zhao Gongyi
2021-04-28 14:20 ` Cyril Hrubis
2021-04-29 13:05 zhaogongyi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.