* [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port
@ 2021-04-29 5:53 Kalesh A P
2021-05-02 22:33 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Kalesh A P @ 2021-04-29 5:53 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
extra check needed for VF along with BNXT_SINGLE_PF(bp).
Also make error messages more explicit.
Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
Fixes: f86febfb46da ("net/bnxt: support VF")
Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index f5d2dc8..50cb12d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
if (rc)
return rc;
- if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
- PMD_DRV_LOG(ERR, "Flow Control Settings cannot be modified\n");
+ if (!BNXT_SINGLE_PF(bp)) {
+ PMD_DRV_LOG(ERR,
+ "Flow Control Settings cannot be modified on VF or on shared PF\n");
return -ENOTSUP;
}
@@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev, uint16_t pvid, int on)
if (rc)
return rc;
- if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
- PMD_DRV_LOG(ERR,
- "PVID cannot be modified for this function\n");
+ if (!BNXT_SINGLE_PF(bp)) {
+ PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on shared PF\n");
return -ENOTSUP;
}
bp->vlan = on ? pvid : 0;
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port
2021-04-29 5:53 [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port Kalesh A P
@ 2021-05-02 22:33 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2021-05-02 22:33 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
On Wed, Apr 28, 2021 at 10:31 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
> extra check needed for VF along with BNXT_SINGLE_PF(bp).
>
> Also make error messages more explicit.
>
> Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
> Fixes: f86febfb46da ("net/bnxt: support VF")
> Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index f5d2dc8..50cb12d 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev
> *dev,
> if (rc)
> return rc;
>
> - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> - PMD_DRV_LOG(ERR, "Flow Control Settings cannot be
> modified\n");
> + if (!BNXT_SINGLE_PF(bp)) {
> + PMD_DRV_LOG(ERR,
> + "Flow Control Settings cannot be modified on
> VF or on shared PF\n");
> return -ENOTSUP;
> }
>
> @@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev,
> uint16_t pvid, int on)
> if (rc)
> return rc;
>
> - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> - PMD_DRV_LOG(ERR,
> - "PVID cannot be modified for this function\n");
> + if (!BNXT_SINGLE_PF(bp)) {
> + PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on
> shared PF\n");
> return -ENOTSUP;
> }
> bp->vlan = on ? pvid : 0;
> --
> 2.10.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-02 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 5:53 [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port Kalesh A P
2021-05-02 22:33 ` Ajit Khaparde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.