Re: [RFC PATCH v4 04/27] qed: Add support of HW filter block

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3720 bytes --]

Hi Shai,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on ipvs/master]
[also build test WARNING on hch-configfs/for-next linus/master v5.12 next-20210429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/caa1600cbe7295b770621c5990833e2e4571ce1b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
        git checkout caa1600cbe7295b770621c5990833e2e4571ce1b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/qlogic/qed/qed_dev.c:5381:5: warning: no previous prototype for 'qed_abs_ppfid' [-Wmissing-prototypes]
    5381 | int qed_abs_ppfid(struct qed_dev *cdev, u8 rel_ppfid, u8 *p_abs_ppfid)
         |     ^~~~~~~~~~~~~
>> drivers/net/ethernet/qlogic/qed/qed_dev.c:5398:6: warning: no previous prototype for 'qed_llh_clear_ppfid_filters' [-Wmissing-prototypes]
    5398 | void qed_llh_clear_ppfid_filters(struct qed_dev *cdev, u8 ppfid)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/qed_abs_ppfid +5381 drivers/net/ethernet/qlogic/qed/qed_dev.c

  5380	
> 5381	int qed_abs_ppfid(struct qed_dev *cdev, u8 rel_ppfid, u8 *p_abs_ppfid)
  5382	{
  5383		struct qed_llh_info *p_llh_info = cdev->p_llh_info;
  5384	
  5385		if (rel_ppfid >= p_llh_info->num_ppfid) {
  5386			DP_NOTICE(cdev,
  5387				  "rel_ppfid %d is not valid, available indices are 0..%hhu\n",
  5388				  rel_ppfid, p_llh_info->num_ppfid - 1);
  5389	
  5390			return -EINVAL;
  5391		}
  5392	
  5393		*p_abs_ppfid = p_llh_info->ppfid_array[rel_ppfid];
  5394	
  5395		return 0;
  5396	}
  5397	
> 5398	void qed_llh_clear_ppfid_filters(struct qed_dev *cdev, u8 ppfid)
  5399	{
  5400		struct qed_hwfn *p_hwfn = QED_LEADING_HWFN(cdev);
  5401		struct qed_ptt *p_ptt = qed_ptt_acquire(p_hwfn);
  5402		u8 filter_idx, abs_ppfid;
  5403		int rc = 0;
  5404	
  5405		if (!p_ptt)
  5406			return;
  5407	
  5408		if (!test_bit(QED_MF_LLH_PROTO_CLSS, &cdev->mf_bits) &&
  5409		    !test_bit(QED_MF_LLH_MAC_CLSS, &cdev->mf_bits))
  5410			goto out;
  5411	
  5412		rc = qed_abs_ppfid(cdev, ppfid, &abs_ppfid);
  5413		if (rc)
  5414			goto out;
  5415	
  5416		rc = qed_llh_shadow_remove_all_filters(cdev, ppfid);
  5417		if (rc)
  5418			goto out;
  5419	
  5420		for (filter_idx = 0; filter_idx < NIG_REG_LLH_FUNC_FILTER_EN_SIZE;
  5421		     filter_idx++) {
  5422			rc = qed_llh_remove_filter(p_hwfn, p_ptt,
  5423						   abs_ppfid, filter_idx);
  5424			if (rc)
  5425				goto out;
  5426		}
  5427	out:
  5428		qed_ptt_release(p_hwfn, p_ptt);
  5429	}
  5430	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68989 bytes --]