Re: [RFC PATCH v4 24/27] qedn: Add support of NVME ICReq & ICResp

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 8498 bytes --]

Hi Shai,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on ipvs/master]
[also build test WARNING on hch-configfs/for-next linus/master v5.12 next-20210429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8ebe84a1626c4a95151693a49798b1316cb5af62
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
        git checkout 8ebe84a1626c4a95151693a49798b1316cb5af62
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/nvme/hw/qedn/qedn_conn.c:103:5: warning: no previous prototype for 'qedn_fill_ep_addr4' [-Wmissing-prototypes]
     103 | int qedn_fill_ep_addr4(struct qedn_endpoint *ep,
         |     ^~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c:119:5: warning: no previous prototype for 'qedn_fill_ep_addr6' [-Wmissing-prototypes]
     119 | int qedn_fill_ep_addr6(struct qedn_endpoint *ep,
         |     ^~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c: In function 'qedn_fetch_tcp_port':
   drivers/nvme/hw/qedn/qedn_conn.c:361:20: warning: variable 'qctrl' set but not used [-Wunused-but-set-variable]
     361 |  struct qedn_ctrl *qctrl;
         |                    ^~~~~
   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:13,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/mips/include/uapi/asm/byteorder.h:13,
                    from arch/mips/include/asm/bitops.h:20,
                    from include/linux/bitops.h:32,
                    from include/linux/kernel.h:11,
                    from drivers/nvme/hw/qedn/qedn_conn.c:9:
   drivers/nvme/hw/qedn/qedn_conn.c: In function 'qedn_send_icreq':
>> drivers/nvme/hw/qedn/qedn_conn.c:484:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     484 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c:484:23: note: in expansion of macro 'cpu_to_le32'
     484 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c:485:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     485 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c:485:23: note: in expansion of macro 'cpu_to_le32'
     485 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c: At top level:
   drivers/nvme/hw/qedn/qedn_conn.c:767:6: warning: no previous prototype for 'qedn_destroy_connection' [-Wmissing-prototypes]
     767 | void qedn_destroy_connection(struct qedn_conn_ctx *conn_ctx)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_conn.c: In function 'qedn_sp_wq_handler':
   drivers/nvme/hw/qedn/qedn_conn.c:788:19: warning: variable 'qedn' set but not used [-Wunused-but-set-variable]
     788 |  struct qedn_ctx *qedn;
         |                   ^~~~
   At top level:
   drivers/nvme/hw/qedn/qedn_conn.c:18:27: warning: 'qedn_conn_state_str' defined but not used [-Wunused-const-variable=]
      18 | static const char * const qedn_conn_state_str[] = {
         |                           ^~~~~~~~~~~~~~~~~~~


vim +484 drivers/nvme/hw/qedn/qedn_conn.c

   448	
   449	static int qedn_send_icreq(struct qedn_conn_ctx *conn_ctx)
   450	{
   451		struct nvmetcp_init_conn_req_hdr *icreq_ptr = NULL;
   452		struct storage_sgl_task_params *sgl_task_params;
   453		struct nvmetcp_task_params task_params;
   454		struct qedn_task_ctx *qedn_task = NULL;
   455		struct nvme_tcp_icreq_pdu icreq;
   456		struct nvmetcp_wqe *chain_sqe;
   457		struct nvmetcp_wqe local_sqe;
   458	
   459		qedn_task = qedn_get_task_from_pool_insist(conn_ctx, QEDN_ICREQ_CCCID);
   460		if (!qedn_task)
   461			return -EINVAL;
   462	
   463		memset(&icreq, 0, sizeof(icreq));
   464		memset(&local_sqe, 0, sizeof(local_sqe));
   465	
   466		/* Initialize ICReq */
   467		icreq.hdr.type = nvme_tcp_icreq;
   468		icreq.hdr.hlen = sizeof(icreq);
   469		icreq.hdr.pdo = 0;
   470		icreq.hdr.plen = cpu_to_le32(icreq.hdr.hlen);
   471		icreq.pfv = cpu_to_le16(conn_ctx->required_params.pfv);
   472		icreq.maxr2t = cpu_to_le32(conn_ctx->required_params.maxr2t);
   473		icreq.hpda = conn_ctx->required_params.hpda;
   474		if (conn_ctx->required_params.hdr_digest)
   475			icreq.digest |= NVME_TCP_HDR_DIGEST_ENABLE;
   476		if (conn_ctx->required_params.data_digest)
   477			icreq.digest |= NVME_TCP_DATA_DIGEST_ENABLE;
   478	
   479		qedn_swap_bytes((u32 *)&icreq,
   480				(sizeof(icreq) - QEDN_ICREQ_FW_PAYLOAD) /
   481				 sizeof(u32));
   482	
   483		/* Initialize task params */
 > 484		task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
   485		task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
   486		task_params.context = qedn_task->fw_task_ctx;
   487		task_params.sqe = &local_sqe;
   488		task_params.conn_icid = (u16)conn_ctx->conn_handle;
   489		task_params.itid = qedn_task->itid;
   490		task_params.cq_rss_number = conn_ctx->default_cq;
   491		task_params.tx_io_size = QEDN_ICREQ_FW_PAYLOAD;
   492		task_params.rx_io_size = 0; /* Rx doesn't use SGL for icresp */
   493	
   494		/* Init SGE for ICReq padding */
   495		sgl_task_params = &qedn_task->sgl_task_params;
   496		sgl_task_params->total_buffer_size = task_params.tx_io_size;
   497		sgl_task_params->small_mid_sge = false;
   498		sgl_task_params->num_sges = 1;
   499		memcpy(sgl_task_params->sgl, &conn_ctx->icreq_pad->sge,
   500		       sizeof(conn_ctx->icreq_pad->sge));
   501		icreq_ptr = (struct nvmetcp_init_conn_req_hdr *)&icreq;
   502	
   503		qed_ops->init_icreq_exchange(&task_params, icreq_ptr, sgl_task_params,  NULL);
   504	
   505		qedn_set_con_state(conn_ctx, CONN_STATE_WAIT_FOR_IC_COMP);
   506		atomic_inc(&conn_ctx->num_active_fw_tasks);
   507	
   508		/* spin_lock - doorbell is accessed  both Rx flow and response flow */
   509		spin_lock(&conn_ctx->ep.doorbell_lock);
   510		chain_sqe = qed_chain_produce(&conn_ctx->ep.fw_sq_chain);
   511		memcpy(chain_sqe, &local_sqe, sizeof(local_sqe));
   512		qedn_ring_doorbell(conn_ctx);
   513		spin_unlock(&conn_ctx->ep.doorbell_lock);
   514	
   515		return 0;
   516	}
   517	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70250 bytes --]