From: Steven Rostedt <rostedt@goodmis.org>
To: <Peter.Enderborg@sony.com>
Cc: <ebiederm@xmission.com>, <linux-kernel@vger.kernel.org>,
<mingo@redhat.com>, <akpm@linux-foundation.org>,
<peterz@infradead.org>, <ast@kernel.org>,
<christian.brauner@ubuntu.com>, <dave@stgolabs.net>,
<walken@google.com>, <jannh@google.com>,
<mathieu.desnoyers@efficios.com>, <christophe.leroy@c-s.fr>,
<minchan@kernel.org>
Subject: Re: [PATCH 1/2] tracing: Add a trace for task_exit
Date: Sat, 1 May 2021 09:11:04 -0400 [thread overview]
Message-ID: <20210501091104.418765bd@oasis.local.home> (raw)
In-Reply-To: <4bb24db4-f720-f5e7-9054-36bdeaee1d79@sony.com>
On Sat, 1 May 2021 09:29:41 +0000
<Peter.Enderborg@sony.com> wrote:
> On 4/30/21 7:48 PM, Eric W. Biederman wrote:
> > Peter Enderborg <peter.enderborg@sony.com> writes:
> >
> >> This is the peer functions to task_rename and task_newtask.
> >> With this we get hole "life-cycle" of task and can easily
> >> see short livied task and their exit status.
> > This patch is incorrect. The location you are dealing with is not part
> > of task exit. The location you have instrumented is part of reaping a
> > task which can come arbitrarily long after the task exits.
>
> That is what it aiming. When using this as tool for userspace you
> would like to know when the task is done. When it no longer
> holds any thing that might have any impact. If you think the
> exit imply something more specific I can change the name.
>
> I thought exit was a good name, it is in in exit.c.
>
> Will the name task_done, task_finished or task_reaped work for you?
I think "task_reaped" is probably the best name, and the most
descriptive of what happened.
-- Steve
next prev parent reply other threads:[~2021-05-01 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 14:22 [PATCH 0/2] tracing: Add trace for task_exit Peter Enderborg
2021-04-30 14:22 ` [PATCH 1/2] tracing: Add a " Peter Enderborg
2021-04-30 17:48 ` Eric W. Biederman
2021-05-01 9:29 ` Peter.Enderborg
2021-05-01 13:11 ` Steven Rostedt [this message]
2021-05-03 13:50 ` Mathieu Desnoyers
2021-05-03 14:48 ` Peter.Enderborg
2021-05-03 16:30 ` Eric W. Biederman
2021-05-03 18:04 ` Peter.Enderborg
2021-05-03 19:02 ` Eric W. Biederman
2021-05-03 19:43 ` Peter.Enderborg
2021-05-03 20:55 ` Steven Rostedt
2021-05-04 8:00 ` Peter.Enderborg
2021-05-04 13:18 ` Steven Rostedt
2021-04-30 14:22 ` [PATCH 2/2] tracing: Align task.h to use __assing_str for strings Peter Enderborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210501091104.418765bd@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=Peter.Enderborg@sony.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=christophe.leroy@c-s.fr \
--cc=dave@stgolabs.net \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.