drivers/thermal/gov_fair_share.c:111:3: error: implicit declaration of function '__thermal_cdev_update'; did you mean 'thermal_cdev_update'?

* drivers/thermal/gov_fair_share.c:111:3: error: implicit declaration of function '__thermal_cdev_update'; did you mean 'thermal_cdev_update'?
@ 2021-05-02  2:43 kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-05-02  2:43 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3923 bytes --]

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20210428-034658/Lukasz-Luba/Thermal-governors-improvements-and-a-fix/20210422-233837
head:   0132ffa6d46e1cd553a9338ff92bfe01a00db745
commit: f9ecc444989962540005c5d0ac9d9a03d2df2c19 thermal/core/fair share: Use the lockless __thermal_cdev_update() function
date:   4 days ago
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/f9ecc444989962540005c5d0ac9d9a03d2df2c19
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review UPDATE-20210428-034658/Lukasz-Luba/Thermal-governors-improvements-and-a-fix/20210422-233837
        git checkout f9ecc444989962540005c5d0ac9d9a03d2df2c19
        # save the attached .config to linux build tree
        make W=1 W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/thermal/gov_fair_share.c: In function 'fair_share_throttle':
>> drivers/thermal/gov_fair_share.c:111:3: error: implicit declaration of function '__thermal_cdev_update'; did you mean 'thermal_cdev_update'? [-Werror=implicit-function-declaration]
     111 |   __thermal_cdev_update(cdev);
         |   ^~~~~~~~~~~~~~~~~~~~~
         |   thermal_cdev_update
   cc1: some warnings being treated as errors

vim +111 drivers/thermal/gov_fair_share.c

    58	
    59	/**
    60	 * fair_share_throttle - throttles devices associated with the given zone
    61	 * @tz: thermal_zone_device
    62	 * @trip: trip point index
    63	 *
    64	 * Throttling Logic: This uses three parameters to calculate the new
    65	 * throttle state of the cooling devices associated with the given zone.
    66	 *
    67	 * Parameters used for Throttling:
    68	 * P1. max_state: Maximum throttle state exposed by the cooling device.
    69	 * P2. percentage[i]/100:
    70	 *	How 'effective' the 'i'th device is, in cooling the given zone.
    71	 * P3. cur_trip_level/max_no_of_trips:
    72	 *	This describes the extent to which the devices should be throttled.
    73	 *	We do not want to throttle too much when we trip a lower temperature,
    74	 *	whereas the throttling is at full swing if we trip critical levels.
    75	 *	(Heavily assumes the trip points are in ascending order)
    76	 * new_state of cooling device = P3 * P2 * P1
    77	 */
    78	static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
    79	{
    80		struct thermal_instance *instance;
    81		int total_weight = 0;
    82		int total_instance = 0;
    83		int cur_trip_level = get_trip_level(tz);
    84	
    85		mutex_lock(&tz->lock);
    86	
    87		list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
    88			if (instance->trip != trip)
    89				continue;
    90	
    91			total_weight += instance->weight;
    92			total_instance++;
    93		}
    94	
    95		list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
    96			int percentage;
    97			struct thermal_cooling_device *cdev = instance->cdev;
    98	
    99			if (instance->trip != trip)
   100				continue;
   101	
   102			if (!total_weight)
   103				percentage = 100 / total_instance;
   104			else
   105				percentage = (instance->weight * 100) / total_weight;
   106	
   107			instance->target = get_target_state(tz, cdev, percentage,
   108							    cur_trip_level);
   109	
   110			mutex_lock(&cdev->lock);
 > 111			__thermal_cdev_update(cdev);
   112			mutex_unlock(&cdev->lock);
   113		}
   114	
   115		mutex_unlock(&tz->lock);
   116		return 0;
   117	}
   118	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41492 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread