* [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface @ 2021-05-02 16:39 Philippe Mathieu-Daudé 2021-05-02 16:39 ` [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) Philippe Mathieu-Daudé ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-02 16:39 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, Philippe Mathieu-Daudé, Laurent Vivier, Edgar E. Iglesias, Paolo Bonzini Remove qemu_register_reset() when a qdev type has a qbus parent, implementing the 3-phase Resettable interface. Since v2: - Lower IRQ in 'hold' phase, not 'exit' one (Edgar) Since v1: - Use 3-phase reset interface instead of qdev one (Laurent) Supersedes: <20210423233652.3042941-1-f4bug@amsat.org> Philippe Mathieu-Daudé (2): hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface) hw/rtc/mc146818rtc.c | 42 +++++++++++++++++++++------------------- hw/timer/etraxfs_timer.c | 14 +++++++++++--- 2 files changed, 33 insertions(+), 23 deletions(-) -- 2.26.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) 2021-05-02 16:39 [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé @ 2021-05-02 16:39 ` Philippe Mathieu-Daudé 2021-05-03 16:51 ` Edgar E. Iglesias 2021-05-02 16:39 ` [PATCH v3 2/2] hw/rtc/mc146818rtc: " Philippe Mathieu-Daudé 2021-05-11 3:29 ` [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-02 16:39 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, Philippe Mathieu-Daudé, Laurent Vivier, Edgar E. Iglesias, Paolo Bonzini TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). Convert the generic reset to a enter/hold resettable ones, and remove the qemu_register_reset() call. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/timer/etraxfs_timer.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/timer/etraxfs_timer.c b/hw/timer/etraxfs_timer.c index 5379006086f..4ba662190de 100644 --- a/hw/timer/etraxfs_timer.c +++ b/hw/timer/etraxfs_timer.c @@ -309,9 +309,9 @@ static const MemoryRegionOps timer_ops = { } }; -static void etraxfs_timer_reset(void *opaque) +static void etraxfs_timer_reset_enter(Object *obj, ResetType type) { - ETRAXTimerState *t = opaque; + ETRAXTimerState *t = ETRAX_TIMER(obj); ptimer_transaction_begin(t->ptimer_t0); ptimer_stop(t->ptimer_t0); @@ -325,6 +325,12 @@ static void etraxfs_timer_reset(void *opaque) t->rw_wd_ctrl = 0; t->r_intr = 0; t->rw_intr_mask = 0; +} + +static void etraxfs_timer_reset_hold(Object *obj) +{ + ETRAXTimerState *t = ETRAX_TIMER(obj); + qemu_irq_lower(t->irq); } @@ -343,14 +349,16 @@ static void etraxfs_timer_realize(DeviceState *dev, Error **errp) memory_region_init_io(&t->mmio, OBJECT(t), &timer_ops, t, "etraxfs-timer", 0x5c); sysbus_init_mmio(sbd, &t->mmio); - qemu_register_reset(etraxfs_timer_reset, t); } static void etraxfs_timer_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); + ResettableClass *rc = RESETTABLE_CLASS(klass); dc->realize = etraxfs_timer_realize; + rc->phases.enter = etraxfs_timer_reset_enter; + rc->phases.hold = etraxfs_timer_reset_hold; } static const TypeInfo etraxfs_timer_info = { -- 2.26.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) 2021-05-02 16:39 ` [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) Philippe Mathieu-Daudé @ 2021-05-03 16:51 ` Edgar E. Iglesias 0 siblings, 0 replies; 8+ messages in thread From: Edgar E. Iglesias @ 2021-05-03 16:51 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Paolo Bonzini, Michael S. Tsirkin, Laurent Vivier, qemu-devel, Peter Maydell On Sun, May 02, 2021 at 06:39:30PM +0200, Philippe Mathieu-Daudé wrote: > TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset() > handler is called automatically when its qbus parent is reset > (we don't need to register it manually). > > Convert the generic reset to a enter/hold resettable ones, and > remove the qemu_register_reset() call. Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/timer/etraxfs_timer.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/hw/timer/etraxfs_timer.c b/hw/timer/etraxfs_timer.c > index 5379006086f..4ba662190de 100644 > --- a/hw/timer/etraxfs_timer.c > +++ b/hw/timer/etraxfs_timer.c > @@ -309,9 +309,9 @@ static const MemoryRegionOps timer_ops = { > } > }; > > -static void etraxfs_timer_reset(void *opaque) > +static void etraxfs_timer_reset_enter(Object *obj, ResetType type) > { > - ETRAXTimerState *t = opaque; > + ETRAXTimerState *t = ETRAX_TIMER(obj); > > ptimer_transaction_begin(t->ptimer_t0); > ptimer_stop(t->ptimer_t0); > @@ -325,6 +325,12 @@ static void etraxfs_timer_reset(void *opaque) > t->rw_wd_ctrl = 0; > t->r_intr = 0; > t->rw_intr_mask = 0; > +} > + > +static void etraxfs_timer_reset_hold(Object *obj) > +{ > + ETRAXTimerState *t = ETRAX_TIMER(obj); > + > qemu_irq_lower(t->irq); > } > > @@ -343,14 +349,16 @@ static void etraxfs_timer_realize(DeviceState *dev, Error **errp) > memory_region_init_io(&t->mmio, OBJECT(t), &timer_ops, t, > "etraxfs-timer", 0x5c); > sysbus_init_mmio(sbd, &t->mmio); > - qemu_register_reset(etraxfs_timer_reset, t); > } > > static void etraxfs_timer_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > + ResettableClass *rc = RESETTABLE_CLASS(klass); > > dc->realize = etraxfs_timer_realize; > + rc->phases.enter = etraxfs_timer_reset_enter; > + rc->phases.hold = etraxfs_timer_reset_hold; > } > > static const TypeInfo etraxfs_timer_info = { > -- > 2.26.3 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface) 2021-05-02 16:39 [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2021-05-02 16:39 ` [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) Philippe Mathieu-Daudé @ 2021-05-02 16:39 ` Philippe Mathieu-Daudé 2021-05-03 16:52 ` Edgar E. Iglesias 2021-05-11 3:29 ` [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-02 16:39 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, Philippe Mathieu-Daudé, Laurent Vivier, Edgar E. Iglesias, Paolo Bonzini TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). We have 2 reset() methods: a generic one and the qdev one. Merge them into a reset_enter handler (keeping the IRQ lowering to a reset_hold one), and remove the qemu_register_reset() call. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/rtc/mc146818rtc.c | 42 ++++++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 5d0fcacd0c0..836c3691706 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -872,22 +872,6 @@ static void rtc_notify_suspend(Notifier *notifier, void *data) rtc_set_memory(ISA_DEVICE(s), 0xF, 0xFE); } -static void rtc_reset(void *opaque) -{ - RTCState *s = opaque; - - s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE); - s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | REG_C_AF); - check_update_timer(s); - - qemu_irq_lower(s->irq); - - if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { - s->irq_coalesced = 0; - s->irq_reinject_on_ack_count = 0; - } -} - static const MemoryRegionOps cmos_ops = { .read = cmos_ioport_read, .write = cmos_ioport_write, @@ -962,7 +946,6 @@ static void rtc_realizefn(DeviceState *dev, Error **errp) memory_region_add_coalescing(&s->coalesced_io, 0, 1); qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3); - qemu_register_reset(rtc_reset, s); object_property_add_tm(OBJECT(s), "date", rtc_get_date); @@ -998,15 +981,32 @@ static Property mc146818rtc_properties[] = { DEFINE_PROP_END_OF_LIST(), }; -static void rtc_resetdev(DeviceState *d) +static void rtc_reset_enter(Object *obj, ResetType type) { - RTCState *s = MC146818_RTC(d); + RTCState *s = MC146818_RTC(obj); /* Reason: VM do suspend self will set 0xfe * Reset any values other than 0xfe(Guest suspend case) */ if (s->cmos_data[0x0f] != 0xfe) { s->cmos_data[0x0f] = 0x00; } + + s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE); + s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | REG_C_AF); + check_update_timer(s); + + + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { + s->irq_coalesced = 0; + s->irq_reinject_on_ack_count = 0; + } +} + +static void rtc_reset_hold(Object *obj) +{ + RTCState *s = MC146818_RTC(obj); + + qemu_irq_lower(s->irq); } static void rtc_build_aml(ISADevice *isadev, Aml *scope) @@ -1033,11 +1033,13 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope) static void rtc_class_initfn(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); + ResettableClass *rc = RESETTABLE_CLASS(klass); ISADeviceClass *isa = ISA_DEVICE_CLASS(klass); dc->realize = rtc_realizefn; - dc->reset = rtc_resetdev; dc->vmsd = &vmstate_rtc; + rc->phases.enter = rtc_reset_enter; + rc->phases.hold = rtc_reset_hold; isa->build_aml = rtc_build_aml; device_class_set_props(dc, mc146818rtc_properties); } -- 2.26.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/2] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface) 2021-05-02 16:39 ` [PATCH v3 2/2] hw/rtc/mc146818rtc: " Philippe Mathieu-Daudé @ 2021-05-03 16:52 ` Edgar E. Iglesias 0 siblings, 0 replies; 8+ messages in thread From: Edgar E. Iglesias @ 2021-05-03 16:52 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Paolo Bonzini, Michael S. Tsirkin, Laurent Vivier, qemu-devel, Peter Maydell On Sun, May 02, 2021 at 06:39:31PM +0200, Philippe Mathieu-Daudé wrote: > TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() > handler is called automatically when its qbus parent is reset > (we don't need to register it manually). > > We have 2 reset() methods: a generic one and the qdev one. > Merge them into a reset_enter handler (keeping the IRQ lowering > to a reset_hold one), and remove the qemu_register_reset() call. Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/rtc/mc146818rtc.c | 42 ++++++++++++++++++++++-------------------- > 1 file changed, 22 insertions(+), 20 deletions(-) > > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c > index 5d0fcacd0c0..836c3691706 100644 > --- a/hw/rtc/mc146818rtc.c > +++ b/hw/rtc/mc146818rtc.c > @@ -872,22 +872,6 @@ static void rtc_notify_suspend(Notifier *notifier, void *data) > rtc_set_memory(ISA_DEVICE(s), 0xF, 0xFE); > } > > -static void rtc_reset(void *opaque) > -{ > - RTCState *s = opaque; > - > - s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE); > - s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | REG_C_AF); > - check_update_timer(s); > - > - qemu_irq_lower(s->irq); > - > - if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { > - s->irq_coalesced = 0; > - s->irq_reinject_on_ack_count = 0; > - } > -} > - > static const MemoryRegionOps cmos_ops = { > .read = cmos_ioport_read, > .write = cmos_ioport_write, > @@ -962,7 +946,6 @@ static void rtc_realizefn(DeviceState *dev, Error **errp) > memory_region_add_coalescing(&s->coalesced_io, 0, 1); > > qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3); > - qemu_register_reset(rtc_reset, s); > > object_property_add_tm(OBJECT(s), "date", rtc_get_date); > > @@ -998,15 +981,32 @@ static Property mc146818rtc_properties[] = { > DEFINE_PROP_END_OF_LIST(), > }; > > -static void rtc_resetdev(DeviceState *d) > +static void rtc_reset_enter(Object *obj, ResetType type) > { > - RTCState *s = MC146818_RTC(d); > + RTCState *s = MC146818_RTC(obj); > > /* Reason: VM do suspend self will set 0xfe > * Reset any values other than 0xfe(Guest suspend case) */ > if (s->cmos_data[0x0f] != 0xfe) { > s->cmos_data[0x0f] = 0x00; > } > + > + s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE); > + s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | REG_C_AF); > + check_update_timer(s); > + > + > + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { > + s->irq_coalesced = 0; > + s->irq_reinject_on_ack_count = 0; > + } > +} > + > +static void rtc_reset_hold(Object *obj) > +{ > + RTCState *s = MC146818_RTC(obj); > + > + qemu_irq_lower(s->irq); > } > > static void rtc_build_aml(ISADevice *isadev, Aml *scope) > @@ -1033,11 +1033,13 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope) > static void rtc_class_initfn(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > + ResettableClass *rc = RESETTABLE_CLASS(klass); > ISADeviceClass *isa = ISA_DEVICE_CLASS(klass); > > dc->realize = rtc_realizefn; > - dc->reset = rtc_resetdev; > dc->vmsd = &vmstate_rtc; > + rc->phases.enter = rtc_reset_enter; > + rc->phases.hold = rtc_reset_hold; > isa->build_aml = rtc_build_aml; > device_class_set_props(dc, mc146818rtc_properties); > } > -- > 2.26.3 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface 2021-05-02 16:39 [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2021-05-02 16:39 ` [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) Philippe Mathieu-Daudé 2021-05-02 16:39 ` [PATCH v3 2/2] hw/rtc/mc146818rtc: " Philippe Mathieu-Daudé @ 2021-05-11 3:29 ` Philippe Mathieu-Daudé 2021-05-13 16:03 ` Laurent Vivier 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-11 3:29 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Paolo Bonzini, Edgar E. Iglesias, Laurent Vivier, Michael S. Tsirkin Hi Laurent, I addressed your comments from v1, and this series is now reviewed. Can it get merged via your qemu-trivial tree? On 5/2/21 6:39 PM, Philippe Mathieu-Daudé wrote: > Remove qemu_register_reset() when a qdev type has a qbus parent, > implementing the 3-phase Resettable interface. > > Since v2: > - Lower IRQ in 'hold' phase, not 'exit' one (Edgar) > > Since v1: > - Use 3-phase reset interface instead of qdev one (Laurent) > > Supersedes: <20210423233652.3042941-1-f4bug@amsat.org> > > Philippe Mathieu-Daudé (2): > hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable > interface) > hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface) > > hw/rtc/mc146818rtc.c | 42 +++++++++++++++++++++------------------- > hw/timer/etraxfs_timer.c | 14 +++++++++++--- > 2 files changed, 33 insertions(+), 23 deletions(-) > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface 2021-05-11 3:29 ` [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé @ 2021-05-13 16:03 ` Laurent Vivier 2021-05-13 16:42 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 8+ messages in thread From: Laurent Vivier @ 2021-05-13 16:03 UTC (permalink / raw) To: Philippe Mathieu-Daudé, qemu-devel Cc: qemu-trivial, Peter Maydell, Paolo Bonzini, Edgar E. Iglesias, Michael S. Tsirkin Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > I addressed your comments from v1, and this series is > now reviewed. Can it get merged via your qemu-trivial tree? Yes, but next time cc: trivial to be sure ;) Applied to my trivial-patches branch. Thanks, Laurent > On 5/2/21 6:39 PM, Philippe Mathieu-Daudé wrote: >> Remove qemu_register_reset() when a qdev type has a qbus parent, >> implementing the 3-phase Resettable interface. >> >> Since v2: >> - Lower IRQ in 'hold' phase, not 'exit' one (Edgar) >> >> Since v1: >> - Use 3-phase reset interface instead of qdev one (Laurent) >> >> Supersedes: <20210423233652.3042941-1-f4bug@amsat.org> >> >> Philippe Mathieu-Daudé (2): >> hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable >> interface) >> hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface) >> >> hw/rtc/mc146818rtc.c | 42 +++++++++++++++++++++------------------- >> hw/timer/etraxfs_timer.c | 14 +++++++++++--- >> 2 files changed, 33 insertions(+), 23 deletions(-) >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface 2021-05-13 16:03 ` Laurent Vivier @ 2021-05-13 16:42 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-13 16:42 UTC (permalink / raw) To: Laurent Vivier, qemu-devel Cc: qemu-trivial, Peter Maydell, Michael S. Tsirkin, Edgar E. Iglesias, Paolo Bonzini On 5/13/21 6:03 PM, Laurent Vivier wrote: > Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit : >> Hi Laurent, >> >> I addressed your comments from v1, and this series is >> now reviewed. Can it get merged via your qemu-trivial tree? > > Yes, but next time cc: trivial to be sure ;) OK, thank you :) > > Applied to my trivial-patches branch. > > Thanks, > Laurent ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-13 16:53 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-02 16:39 [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2021-05-02 16:39 ` [PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface) Philippe Mathieu-Daudé 2021-05-03 16:51 ` Edgar E. Iglesias 2021-05-02 16:39 ` [PATCH v3 2/2] hw/rtc/mc146818rtc: " Philippe Mathieu-Daudé 2021-05-03 16:52 ` Edgar E. Iglesias 2021-05-11 3:29 ` [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface Philippe Mathieu-Daudé 2021-05-13 16:03 ` Laurent Vivier 2021-05-13 16:42 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.