[PATCH -perfbook] Fix the description of rcu_gp_ongoing

[PATCH -perfbook] Fix the description of rcu_gp_ongoing

[Zhouyi Zhou]

Hi Paul,

I am going to revise Chinese Edition of Appendix with
Yang Lu's unreserved help.

During the process of reading, I examined the definition of
rcu_gp_ongoing in CodeSamples/defer/rcu_nest.h
Would it better to describe rcu_gp_ongoing in the book as:
'it checks the set of bits indicated by RCU_GP_CTR_NEST_MASK.' because
I think 'it checks the bit indicated by RCU_GP_CTR_BOTTOM_BIT'
is a little confusing.


Thanks alot
Zhouyi Zhou

Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
 appendix/toyrcu/toyrcu.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/appendix/toyrcu/toyrcu.tex b/appendix/toyrcu/toyrcu.tex
index 8fd2aef0..830e4478 100644
--- a/appendix/toyrcu/toyrcu.tex
+++ b/appendix/toyrcu/toyrcu.tex
@@ -1215,7 +1215,7 @@ adds \co{RCU_GP_CTR_BOTTOM_BIT} to the global \co{rcu_gp_ctr}
 instead of adding the constant ``2'',
 and the second is that the comparison on \clnref{ongoing}
 has been abstracted out to a separate function,
-where it checks the bit indicated by \co{RCU_GP_CTR_BOTTOM_BIT}
+where it checks the set of bits indicated by \co{RCU_GP_CTR_NEST_MASK}
 instead of unconditionally checking the low-order bit.
 \end{fcvref}
 
-- 
2.25.1

Re: [PATCH -perfbook] Fix the description of rcu_gp_ongoing

[Paul E. McKenney]

On Mon, May 03, 2021 at 08:15:54PM +0800, Zhouyi Zhou wrote:
> Hi Paul,
> 
> I am going to revise Chinese Edition of Appendix with
> Yang Lu's unreserved help.
> 
> During the process of reading, I examined the definition of
> rcu_gp_ongoing in CodeSamples/defer/rcu_nest.h
> Would it better to describe rcu_gp_ongoing in the book as:
> 'it checks the set of bits indicated by RCU_GP_CTR_NEST_MASK.' because
> I think 'it checks the bit indicated by RCU_GP_CTR_BOTTOM_BIT'
> is a little confusing.

Good eyes, thank you very much!

I just made "bit" be plural, so it now reads "the bits indicated by
RCU_GP_CTR_NEST_MASK".  Queued and pushed, and again, thank you!

							Thanx, Paul

> Thanks alot
> Zhouyi Zhou
> 
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> ---
>  appendix/toyrcu/toyrcu.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/appendix/toyrcu/toyrcu.tex b/appendix/toyrcu/toyrcu.tex
> index 8fd2aef0..830e4478 100644
> --- a/appendix/toyrcu/toyrcu.tex
> +++ b/appendix/toyrcu/toyrcu.tex
> @@ -1215,7 +1215,7 @@ adds \co{RCU_GP_CTR_BOTTOM_BIT} to the global \co{rcu_gp_ctr}
>  instead of adding the constant ``2'',
>  and the second is that the comparison on \clnref{ongoing}
>  has been abstracted out to a separate function,
> -where it checks the bit indicated by \co{RCU_GP_CTR_BOTTOM_BIT}
> +where it checks the set of bits indicated by \co{RCU_GP_CTR_NEST_MASK}
>  instead of unconditionally checking the low-order bit.
>  \end{fcvref}
>  
> -- 
> 2.25.1
> 

Re: [PATCH -perfbook] Fix the description of rcu_gp_ongoing

[Zhouyi Zhou]

Thanks Paul for your encouragement.

Your encouragement has always been my motivation to keep on studying.

Thanks again
Cheers
Zhouyi

On Tue, May 4, 2021 at 12:21 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Mon, May 03, 2021 at 08:15:54PM +0800, Zhouyi Zhou wrote:
> > Hi Paul,
> >
> > I am going to revise Chinese Edition of Appendix with
> > Yang Lu's unreserved help.
> >
> > During the process of reading, I examined the definition of
> > rcu_gp_ongoing in CodeSamples/defer/rcu_nest.h
> > Would it better to describe rcu_gp_ongoing in the book as:
> > 'it checks the set of bits indicated by RCU_GP_CTR_NEST_MASK.' because
> > I think 'it checks the bit indicated by RCU_GP_CTR_BOTTOM_BIT'
> > is a little confusing.
>
> Good eyes, thank you very much!
>
> I just made "bit" be plural, so it now reads "the bits indicated by
> RCU_GP_CTR_NEST_MASK".  Queued and pushed, and again, thank you!
>
>                                                         Thanx, Paul
>
> > Thanks alot
> > Zhouyi Zhou
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > ---
> >  appendix/toyrcu/toyrcu.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/appendix/toyrcu/toyrcu.tex b/appendix/toyrcu/toyrcu.tex
> > index 8fd2aef0..830e4478 100644
> > --- a/appendix/toyrcu/toyrcu.tex
> > +++ b/appendix/toyrcu/toyrcu.tex
> > @@ -1215,7 +1215,7 @@ adds \co{RCU_GP_CTR_BOTTOM_BIT} to the global \co{rcu_gp_ctr}
> >  instead of adding the constant ``2'',
> >  and the second is that the comparison on \clnref{ongoing}
> >  has been abstracted out to a separate function,
> > -where it checks the bit indicated by \co{RCU_GP_CTR_BOTTOM_BIT}
> > +where it checks the set of bits indicated by \co{RCU_GP_CTR_NEST_MASK}
> >  instead of unconditionally checking the low-order bit.
> >  \end{fcvref}
> >
> > --
> > 2.25.1
> >