All of lore.kernel.org
 help / color / mirror / Atom feed
* [hch-block:alloc_disk 28/41] drivers/md/dm-rq.c:563 dm_mq_init_request_queue() error: uninitialized symbol 'q'.
@ 2021-05-03 12:15 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-05-03 10:36 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4341 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Christoph Hellwig <hch@lst.de>

tree:   git://git.infradead.org/users/hch/block.git alloc_disk
head:   60f08b2fdf176410f5dc53a88342cf5e38b61416
commit: 9e728f4a6f7d5579fafafd0f00de7f22e8936ab1 [28/41] blk-mq: improve the blk_mq_init_allocated_queue interface
:::::: branch date: 4 hours ago
:::::: commit date: 4 days ago
config: x86_64-randconfig-m001-20210503 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/md/dm-rq.c:563 dm_mq_init_request_queue() error: uninitialized symbol 'q'.

vim +/q +563 drivers/md/dm-rq.c

4cc96131afce3e Mike Snitzer      2016-05-12  530  
e83068a5faafb8 Mike Snitzer      2016-05-24  531  int dm_mq_init_request_queue(struct mapped_device *md, struct dm_table *t)
4cc96131afce3e Mike Snitzer      2016-05-12  532  {
4cc96131afce3e Mike Snitzer      2016-05-12  533  	struct request_queue *q;
e83068a5faafb8 Mike Snitzer      2016-05-24  534  	struct dm_target *immutable_tgt;
4cc96131afce3e Mike Snitzer      2016-05-12  535  	int err;
4cc96131afce3e Mike Snitzer      2016-05-12  536  
4cc96131afce3e Mike Snitzer      2016-05-12  537  	md->tag_set = kzalloc_node(sizeof(struct blk_mq_tag_set), GFP_KERNEL, md->numa_node_id);
4cc96131afce3e Mike Snitzer      2016-05-12  538  	if (!md->tag_set)
4cc96131afce3e Mike Snitzer      2016-05-12  539  		return -ENOMEM;
4cc96131afce3e Mike Snitzer      2016-05-12  540  
4cc96131afce3e Mike Snitzer      2016-05-12  541  	md->tag_set->ops = &dm_mq_ops;
4cc96131afce3e Mike Snitzer      2016-05-12  542  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
4cc96131afce3e Mike Snitzer      2016-05-12  543  	md->tag_set->numa_node = md->numa_node_id;
bf0beec0607db3 Ming Lei          2020-05-29  544  	md->tag_set->flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_STACKING;
4cc96131afce3e Mike Snitzer      2016-05-12  545  	md->tag_set->nr_hw_queues = dm_get_blk_mq_nr_hw_queues();
4cc96131afce3e Mike Snitzer      2016-05-12  546  	md->tag_set->driver_data = md;
4cc96131afce3e Mike Snitzer      2016-05-12  547  
4cc96131afce3e Mike Snitzer      2016-05-12  548  	md->tag_set->cmd_size = sizeof(struct dm_rq_target_io);
e83068a5faafb8 Mike Snitzer      2016-05-24  549  	immutable_tgt = dm_table_get_immutable_target(t);
4cc96131afce3e Mike Snitzer      2016-05-12  550  	if (immutable_tgt && immutable_tgt->per_io_data_size) {
4cc96131afce3e Mike Snitzer      2016-05-12  551  		/* any target-specific per-io data is immediately after the tio */
4cc96131afce3e Mike Snitzer      2016-05-12  552  		md->tag_set->cmd_size += immutable_tgt->per_io_data_size;
4cc96131afce3e Mike Snitzer      2016-05-12  553  		md->init_tio_pdu = true;
4cc96131afce3e Mike Snitzer      2016-05-12  554  	}
4cc96131afce3e Mike Snitzer      2016-05-12  555  
4cc96131afce3e Mike Snitzer      2016-05-12  556  	err = blk_mq_alloc_tag_set(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  557  	if (err)
4cc96131afce3e Mike Snitzer      2016-05-12  558  		goto out_kfree_tag_set;
4cc96131afce3e Mike Snitzer      2016-05-12  559  
9e728f4a6f7d55 Christoph Hellwig 2021-04-29  560  	err = blk_mq_init_allocated_queue(md->tag_set, md->queue);
9e728f4a6f7d55 Christoph Hellwig 2021-04-29  561  	if (err)
4cc96131afce3e Mike Snitzer      2016-05-12  562  		goto out_tag_set;
9e728f4a6f7d55 Christoph Hellwig 2021-04-29 @563  	elevator_init_mq(q);
4cc96131afce3e Mike Snitzer      2016-05-12  564  	return 0;
4cc96131afce3e Mike Snitzer      2016-05-12  565  
4cc96131afce3e Mike Snitzer      2016-05-12  566  out_tag_set:
4cc96131afce3e Mike Snitzer      2016-05-12  567  	blk_mq_free_tag_set(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  568  out_kfree_tag_set:
4cc96131afce3e Mike Snitzer      2016-05-12  569  	kfree(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  570  
4cc96131afce3e Mike Snitzer      2016-05-12  571  	return err;
4cc96131afce3e Mike Snitzer      2016-05-12  572  }
4cc96131afce3e Mike Snitzer      2016-05-12  573  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29035 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [hch-block:alloc_disk 28/41] drivers/md/dm-rq.c:563 dm_mq_init_request_queue() error: uninitialized symbol 'q'.
@ 2021-05-03 12:15 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-05-03 12:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4237 bytes --]

tree:   git://git.infradead.org/users/hch/block.git alloc_disk
head:   60f08b2fdf176410f5dc53a88342cf5e38b61416
commit: 9e728f4a6f7d5579fafafd0f00de7f22e8936ab1 [28/41] blk-mq: improve the blk_mq_init_allocated_queue interface
config: x86_64-randconfig-m001-20210503 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/md/dm-rq.c:563 dm_mq_init_request_queue() error: uninitialized symbol 'q'.

vim +/q +563 drivers/md/dm-rq.c

e83068a5faafb8 Mike Snitzer      2016-05-24  531  int dm_mq_init_request_queue(struct mapped_device *md, struct dm_table *t)
4cc96131afce3e Mike Snitzer      2016-05-12  532  {
4cc96131afce3e Mike Snitzer      2016-05-12  533  	struct request_queue *q;

"q" is never initialized.

e83068a5faafb8 Mike Snitzer      2016-05-24  534  	struct dm_target *immutable_tgt;
4cc96131afce3e Mike Snitzer      2016-05-12  535  	int err;
4cc96131afce3e Mike Snitzer      2016-05-12  536  
4cc96131afce3e Mike Snitzer      2016-05-12  537  	md->tag_set = kzalloc_node(sizeof(struct blk_mq_tag_set), GFP_KERNEL, md->numa_node_id);
4cc96131afce3e Mike Snitzer      2016-05-12  538  	if (!md->tag_set)
4cc96131afce3e Mike Snitzer      2016-05-12  539  		return -ENOMEM;
4cc96131afce3e Mike Snitzer      2016-05-12  540  
4cc96131afce3e Mike Snitzer      2016-05-12  541  	md->tag_set->ops = &dm_mq_ops;
4cc96131afce3e Mike Snitzer      2016-05-12  542  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
4cc96131afce3e Mike Snitzer      2016-05-12  543  	md->tag_set->numa_node = md->numa_node_id;
bf0beec0607db3 Ming Lei          2020-05-29  544  	md->tag_set->flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_STACKING;
4cc96131afce3e Mike Snitzer      2016-05-12  545  	md->tag_set->nr_hw_queues = dm_get_blk_mq_nr_hw_queues();
4cc96131afce3e Mike Snitzer      2016-05-12  546  	md->tag_set->driver_data = md;
4cc96131afce3e Mike Snitzer      2016-05-12  547  
4cc96131afce3e Mike Snitzer      2016-05-12  548  	md->tag_set->cmd_size = sizeof(struct dm_rq_target_io);
e83068a5faafb8 Mike Snitzer      2016-05-24  549  	immutable_tgt = dm_table_get_immutable_target(t);
4cc96131afce3e Mike Snitzer      2016-05-12  550  	if (immutable_tgt && immutable_tgt->per_io_data_size) {
4cc96131afce3e Mike Snitzer      2016-05-12  551  		/* any target-specific per-io data is immediately after the tio */
4cc96131afce3e Mike Snitzer      2016-05-12  552  		md->tag_set->cmd_size += immutable_tgt->per_io_data_size;
4cc96131afce3e Mike Snitzer      2016-05-12  553  		md->init_tio_pdu = true;
4cc96131afce3e Mike Snitzer      2016-05-12  554  	}
4cc96131afce3e Mike Snitzer      2016-05-12  555  
4cc96131afce3e Mike Snitzer      2016-05-12  556  	err = blk_mq_alloc_tag_set(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  557  	if (err)
4cc96131afce3e Mike Snitzer      2016-05-12  558  		goto out_kfree_tag_set;
4cc96131afce3e Mike Snitzer      2016-05-12  559  
9e728f4a6f7d55 Christoph Hellwig 2021-04-29  560  	err = blk_mq_init_allocated_queue(md->tag_set, md->queue);
9e728f4a6f7d55 Christoph Hellwig 2021-04-29  561  	if (err)
4cc96131afce3e Mike Snitzer      2016-05-12  562  		goto out_tag_set;
9e728f4a6f7d55 Christoph Hellwig 2021-04-29 @563  	elevator_init_mq(q);
                                                                         ^
md->queue was intended?

4cc96131afce3e Mike Snitzer      2016-05-12  564  	return 0;
4cc96131afce3e Mike Snitzer      2016-05-12  565  
4cc96131afce3e Mike Snitzer      2016-05-12  566  out_tag_set:
4cc96131afce3e Mike Snitzer      2016-05-12  567  	blk_mq_free_tag_set(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  568  out_kfree_tag_set:
4cc96131afce3e Mike Snitzer      2016-05-12  569  	kfree(md->tag_set);
4cc96131afce3e Mike Snitzer      2016-05-12  570  
4cc96131afce3e Mike Snitzer      2016-05-12  571  	return err;
4cc96131afce3e Mike Snitzer      2016-05-12  572  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-03 12:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 10:36 [hch-block:alloc_disk 28/41] drivers/md/dm-rq.c:563 dm_mq_init_request_queue() error: uninitialized symbol 'q' kernel test robot
2021-05-03 12:15 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.