From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can <linux-can@vger.kernel.org>,
kayoub5@live.com
Subject: Re: More flags for logging
Date: Tue, 4 May 2021 12:07:46 +0200 [thread overview]
Message-ID: <20210504100746.GB27660@x1.vandijck-laurijssen.be> (raw)
In-Reply-To: <CAMZ6RqLKp981zBus9K1RiLL14zC0B2BGp0U+xuQGvj1fjDMF1g@mail.gmail.com>
On Tue, 04 May 2021 00:02:49 +0900, Vincent MAILHOL wrote:
> On Mon. 3 Mai 2021 at 19:08, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > On 03.05.2021 12:02:46, Marc Kleine-Budde wrote:
> > > ACK bit in data frame
> > > - Some logging hardware can act as a "spy", meaning that it records CAN
> > > Frames, but does not set the ACK bit
> > > - A way to know for a given frame (FD or not), was the ACK bit set or
> > > not.
> > > - Current API allow detecting missing ACK, but it does not report what
> > > Frame had a missing ACK.
> >
> > This means the driver has to set a flag if it's configured in
> > listen-only mode. That should be possible.
>
> For my understanding, when a controller does not see the ACK bit,
> it stops the transmission and sends an error flag. For this
> reason, the frame is not received and thus simply does not appear
> in the log.
I should correct you here.
When the controller does not see the ACK bit, the (transmitting)
controller will just repeat the frame until ...
Kind regards,
Kurt
next prev parent reply other threads:[~2021-05-04 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:02 More flags for logging Marc Kleine-Budde
2021-05-03 10:08 ` Marc Kleine-Budde
2021-05-03 15:02 ` Vincent MAILHOL
2021-05-03 15:43 ` Marc Kleine-Budde
[not found] ` <DBBPR03MB70828377F51A1747B4E9E6529D5B9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-03 15:47 ` Marc Kleine-Budde
[not found] ` <DBBPR03MB7082F029173018680E5D869C9D5B9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-03 21:46 ` Vincent MAILHOL
2021-05-04 5:40 ` Patrick Menschel
2021-05-04 7:48 ` mcp251xfd receiving non ACKed frames (was: Re: More flags for logging) Marc Kleine-Budde
2021-05-04 12:22 ` Vincent MAILHOL
2021-05-04 12:53 ` Thomas.Kopp
2021-05-04 14:26 ` Vincent MAILHOL
2021-05-04 17:44 ` Vincent MAILHOL
2021-05-04 10:10 ` More flags for logging Kurt Van Dijck
2021-05-04 10:07 ` Kurt Van Dijck [this message]
2021-05-04 8:49 ` Oliver Hartkopp
[not found] ` <DBBPR03MB7082C7E8FD22D0CA8C2DA99D9D5A9@DBBPR03MB7082.eurprd03.prod.outlook.com>
[not found] ` <AM8PR08MB5698886555F8531B6CF65982B75A9@AM8PR08MB5698.eurprd08.prod.outlook.com>
2021-05-04 9:49 ` Ayoub Kaanich
2021-05-04 10:13 ` Oliver Hartkopp
2021-05-04 13:58 ` Ayoub Kaanich
2021-05-04 14:38 ` Oliver Hartkopp
[not found] ` <DBBPR03MB70824BB82F7BB335928BE36A9D2F9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-17 7:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504100746.GB27660@x1.vandijck-laurijssen.be \
--to=dev.kurt@vandijck-laurijssen.be \
--cc=kayoub5@live.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.