From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Ayoub Kaanich <kayoub5@live.com>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
linux-can <linux-can@vger.kernel.org>
Subject: Re: More flags for logging
Date: Tue, 4 May 2021 12:10:26 +0200 [thread overview]
Message-ID: <20210504101026.GC27660@x1.vandijck-laurijssen.be> (raw)
In-Reply-To: <20210503154749.q3nrfjveixsqp3uj@pengutronix.de>
On Mon, 03 May 2021 17:47:49 +0200, Marc Kleine-Budde wrote:
> On 03.05.2021 15:31:34, Ayoub Kaanich wrote:
> > For the ack bit, I think we could go with the bit being a “NO_ACK”
> > bit, so a spy listener will set it to 1, if it receives a CAN frame,
> > but it does not see any node in the bus acknowledging it. This way we
> > preserve backward compatibility.
>
> As Vincent pointed out, the device should not receive the CAN frame that
> has not been acked as I do on the flexcan.
>
> And even on the mcp251xfd, where I receive the CAN frame, there's no way
> to tell if this frame has been acked or not.
in listen-only mode, it's debatable if you should see an ack.
If there's only 1 active node on the bus, you would not be able to probe
the bitrate using listen-only mode, unless you accept CAN frames that
are only miss the ACK bit.
Kurt
next prev parent reply other threads:[~2021-05-04 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:02 More flags for logging Marc Kleine-Budde
2021-05-03 10:08 ` Marc Kleine-Budde
2021-05-03 15:02 ` Vincent MAILHOL
2021-05-03 15:43 ` Marc Kleine-Budde
[not found] ` <DBBPR03MB70828377F51A1747B4E9E6529D5B9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-03 15:47 ` Marc Kleine-Budde
[not found] ` <DBBPR03MB7082F029173018680E5D869C9D5B9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-03 21:46 ` Vincent MAILHOL
2021-05-04 5:40 ` Patrick Menschel
2021-05-04 7:48 ` mcp251xfd receiving non ACKed frames (was: Re: More flags for logging) Marc Kleine-Budde
2021-05-04 12:22 ` Vincent MAILHOL
2021-05-04 12:53 ` Thomas.Kopp
2021-05-04 14:26 ` Vincent MAILHOL
2021-05-04 17:44 ` Vincent MAILHOL
2021-05-04 10:10 ` Kurt Van Dijck [this message]
2021-05-04 10:07 ` More flags for logging Kurt Van Dijck
2021-05-04 8:49 ` Oliver Hartkopp
[not found] ` <DBBPR03MB7082C7E8FD22D0CA8C2DA99D9D5A9@DBBPR03MB7082.eurprd03.prod.outlook.com>
[not found] ` <AM8PR08MB5698886555F8531B6CF65982B75A9@AM8PR08MB5698.eurprd08.prod.outlook.com>
2021-05-04 9:49 ` Ayoub Kaanich
2021-05-04 10:13 ` Oliver Hartkopp
2021-05-04 13:58 ` Ayoub Kaanich
2021-05-04 14:38 ` Oliver Hartkopp
[not found] ` <DBBPR03MB70824BB82F7BB335928BE36A9D2F9@DBBPR03MB7082.eurprd03.prod.outlook.com>
2021-05-17 7:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504101026.GC27660@x1.vandijck-laurijssen.be \
--to=dev.kurt@vandijck-laurijssen.be \
--cc=kayoub5@live.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.