All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-freescale-3rdparty] [PATCH] colibri*.conf: define UBOOT_IMAGE
@ 2021-05-04 12:24 Ming Liu
  2021-05-05  2:33 ` [meta-freescale] " Otavio Salvador
  0 siblings, 1 reply; 2+ messages in thread
From: Ming Liu @ 2021-05-04 12:24 UTC (permalink / raw)
  To: meta-freescale; +Cc: max.krummenacher, sergio.prado, Ming Liu

From: Ming Liu <liu.ming50@gmail.com>

We have renamed UBOOT_BINARY with '-nand' suffix to indicate it's a
image that should be flashed to NAND device, do the same to
UBOOT_IMAGE, otherwise developers might get confused about how to deal
with it.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 conf/machine/colibri-imx6ull.conf   | 1 +
 conf/machine/colibri-imx7-nand.conf | 1 +
 conf/machine/colibri-vf.conf        | 1 +
 3 files changed, 3 insertions(+)

diff --git a/conf/machine/colibri-imx6ull.conf b/conf/machine/colibri-imx6ull.conf
index 1e1fd93..896fa1c 100644
--- a/conf/machine/colibri-imx6ull.conf
+++ b/conf/machine/colibri-imx6ull.conf
@@ -22,6 +22,7 @@ PREFERRED_RPROVIDER_u-boot-fw-utils ?= "u-boot-toradex-fw-utils"
 PREFERRED_PROVIDER_u-boot-default-script ?= "u-boot-script-toradex"
 
 UBOOT_BINARY = "u-boot-nand.imx"
+UBOOT_IMAGE = "u-boot-nand-${MACHINE}-${PV}-${PR}.${UBOOT_SUFFIX}"
 UBOOT_MAKE_TARGET = "u-boot.imx"
 UBOOT_MACHINE ?= "colibri-imx6ull_defconfig"
 
diff --git a/conf/machine/colibri-imx7-nand.conf b/conf/machine/colibri-imx7-nand.conf
index 4ab7a95..03794c9 100644
--- a/conf/machine/colibri-imx7-nand.conf
+++ b/conf/machine/colibri-imx7-nand.conf
@@ -35,6 +35,7 @@ PREFERRED_PROVIDER_u-boot-default-script ?= "u-boot-script-toradex"
 
 # U-Boot NAND binary includes 0x400 padding required for NAND boot
 UBOOT_BINARY = "u-boot-nand.imx"
+UBOOT_IMAGE = "u-boot-nand-${MACHINE}-${PV}-${PR}.${UBOOT_SUFFIX}"
 UBOOT_MAKE_TARGET = "u-boot.imx"
 UBOOT_MACHINE ?= "colibri_imx7_defconfig"
 
diff --git a/conf/machine/colibri-vf.conf b/conf/machine/colibri-vf.conf
index 8c66ced..7e00e89 100644
--- a/conf/machine/colibri-vf.conf
+++ b/conf/machine/colibri-vf.conf
@@ -39,6 +39,7 @@ PREFERRED_VERSION_weston_use-nxp-bsp = ""
 
 # U-Boot NAND binary includes 0x400 padding required for NAND boot
 UBOOT_BINARY = "u-boot-nand.imx"
+UBOOT_IMAGE = "u-boot-nand-${MACHINE}-${PV}-${PR}.${UBOOT_SUFFIX}"
 UBOOT_MAKE_TARGET = "u-boot.imx"
 UBOOT_MACHINE ?= "colibri_vf_defconfig"
 
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-freescale] [meta-freescale-3rdparty] [PATCH] colibri*.conf: define UBOOT_IMAGE
  2021-05-04 12:24 [meta-freescale-3rdparty] [PATCH] colibri*.conf: define UBOOT_IMAGE Ming Liu
@ 2021-05-05  2:33 ` Otavio Salvador
  0 siblings, 0 replies; 2+ messages in thread
From: Otavio Salvador @ 2021-05-05  2:33 UTC (permalink / raw)
  To: Ming Liu; +Cc: meta-freescale Mailing List, Max Krummenacher, Sergio Prado

Em ter., 4 de mai. de 2021 às 09:24, Ming Liu <liu.ming50@gmail.com> escreveu:
>
> From: Ming Liu <liu.ming50@gmail.com>
>
> We have renamed UBOOT_BINARY with '-nand' suffix to indicate it's a
> image that should be flashed to NAND device, do the same to
> UBOOT_IMAGE, otherwise developers might get confused about how to deal
> with it.
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>

Please use the GitHub for this PR. Also, please include a background
why this change is required. Up to now, it seems to be going on the
wrong direction.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-05  2:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 12:24 [meta-freescale-3rdparty] [PATCH] colibri*.conf: define UBOOT_IMAGE Ming Liu
2021-05-05  2:33 ` [meta-freescale] " Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.