* [PATCH] ceph: remove bogus check for NULL mapping in ceph_set_page_dirty
@ 2021-05-04 14:53 Jeff Layton
0 siblings, 0 replies; only message in thread
From: Jeff Layton @ 2021-05-04 14:53 UTC (permalink / raw)
To: ceph-devel, idryomov; +Cc: Matthew Wilcox
This check is odd, as set_page_dirty is an address_space operation, and
I don't see where it would be called on a non-pagecache page.
Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/ceph/addr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b47303b3772a..01316cb1314c 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -84,9 +84,6 @@ static int ceph_set_page_dirty(struct page *page)
struct ceph_snap_context *snapc;
int ret;
- if (unlikely(!mapping))
- return !TestSetPageDirty(page);
-
if (PageDirty(page)) {
dout("%p set_page_dirty %p idx %lu -- already dirty\n",
mapping->host, page, page->index);
--
2.31.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-04 14:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 14:53 [PATCH] ceph: remove bogus check for NULL mapping in ceph_set_page_dirty Jeff Layton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.