Re: [PATCH v2 12/14] seq_file: Replace seq_escape() with inliner

From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"J. Bruce Fields" <bfields@redhat.com>,
	linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Chuck Lever <chuck.lever@oracle.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH v2 12/14] seq_file: Replace seq_escape() with inliner
Date: Tue, 4 May 2021 20:41:49 +0800	[thread overview]
Message-ID: <202105042053.HZmzqZrh-lkp@intel.com> (raw)
In-Reply-To: <20210504102648.88057-13-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2955 bytes --]

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master nfsd/nfsd-next v5.12 next-20210504]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/lib-string_helpers-get-rid-of-ugly-_escape_mem_ascii/20210504-182828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1fe5501ba1abf2b7e78295df73675423bd6899a0
config: sparc-randconfig-p002-20210504 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/047508aa8c09cb58cf304e9025283021731b3921
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/lib-string_helpers-get-rid-of-ugly-_escape_mem_ascii/20210504-182828
        git checkout 047508aa8c09cb58cf304e9025283021731b3921
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/atm/iphase.c:67:
>> drivers/atm/iphase.h:127: warning: "isprint" redefined
     127 | #define isprint(a) ((a >=' ')&&(a <= '~'))
         | 
   In file included from include/linux/string_helpers.h:6,
                    from include/linux/seq_file.h:7,
                    from include/linux/seq_file_net.h:5,
                    from include/net/net_namespace.h:188,
                    from include/linux/netdevice.h:37,
                    from include/net/sock.h:46,
                    from include/linux/atmdev.h:13,
                    from drivers/atm/iphase.c:49:
   include/linux/ctype.h:30: note: this is the location of the previous definition
      30 | #define isprint(c) ((__ismask(c)&(_P|_U|_L|_D|_SP)) != 0)
         | 

vim +/isprint +127 drivers/atm/iphase.h

^1da177e4c3f41 Linus Torvalds 2005-04-16  126  
^1da177e4c3f41 Linus Torvalds 2005-04-16 @127  #define isprint(a) ((a >=' ')&&(a <= '~'))  
^1da177e4c3f41 Linus Torvalds 2005-04-16  128  #define ATM_DESC(skb) (skb->protocol)
^1da177e4c3f41 Linus Torvalds 2005-04-16  129  #define IA_SKB_STATE(skb) (skb->protocol)
^1da177e4c3f41 Linus Torvalds 2005-04-16  130  #define IA_DLED   1
^1da177e4c3f41 Linus Torvalds 2005-04-16  131  #define IA_TX_DONE 2
^1da177e4c3f41 Linus Torvalds 2005-04-16  132  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29234 bytes --]