* [PATCH] ipv6: netfilter.c: fix missing line after declaration
@ 2021-05-05 19:20 Pallavi Prabhu
2021-05-05 22:41 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Pallavi Prabhu @ 2021-05-05 19:20 UTC (permalink / raw)
To: pablo, kadlec, fw, davem, yoshfuji, dsahern, kuba,
netfilter-devel, coreteam, netdev, linux-kernel
Fixed a missing line after a declaration for proper coding style.
Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com>
---
net/ipv6/netfilter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index ab9a279dd6d4..7b1671f48593 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
if (entry->state.hook == NF_INET_LOCAL_OUT) {
const struct ipv6hdr *iph = ipv6_hdr(skb);
+
if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
!ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
skb->mark != rt_info->mark)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: netfilter.c: fix missing line after declaration
2021-05-05 19:20 [PATCH] ipv6: netfilter.c: fix missing line after declaration Pallavi Prabhu
@ 2021-05-05 22:41 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2021-05-05 22:41 UTC (permalink / raw)
To: Pallavi Prabhu
Cc: kadlec, fw, davem, yoshfuji, dsahern, kuba, netfilter-devel,
coreteam, netdev, linux-kernel
Hi Pallavi,
On Thu, May 06, 2021 at 12:50:07AM +0530, Pallavi Prabhu wrote:
> Fixed a missing line after a declaration for proper coding style.
I'd probably suggest to use Coccinelle or similar to make a Netfilter
tree wide patch to add line after a declaration.
Probably there are more spots in the Netfilter codebase that can
benefit from this cleanup.
> Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com>
> ---
> net/ipv6/netfilter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
> index ab9a279dd6d4..7b1671f48593 100644
> --- a/net/ipv6/netfilter.c
> +++ b/net/ipv6/netfilter.c
> @@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
>
> if (entry->state.hook == NF_INET_LOCAL_OUT) {
> const struct ipv6hdr *iph = ipv6_hdr(skb);
> +
> if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
> !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
> skb->mark != rt_info->mark)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-05 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 19:20 [PATCH] ipv6: netfilter.c: fix missing line after declaration Pallavi Prabhu
2021-05-05 22:41 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.