From: Bjorn Helgaas <helgaas@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: bhelgaas@google.com, linus.walleij@linaro.org,
robh+dt@kernel.org, ulli.kroll@googlemail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml
Date: Thu, 6 May 2021 15:34:35 -0500 [thread overview]
Message-ID: <20210506203435.GA1432800@bjorn-Precision-5520> (raw)
In-Reply-To: <20210503185228.1518131-1-clabbe@baylibre.com>
On Mon, May 03, 2021 at 06:52:27PM +0000, Corentin Labbe wrote:
> Converts pci/faraday,ftpci100.txt to yaml.
> Some change are also made:
> - example has wrong interrupts place
I think it's nicer when content changes are in a separate patch from
format conversion patches. Otherwise it's really hard to see the
content changes in the patch.
Maybe a preliminary patch could fix whatever is actually broken?
Rob suggested a bunch of things that could be dropped. Maybe those
could be removed in a second preliminary patch before the conversion?
Or maybe the removals are only possible *because* of the conversion?
I'm not a yaml expert.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: bhelgaas@google.com, linus.walleij@linaro.org,
robh+dt@kernel.org, ulli.kroll@googlemail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml
Date: Thu, 6 May 2021 15:34:35 -0500 [thread overview]
Message-ID: <20210506203435.GA1432800@bjorn-Precision-5520> (raw)
In-Reply-To: <20210503185228.1518131-1-clabbe@baylibre.com>
On Mon, May 03, 2021 at 06:52:27PM +0000, Corentin Labbe wrote:
> Converts pci/faraday,ftpci100.txt to yaml.
> Some change are also made:
> - example has wrong interrupts place
I think it's nicer when content changes are in a separate patch from
format conversion patches. Otherwise it's really hard to see the
content changes in the patch.
Maybe a preliminary patch could fix whatever is actually broken?
Rob suggested a bunch of things that could be dropped. Maybe those
could be removed in a second preliminary patch before the conversion?
Or maybe the removals are only possible *because* of the conversion?
I'm not a yaml expert.
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-06 20:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 18:52 [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml Corentin Labbe
2021-05-03 18:52 ` Corentin Labbe
2021-05-03 18:52 ` [PATCH 2/2] ARM: dts: gemini: add device_type on pci Corentin Labbe
2021-05-03 18:52 ` Corentin Labbe
2021-05-06 10:34 ` Linus Walleij
2021-05-06 10:34 ` Linus Walleij
2021-05-06 10:32 ` [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml Linus Walleij
2021-05-06 10:32 ` Linus Walleij
2021-05-06 17:43 ` Rob Herring
2021-05-06 17:43 ` Rob Herring
2021-05-06 20:34 ` Bjorn Helgaas [this message]
2021-05-06 20:34 ` Bjorn Helgaas
2021-05-07 10:51 ` Linus Walleij
2021-05-07 10:51 ` Linus Walleij
2021-05-10 18:35 ` Bjorn Helgaas
2021-05-10 18:35 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506203435.GA1432800@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.