From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Ikjoon Jang <ikjn@chromium.org>,
Eddie Hung <eddie.hung@mediatek.com>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc
Date: Fri, 7 May 2021 10:11:25 +0800 [thread overview]
Message-ID: <20210507021127.54717-2-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>
Due to @has_ippc's default value is 0, no need set it again if fail
to get ippc base address
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: new patch suggested by Greg
fix typo suggested by Sergei
---
drivers/usb/host/xhci-mtk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b2058b3bc834..2548976bcf05 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto put_usb2_hcd;
}
mtk->has_ippc = true;
- } else {
- mtk->has_ippc = false;
}
device_init_wakeup(dev, true);
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Ikjoon Jang" <ikjn@chromium.org>,
Eddie Hung <eddie.hung@mediatek.com>,
"Sergei Shtylyov" <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc
Date: Fri, 7 May 2021 10:11:25 +0800 [thread overview]
Message-ID: <20210507021127.54717-2-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>
Due to @has_ippc's default value is 0, no need set it again if fail
to get ippc base address
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: new patch suggested by Greg
fix typo suggested by Sergei
---
drivers/usb/host/xhci-mtk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b2058b3bc834..2548976bcf05 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto put_usb2_hcd;
}
mtk->has_ippc = true;
- } else {
- mtk->has_ippc = false;
}
device_init_wakeup(dev, true);
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Ikjoon Jang" <ikjn@chromium.org>,
Eddie Hung <eddie.hung@mediatek.com>,
"Sergei Shtylyov" <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc
Date: Fri, 7 May 2021 10:11:25 +0800 [thread overview]
Message-ID: <20210507021127.54717-2-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>
Due to @has_ippc's default value is 0, no need set it again if fail
to get ippc base address
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: new patch suggested by Greg
fix typo suggested by Sergei
---
drivers/usb/host/xhci-mtk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b2058b3bc834..2548976bcf05 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto put_usb2_hcd;
}
mtk->has_ippc = true;
- } else {
- mtk->has_ippc = false;
}
device_init_wakeup(dev, true);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-07 2:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 2:11 [PATCH v3 1/4] usb: xhci-mtk: use bitfield instead of bool Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun [this message]
2021-05-07 2:11 ` [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-06-10 3:32 ` Ikjoon Jang
2021-06-10 3:32 ` Ikjoon Jang
2021-06-10 3:32 ` Ikjoon Jang
2021-05-07 2:11 ` [PATCH v3 3/4] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-05-07 2:11 ` [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-05-07 2:11 ` Chunfeng Yun
2021-06-10 3:40 ` Ikjoon Jang
2021-06-10 3:40 ` Ikjoon Jang
2021-06-10 3:40 ` Ikjoon Jang
2021-06-10 3:31 ` [PATCH v3 1/4] usb: xhci-mtk: use bitfield instead of bool Ikjoon Jang
2021-06-10 3:31 ` Ikjoon Jang
2021-06-10 3:31 ` Ikjoon Jang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507021127.54717-2-chunfeng.yun@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.