All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/page_alloc: __alloc_pages_bulk(): do bounds check before accessing array
@ 2021-05-07  6:45 Rasmus Villemoes
  2021-05-07 10:26 ` Mel Gorman
  0 siblings, 1 reply; 4+ messages in thread
From: Rasmus Villemoes @ 2021-05-07  6:45 UTC (permalink / raw)
  To: Andrew Morton, Alexander Lobakin, Mel Gorman, Vlastimil Babka
  Cc: Rasmus Villemoes, linux-mm, linux-kernel

In the event that somebody would call this with an already fully
populated page_array, the last loop iteration would do an access
beyond the end of page_array.

It's of course extremely unlikely that would ever be done, but this
triggers my internal static analyzer. Also, if it really is not
supposed to be invoked this way (i.e., with no NULL entries in
page_array), the nr_populated<nr_pages check could simply be removed
instead.

Fixes: 0f87d9d30f21 (mm/page_alloc: add an array-based interface to the bulk page allocator)
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index bcdc0c6f21f1..66785946eb28 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5053,7 +5053,7 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid,
 	 * Skip populated array elements to determine if any pages need
 	 * to be allocated before disabling IRQs.
 	 */
-	while (page_array && page_array[nr_populated] && nr_populated < nr_pages)
+	while (page_array && nr_populated < nr_pages && page_array[nr_populated])
 		nr_populated++;
 
 	/* Use the single page allocator for one page. */
-- 
2.29.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-23  4:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07  6:45 [PATCH] mm/page_alloc: __alloc_pages_bulk(): do bounds check before accessing array Rasmus Villemoes
2021-05-07 10:26 ` Mel Gorman
2021-06-21 16:01   ` Rasmus Villemoes
2021-06-23  4:49     ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.