All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kselftest/arm64: Add missing stddef.h include to BTI tests
@ 2021-05-07 16:25 ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-05-07 16:25 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Shuah Khan
  Cc: linux-arm-kernel, linux-kselftest, Mark Brown

Explicitly include stddef.h when building the BTI tests so that we have
a definition of NULL, with at least some toolchains this is not done
implicitly by anything else:

test.c: In function ‘start’:
test.c:214:25: error: ‘NULL’ undeclared (first use in this function)
  214 |  sigaction(SIGILL, &sa, NULL);
      |                         ^~~~
test.c:20:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/arm64/bti/test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/arm64/bti/test.c b/tools/testing/selftests/arm64/bti/test.c
index 656b04976ccc..67b77ab83c20 100644
--- a/tools/testing/selftests/arm64/bti/test.c
+++ b/tools/testing/selftests/arm64/bti/test.c
@@ -6,6 +6,7 @@
 
 #include "system.h"
 
+#include <stddef.h>
 #include <linux/errno.h>
 #include <linux/auxvec.h>
 #include <linux/signal.h>
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] kselftest/arm64: Add missing stddef.h include to BTI tests
@ 2021-05-07 16:25 ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-05-07 16:25 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Shuah Khan
  Cc: linux-arm-kernel, linux-kselftest, Mark Brown

Explicitly include stddef.h when building the BTI tests so that we have
a definition of NULL, with at least some toolchains this is not done
implicitly by anything else:

test.c: In function ‘start’:
test.c:214:25: error: ‘NULL’ undeclared (first use in this function)
  214 |  sigaction(SIGILL, &sa, NULL);
      |                         ^~~~
test.c:20:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/arm64/bti/test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/arm64/bti/test.c b/tools/testing/selftests/arm64/bti/test.c
index 656b04976ccc..67b77ab83c20 100644
--- a/tools/testing/selftests/arm64/bti/test.c
+++ b/tools/testing/selftests/arm64/bti/test.c
@@ -6,6 +6,7 @@
 
 #include "system.h"
 
+#include <stddef.h>
 #include <linux/errno.h>
 #include <linux/auxvec.h>
 #include <linux/signal.h>
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] kselftest/arm64: Add missing stddef.h include to BTI tests
  2021-05-07 16:25 ` Mark Brown
@ 2021-05-10 12:56   ` Catalin Marinas
  -1 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-05-10 12:56 UTC (permalink / raw)
  To: Will Deacon, Shuah Khan, Mark Brown; +Cc: linux-kselftest, linux-arm-kernel

On Fri, 7 May 2021 17:25:42 +0100, Mark Brown wrote:
> Explicitly include stddef.h when building the BTI tests so that we have
> a definition of NULL, with at least some toolchains this is not done
> implicitly by anything else:
> 
> test.c: In function ‘start’:
> test.c:214:25: error: ‘NULL’ undeclared (first use in this function)
>   214 |  sigaction(SIGILL, &sa, NULL);
>       |                         ^~~~
> test.c:20:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?

Applied to arm64 (for-next/fixes), thanks!

[1/1] kselftest/arm64: Add missing stddef.h include to BTI tests
      https://git.kernel.org/arm64/c/a1bed090fc56

-- 
Catalin


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kselftest/arm64: Add missing stddef.h include to BTI tests
@ 2021-05-10 12:56   ` Catalin Marinas
  0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-05-10 12:56 UTC (permalink / raw)
  To: Will Deacon, Shuah Khan, Mark Brown; +Cc: linux-kselftest, linux-arm-kernel

On Fri, 7 May 2021 17:25:42 +0100, Mark Brown wrote:
> Explicitly include stddef.h when building the BTI tests so that we have
> a definition of NULL, with at least some toolchains this is not done
> implicitly by anything else:
> 
> test.c: In function ‘start’:
> test.c:214:25: error: ‘NULL’ undeclared (first use in this function)
>   214 |  sigaction(SIGILL, &sa, NULL);
>       |                         ^~~~
> test.c:20:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?

Applied to arm64 (for-next/fixes), thanks!

[1/1] kselftest/arm64: Add missing stddef.h include to BTI tests
      https://git.kernel.org/arm64/c/a1bed090fc56

-- 
Catalin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-10 13:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 16:25 [PATCH] kselftest/arm64: Add missing stddef.h include to BTI tests Mark Brown
2021-05-07 16:25 ` Mark Brown
2021-05-10 12:56 ` Catalin Marinas
2021-05-10 12:56   ` Catalin Marinas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.