* [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe()
@ 2021-05-08 2:03 Zhen Lei
2021-05-11 10:56 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-08 2:03 UTC (permalink / raw)
To: Jesper Nilsson, Lars Persson, Ulf Hansson, Guennadi Liakhovetski,
Chris Ball, linux-arm-kernel, linux-mmc, linux-kernel
Cc: Zhen Lei
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.
Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/mmc/host/usdhi6rol0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
index 615f3d008af1..b9b79b1089a0 100644
--- a/drivers/mmc/host/usdhi6rol0.c
+++ b/drivers/mmc/host/usdhi6rol0.c
@@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev)
version = usdhi6_read(host, USDHI6_VERSION);
if ((version & 0xfff) != 0xa0d) {
+ ret = -EPERM;
dev_err(dev, "Version not recognized %x\n", version);
goto e_clk_off;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe()
2021-05-08 2:03 [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Zhen Lei
@ 2021-05-11 10:56 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-05-11 10:56 UTC (permalink / raw)
To: Zhen Lei
Cc: Jesper Nilsson, Lars Persson, Guennadi Liakhovetski, Chris Ball,
linux-arm-kernel, linux-mmc, linux-kernel
On Sat, 8 May 2021 at 04:04, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/usdhi6rol0.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
> index 615f3d008af1..b9b79b1089a0 100644
> --- a/drivers/mmc/host/usdhi6rol0.c
> +++ b/drivers/mmc/host/usdhi6rol0.c
> @@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev)
>
> version = usdhi6_read(host, USDHI6_VERSION);
> if ((version & 0xfff) != 0xa0d) {
> + ret = -EPERM;
> dev_err(dev, "Version not recognized %x\n", version);
> goto e_clk_off;
> }
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-11 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 2:03 [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Zhen Lei
2021-05-11 10:56 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.