* [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE
@ 2021-05-08 3:15 Bixuan Cui
2021-05-11 11:31 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Bixuan Cui @ 2021-05-08 3:15 UTC (permalink / raw)
To: cuibixuan, Tero Kristo, Borislav Petkov, Mauro Carvalho Chehab,
Tony Luck
Cc: linux-edac, kernel-janitors
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/edac/ti_edac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
index e7eae20f83d1..169f96e51c29 100644
--- a/drivers/edac/ti_edac.c
+++ b/drivers/edac/ti_edac.c
@@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = {
{ .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 },
{},
};
+MODULE_DEVICE_TABLE(of, ti_edac_of_match);
static int _emif_get_id(struct device_node *node)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE
2021-05-08 3:15 [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
@ 2021-05-11 11:31 ` Borislav Petkov
2021-05-11 13:51 ` Bixuan Cui
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-05-11 11:31 UTC (permalink / raw)
To: Bixuan Cui
Cc: Tero Kristo, Mauro Carvalho Chehab, Tony Luck, linux-edac,
kernel-janitors
On Sat, May 08, 2021 at 11:15:06AM +0800, Bixuan Cui wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> correct modalias for automatic loading of this driver when it is built
> as an external module.
"external" or simply a module?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE
2021-05-11 11:31 ` Borislav Petkov
@ 2021-05-11 13:51 ` Bixuan Cui
0 siblings, 0 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-05-11 13:51 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tero Kristo, Mauro Carvalho Chehab, Tony Luck, linux-edac,
kernel-janitors
On 2021/5/11 19:31, Borislav Petkov wrote:
> On Sat, May 08, 2021 at 11:15:06AM +0800, Bixuan Cui wrote:
>> This patch adds missing MODULE_DEVICE_TABLE definition which generates
>
> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
>
> Also, do
>
> $ git grep 'This patch' Documentation/process
>
> for more details.
>
>> correct modalias for automatic loading of this driver when it is built
>> as an external module.
>
> "external" or simply a module?
I will modify the commit message, thanks.
Bixuan Cui
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-11 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 3:15 [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-05-11 11:31 ` Borislav Petkov
2021-05-11 13:51 ` Bixuan Cui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.