* [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-08 18:19 ` Rouven Czerwinski
0 siblings, 0 replies; 12+ messages in thread
From: Rouven Czerwinski @ 2021-05-08 18:19 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter
Cc: kernel, Rouven Czerwinski, Rouven Czerwinski, amd-gfx, dri-devel,
linux-kernel
This function is not used anywhere, remove it. It was added in
40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
functions from dc to dc_link"), but a user is missing.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 3fb0cebd6938..55c5cf2264b3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
}
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern)
-{
- int i;
-
- for (i = 0; i < dc->link_count; i++)
- dc_link_dp_perform_link_training(
- dc->links[i],
- link_setting,
- skip_video_pattern);
-}
-
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
index fc5622ffec3d..45c927cd27ab 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_link.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
@@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
void dc_link_set_drive_settings(struct dc *dc,
struct link_training_settings *lt_settings,
const struct dc_link *link);
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern);
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link);
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-08 18:19 ` Rouven Czerwinski
0 siblings, 0 replies; 12+ messages in thread
From: Rouven Czerwinski @ 2021-05-08 18:19 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter
Cc: Rouven Czerwinski, linux-kernel, dri-devel, Rouven Czerwinski,
amd-gfx, kernel
This function is not used anywhere, remove it. It was added in
40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
functions from dc to dc_link"), but a user is missing.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 3fb0cebd6938..55c5cf2264b3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
}
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern)
-{
- int i;
-
- for (i = 0; i < dc->link_count; i++)
- dc_link_dp_perform_link_training(
- dc->links[i],
- link_setting,
- skip_video_pattern);
-}
-
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
index fc5622ffec3d..45c927cd27ab 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_link.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
@@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
void dc_link_set_drive_settings(struct dc *dc,
struct link_training_settings *lt_settings,
const struct dc_link *link);
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern);
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link);
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-08 18:19 ` Rouven Czerwinski
0 siblings, 0 replies; 12+ messages in thread
From: Rouven Czerwinski @ 2021-05-08 18:19 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter
Cc: Rouven Czerwinski, linux-kernel, dri-devel, Rouven Czerwinski,
amd-gfx, kernel
This function is not used anywhere, remove it. It was added in
40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
functions from dc to dc_link"), but a user is missing.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 3fb0cebd6938..55c5cf2264b3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
}
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern)
-{
- int i;
-
- for (i = 0; i < dc->link_count; i++)
- dc_link_dp_perform_link_training(
- dc->links[i],
- link_setting,
- skip_video_pattern);
-}
-
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
index fc5622ffec3d..45c927cd27ab 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_link.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
@@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
void dc_link_set_drive_settings(struct dc *dc,
struct link_training_settings *lt_settings,
const struct dc_link *link);
-void dc_link_perform_link_training(struct dc *dc,
- struct dc_link_settings *link_setting,
- bool skip_video_pattern);
void dc_link_set_preferred_link_settings(struct dc *dc,
struct dc_link_settings *link_setting,
struct dc_link *link);
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
2021-05-08 18:19 ` Rouven Czerwinski
(?)
@ 2021-05-10 20:53 ` Alex Deucher
-1 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2021-05-10 20:53 UTC (permalink / raw)
To: Rouven Czerwinski
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rouven Czerwinski, LKML,
Maling list - DRI developers, amd-gfx list, Sascha Hauer
Applied. Thanks!
Alex
On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski <rouven@czerwinskis.de> wrote:
>
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 20:53 ` Alex Deucher
0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2021-05-10 20:53 UTC (permalink / raw)
To: Rouven Czerwinski
Cc: Rouven Czerwinski, Sascha Hauer, Leo Li, LKML,
Maling list - DRI developers, David Airlie, amd-gfx list,
Alex Deucher, Christian König
Applied. Thanks!
Alex
On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski <rouven@czerwinskis.de> wrote:
>
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 20:53 ` Alex Deucher
0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2021-05-10 20:53 UTC (permalink / raw)
To: Rouven Czerwinski
Cc: Rouven Czerwinski, Sascha Hauer, Leo Li, LKML,
Maling list - DRI developers, David Airlie, amd-gfx list,
Daniel Vetter, Alex Deucher, Harry Wentland,
Christian König
Applied. Thanks!
Alex
On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski <rouven@czerwinskis.de> wrote:
>
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
2021-05-08 18:19 ` Rouven Czerwinski
(?)
@ 2021-05-10 21:33 ` Rodrigo Siqueira
-1 siblings, 0 replies; 12+ messages in thread
From: Rodrigo Siqueira @ 2021-05-10 21:33 UTC (permalink / raw)
To: Rouven Czerwinski, Pillai, Aurabindo
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rouven Czerwinski, linux-kernel,
dri-devel, amd-gfx, kernel
[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]
LGTM,
Jay, any comment?
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 05/08, Rouven Czerwinski wrote:
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 21:33 ` Rodrigo Siqueira
0 siblings, 0 replies; 12+ messages in thread
From: Rodrigo Siqueira @ 2021-05-10 21:33 UTC (permalink / raw)
To: Rouven Czerwinski, Pillai, Aurabindo
Cc: Rouven Czerwinski, kernel, Leo Li, linux-kernel, dri-devel,
David Airlie, amd-gfx, Alex Deucher, Christian König
[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]
LGTM,
Jay, any comment?
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 05/08, Rouven Czerwinski wrote:
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 21:33 ` Rodrigo Siqueira
0 siblings, 0 replies; 12+ messages in thread
From: Rodrigo Siqueira @ 2021-05-10 21:33 UTC (permalink / raw)
To: Rouven Czerwinski, Pillai, Aurabindo
Cc: Rouven Czerwinski, kernel, Leo Li, linux-kernel, dri-devel,
David Airlie, amd-gfx, Daniel Vetter, Alex Deucher,
Harry Wentland, Christian König
[-- Attachment #1.1: Type: text/plain, Size: 2902 bytes --]
LGTM,
Jay, any comment?
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 05/08, Rouven Czerwinski wrote:
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
> functions from dc to dc_link"), but a user is missing.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 3fb0cebd6938..55c5cf2264b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
> }
>
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern)
> -{
> - int i;
> -
> - for (i = 0; i < dc->link_count; i++)
> - dc_link_dp_perform_link_training(
> - dc->links[i],
> - link_setting,
> - skip_video_pattern);
> -}
> -
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
> index fc5622ffec3d..45c927cd27ab 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
> void dc_link_set_drive_settings(struct dc *dc,
> struct link_training_settings *lt_settings,
> const struct dc_link *link);
> -void dc_link_perform_link_training(struct dc *dc,
> - struct dc_link_settings *link_setting,
> - bool skip_video_pattern);
> void dc_link_set_preferred_link_settings(struct dc *dc,
> struct dc_link_settings *link_setting,
> struct dc_link *link);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
2021-05-10 21:33 ` Rodrigo Siqueira
(?)
@ 2021-05-10 23:49 ` Aurabindo Pillai
-1 siblings, 0 replies; 12+ messages in thread
From: Aurabindo Pillai @ 2021-05-10 23:49 UTC (permalink / raw)
To: Rodrigo Siqueira, Rouven Czerwinski
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rouven Czerwinski, linux-kernel,
dri-devel, amd-gfx, kernel
On 2021-05-10 5:33 p.m., Rodrigo Siqueira wrote:
> LGTM,
>
> Jay, any comment?
None, LGTM, and this applied already.
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> On 05/08, Rouven Czerwinski wrote:
>> This function is not used anywhere, remove it. It was added in
>> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
>> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
>> functions from dc to dc_link"), but a user is missing.
>>
>> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>> ---
>> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
>> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
>> 2 files changed, 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> index 3fb0cebd6938..55c5cf2264b3 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
>> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
>> }
>>
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern)
>> -{
>> - int i;
>> -
>> - for (i = 0; i < dc->link_count; i++)
>> - dc_link_dp_perform_link_training(
>> - dc->links[i],
>> - link_setting,
>> - skip_video_pattern);
>> -}
>> -
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> index fc5622ffec3d..45c927cd27ab 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
>> void dc_link_set_drive_settings(struct dc *dc,
>> struct link_training_settings *lt_settings,
>> const struct dc_link *link);
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern);
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link);
>> --
>> 2.31.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
>
--
Regards,
Aurabindo Pillai
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 23:49 ` Aurabindo Pillai
0 siblings, 0 replies; 12+ messages in thread
From: Aurabindo Pillai @ 2021-05-10 23:49 UTC (permalink / raw)
To: Rodrigo Siqueira, Rouven Czerwinski
Cc: Rouven Czerwinski, kernel, Leo Li, linux-kernel, dri-devel,
David Airlie, amd-gfx, Alex Deucher, Christian König
On 2021-05-10 5:33 p.m., Rodrigo Siqueira wrote:
> LGTM,
>
> Jay, any comment?
None, LGTM, and this applied already.
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> On 05/08, Rouven Czerwinski wrote:
>> This function is not used anywhere, remove it. It was added in
>> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
>> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
>> functions from dc to dc_link"), but a user is missing.
>>
>> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>> ---
>> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
>> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
>> 2 files changed, 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> index 3fb0cebd6938..55c5cf2264b3 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
>> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
>> }
>>
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern)
>> -{
>> - int i;
>> -
>> - for (i = 0; i < dc->link_count; i++)
>> - dc_link_dp_perform_link_training(
>> - dc->links[i],
>> - link_setting,
>> - skip_video_pattern);
>> -}
>> -
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> index fc5622ffec3d..45c927cd27ab 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
>> void dc_link_set_drive_settings(struct dc *dc,
>> struct link_training_settings *lt_settings,
>> const struct dc_link *link);
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern);
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link);
>> --
>> 2.31.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
>
--
Regards,
Aurabindo Pillai
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training
@ 2021-05-10 23:49 ` Aurabindo Pillai
0 siblings, 0 replies; 12+ messages in thread
From: Aurabindo Pillai @ 2021-05-10 23:49 UTC (permalink / raw)
To: Rodrigo Siqueira, Rouven Czerwinski
Cc: Rouven Czerwinski, kernel, Leo Li, linux-kernel, dri-devel,
David Airlie, amd-gfx, Daniel Vetter, Alex Deucher,
Harry Wentland, Christian König
On 2021-05-10 5:33 p.m., Rodrigo Siqueira wrote:
> LGTM,
>
> Jay, any comment?
None, LGTM, and this applied already.
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> On 05/08, Rouven Czerwinski wrote:
>> This function is not used anywhere, remove it. It was added in
>> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
>> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
>> functions from dc to dc_link"), but a user is missing.
>>
>> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>> ---
>> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
>> drivers/gpu/drm/amd/display/dc/dc_link.h | 3 ---
>> 2 files changed, 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> index 3fb0cebd6938..55c5cf2264b3 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
>> dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
>> }
>>
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern)
>> -{
>> - int i;
>> -
>> - for (i = 0; i < dc->link_count; i++)
>> - dc_link_dp_perform_link_training(
>> - dc->links[i],
>> - link_setting,
>> - skip_video_pattern);
>> -}
>> -
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> index fc5622ffec3d..45c927cd27ab 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
>> void dc_link_set_drive_settings(struct dc *dc,
>> struct link_training_settings *lt_settings,
>> const struct dc_link *link);
>> -void dc_link_perform_link_training(struct dc *dc,
>> - struct dc_link_settings *link_setting,
>> - bool skip_video_pattern);
>> void dc_link_set_preferred_link_settings(struct dc *dc,
>> struct dc_link_settings *link_setting,
>> struct dc_link *link);
>> --
>> 2.31.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
>
--
Regards,
Aurabindo Pillai
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-05-10 23:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 18:19 [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training Rouven Czerwinski
2021-05-08 18:19 ` Rouven Czerwinski
2021-05-08 18:19 ` Rouven Czerwinski
2021-05-10 20:53 ` Alex Deucher
2021-05-10 20:53 ` Alex Deucher
2021-05-10 20:53 ` Alex Deucher
2021-05-10 21:33 ` Rodrigo Siqueira
2021-05-10 21:33 ` Rodrigo Siqueira
2021-05-10 21:33 ` Rodrigo Siqueira
2021-05-10 23:49 ` Aurabindo Pillai
2021-05-10 23:49 ` Aurabindo Pillai
2021-05-10 23:49 ` Aurabindo Pillai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.