* [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h
@ 2021-05-10 2:43 Wan Jiabing
2021-05-10 7:01 ` Stefano Garzarella
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-05-10 2:43 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Stefano Garzarella,
Stefan Hajnoczi, Wan Jiabing, Max Gurtovoy, virtualization,
linux-kernel
Cc: kael_w
In commit 7d189f617f83f ("vdpa_sim_blk: implement ramdisk behaviour")
linux/blkdev.h was included here causing the duplicate include.
Remove the later duplicate include.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index 5bfe1c281645..a790903f243e 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
@@ -15,7 +15,6 @@
#include <linux/blkdev.h>
#include <linux/vringh.h>
#include <linux/vdpa.h>
-#include <linux/blkdev.h>
#include <uapi/linux/virtio_blk.h>
#include "vdpa_sim.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h
2021-05-10 2:43 [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h Wan Jiabing
@ 2021-05-10 7:01 ` Stefano Garzarella
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2021-05-10 7:01 UTC (permalink / raw)
To: Wan Jiabing
Cc: Michael S. Tsirkin, Jason Wang, Stefan Hajnoczi, Max Gurtovoy,
virtualization, linux-kernel, kael_w
On Mon, May 10, 2021 at 10:43:03AM +0800, Wan Jiabing wrote:
>In commit 7d189f617f83f ("vdpa_sim_blk: implement ramdisk behaviour")
>linux/blkdev.h was included here causing the duplicate include.
>Remove the later duplicate include.
>
>Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>index 5bfe1c281645..a790903f243e 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>@@ -15,7 +15,6 @@
> #include <linux/blkdev.h>
> #include <linux/vringh.h>
> #include <linux/vdpa.h>
>-#include <linux/blkdev.h>
> #include <uapi/linux/virtio_blk.h>
>
> #include "vdpa_sim.h"
>--
>2.20.1
>
Ooops...
Thanks for fixing this!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h
@ 2021-05-10 7:01 ` Stefano Garzarella
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2021-05-10 7:01 UTC (permalink / raw)
To: Wan Jiabing
Cc: Max Gurtovoy, Michael S. Tsirkin, linux-kernel, virtualization,
Stefan Hajnoczi, kael_w
On Mon, May 10, 2021 at 10:43:03AM +0800, Wan Jiabing wrote:
>In commit 7d189f617f83f ("vdpa_sim_blk: implement ramdisk behaviour")
>linux/blkdev.h was included here causing the duplicate include.
>Remove the later duplicate include.
>
>Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>index 5bfe1c281645..a790903f243e 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>@@ -15,7 +15,6 @@
> #include <linux/blkdev.h>
> #include <linux/vringh.h>
> #include <linux/vdpa.h>
>-#include <linux/blkdev.h>
> #include <uapi/linux/virtio_blk.h>
>
> #include "vdpa_sim.h"
>--
>2.20.1
>
Ooops...
Thanks for fixing this!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-10 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 2:43 [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h Wan Jiabing
2021-05-10 7:01 ` Stefano Garzarella
2021-05-10 7:01 ` Stefano Garzarella
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.