All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] RDMA/rxe: remove the unnecessary break
@ 2021-05-10  8:42 Zhu Yanjun
  2021-05-12  2:45 ` Zhu Yanjun
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2021-05-10  8:42 UTC (permalink / raw)
  To: zyjzyj2000, dledford, jgg, linux-rdma

From: Zhu Yanjun <zyjzyj2000@gmail.com>

In the final default, the break is not necessary.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
---
 drivers/infiniband/sw/rxe/rxe_qp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index 34ae957a315c..00588735744f 100644
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp,
 
 	default:
 		qp->ibqp.qp_num		= qpn;
-		break;
 	}
 
 	INIT_LIST_HEAD(&qp->grp_list);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] RDMA/rxe: remove the unnecessary break
  2021-05-10  8:42 [PATCH 1/1] RDMA/rxe: remove the unnecessary break Zhu Yanjun
@ 2021-05-12  2:45 ` Zhu Yanjun
  2021-05-12 12:48   ` Jason Gunthorpe
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2021-05-12  2:45 UTC (permalink / raw)
  To: Zhu Yanjun
  Cc: Doug Ledford, Jason Gunthorpe, RDMA mailing list, Leon Romanovsky

On Mon, May 10, 2021 at 12:18 AM Zhu Yanjun <yanjun.zhu@intel.com> wrote:
>
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> In the final default, the break is not necessary.

Hi, Jason Gunthorpe and Leon Romanovsky

Gently ping

Zhu Yanjun
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_qp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index 34ae957a315c..00588735744f 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp,
>
>         default:
>                 qp->ibqp.qp_num         = qpn;
> -               break;
>         }
>
>         INIT_LIST_HEAD(&qp->grp_list);
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] RDMA/rxe: remove the unnecessary break
  2021-05-12  2:45 ` Zhu Yanjun
@ 2021-05-12 12:48   ` Jason Gunthorpe
  0 siblings, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-05-12 12:48 UTC (permalink / raw)
  To: Zhu Yanjun; +Cc: Zhu Yanjun, Doug Ledford, RDMA mailing list, Leon Romanovsky

On Wed, May 12, 2021 at 10:45:17AM +0800, Zhu Yanjun wrote:
> On Mon, May 10, 2021 at 12:18 AM Zhu Yanjun <yanjun.zhu@intel.com> wrote:
> >
> > From: Zhu Yanjun <zyjzyj2000@gmail.com>
> >
> > In the final default, the break is not necessary.
> 
> Hi, Jason Gunthorpe and Leon Romanovsky
> 
> Gently ping

I'm not keen on this kind of churn

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-12 12:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10  8:42 [PATCH 1/1] RDMA/rxe: remove the unnecessary break Zhu Yanjun
2021-05-12  2:45 ` Zhu Yanjun
2021-05-12 12:48   ` Jason Gunthorpe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.