All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajat Asthana <thisisrast7@gmail.com>
To: mripard@kernel.org
Cc: maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Rajat Asthana <thisisrast7@gmail.com>
Subject: [PATCH v2] drm: Declare drm_send_event_helper static.
Date: Mon, 10 May 2021 18:46:16 +0530	[thread overview]
Message-ID: <20210510131616.544547-1-thisisrast7@gmail.com> (raw)
In-Reply-To: <20210510123243.hmwar3swmrewskjs@gilmour>

Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
---
Changes in v2:
    Provide full name in Author and Signed-off.

 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
  * The timestamp variant of dma_fence_signal is used when the caller
  * sends a valid timestamp.
  */
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
 			   struct drm_pending_event *e, ktime_t timestamp)
 {
 	assert_spin_locked(&dev->event_lock);
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Rajat Asthana <thisisrast7@gmail.com>
To: mripard@kernel.org
Cc: tzimmermann@suse.de, airlied@linux.ie,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rajat Asthana <thisisrast7@gmail.com>
Subject: [PATCH v2] drm: Declare drm_send_event_helper static.
Date: Mon, 10 May 2021 18:46:16 +0530	[thread overview]
Message-ID: <20210510131616.544547-1-thisisrast7@gmail.com> (raw)
In-Reply-To: <20210510123243.hmwar3swmrewskjs@gilmour>

Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
---
Changes in v2:
    Provide full name in Author and Signed-off.

 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
  * The timestamp variant of dma_fence_signal is used when the caller
  * sends a valid timestamp.
  */
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
 			   struct drm_pending_event *e, ktime_t timestamp)
 {
 	assert_spin_locked(&dev->event_lock);
-- 
2.31.1


  reply	other threads:[~2021-05-10 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 13:42 [PATCH] drm: Declare drm_send_event_helper static Rajat Asthana
2021-05-09 13:42 ` Rajat Asthana
2021-05-10 12:32 ` Maxime Ripard
2021-05-10 12:32   ` Maxime Ripard
2021-05-10 13:16   ` Rajat Asthana [this message]
2021-05-10 13:16     ` [PATCH v2] " Rajat Asthana
2021-05-10 22:35     ` Guenter Roeck
2021-05-10 22:35       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510131616.544547-1-thisisrast7@gmail.com \
    --to=thisisrast7@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.