* Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning [not found] <eb4c5af2-2980-a0f1-4708-a48da9570225.ref@yahoo.com> @ 2021-05-10 14:43 ` Ashish Vara 2021-05-10 14:55 ` Fabio Aiuto 0 siblings, 1 reply; 2+ messages in thread From: Ashish Vara @ 2021-05-10 14:43 UTC (permalink / raw) To: manishc, GR-Linux-NIC-Dev, coiby.xu, gregkh, netdev, linux-staging, linux-kernel Cc: ashishvara89 From: Ashish Vara <ashishvara89@yahoo.com> removed unnecessary out of memory message to fix coding style warning. Signed-off-by: Ashish Vara <ashishvara89@yahoo.com> --- drivers/staging/qlge/qlge_main.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index c9dc6a852af4..a9e0bccc52d0 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq) bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE, &bq->base_dma, GFP_ATOMIC); - if (!bq->base) { - netif_err(qdev, ifup, qdev->ndev, - "ring %u %s allocation failed.\n", rx_ring->cq_id, - bq_type_name[bq->type]); + if (!bq->base) return -ENOMEM; - } bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc), GFP_KERNEL); -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning 2021-05-10 14:43 ` Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning Ashish Vara @ 2021-05-10 14:55 ` Fabio Aiuto 0 siblings, 0 replies; 2+ messages in thread From: Fabio Aiuto @ 2021-05-10 14:55 UTC (permalink / raw) To: Ashish Vara Cc: manishc, GR-Linux-NIC-Dev, coiby.xu, gregkh, netdev, linux-staging, linux-kernel Hi Ashish, in your subject line there is one Subject: too many On Mon, May 10, 2021 at 08:13:37PM +0530, Ashish Vara wrote: > From: Ashish Vara <ashishvara89@yahoo.com> > > removed unnecessary out of memory message to fix coding style warning. > > Signed-off-by: Ashish Vara <ashishvara89@yahoo.com> > --- > drivers/staging/qlge/qlge_main.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index c9dc6a852af4..a9e0bccc52d0 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq) > > bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE, > &bq->base_dma, GFP_ATOMIC); > - if (!bq->base) { > - netif_err(qdev, ifup, qdev->ndev, > - "ring %u %s allocation failed.\n", rx_ring->cq_id, > - bq_type_name[bq->type]); > + if (!bq->base) > return -ENOMEM; > - } > > bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc), > GFP_KERNEL); > -- > 2.30.2 > thank you, fabio ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <eb4c5af2-2980-a0f1-4708-a48da9570225.ref@yahoo.com>
2021-05-10 14:43 ` Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning Ashish Vara
2021-05-10 14:55 ` Fabio Aiuto
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.