From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: petri.latvala@intel.com
Subject: [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure
Date: Mon, 10 May 2021 23:29:46 +0530 [thread overview]
Message-ID: <20210510175946.139597-1-kunal1.joshi@intel.com> (raw)
We have a thread called chamelium_fsm_mon which monitors HPD events
triggered by chamelium, Unfortunately not always the HPD event arrives
in a fixed interval (mostly does), Quick fix to this is to retry.
v2: Remove redundant assert (Bhanu)
v3: Cleanup (Petri)
Fixes :- https://gitlab.freedesktop.org/drm/intel/-/issues/262
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Modem Bhanuprakash <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_chamelium.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 7085122a..b4d838bb 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -522,12 +522,29 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
{
xmlrpc_value *res;
va_list va_args;
+ int fsm_trials_left = 5;
+
+ if (strcmp(method_name, "CaptureVideo") == 0
+ || strcmp(method_name, "StartCapturingVideo") == 0) {
+ while (fsm_trials_left) {
+ va_start(va_args, format_str);
+ res = __chamelium_rpc_va(chamelium, fsm_port,
+ method_name, format_str,
+ va_args);
+ va_end(va_args);
+
+ if (!chamelium->env.fault_occurred)
+ break;
- va_start(va_args, format_str);
- res = __chamelium_rpc_va(chamelium, fsm_port, method_name,
- format_str, va_args);
- va_end(va_args);
-
+ igt_debug("DP FSM failed retrying, tries left %d\n", fsm_trials_left);
+ --fsm_trials_left;
+ }
+ } else {
+ va_start(va_args, format_str);
+ res = __chamelium_rpc_va(chamelium, fsm_port, method_name,
+ format_str, va_args);
+ va_end(va_args);
+ }
igt_assert_f(!chamelium->env.fault_occurred,
"Chamelium RPC call failed: %s\n",
chamelium->env.fault_string);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2021-05-10 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 17:59 Kunal Joshi [this message]
2021-05-10 18:55 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium: Retry DP FSM on Failure (rev3) Patchwork
2021-05-10 20:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-05-04 7:04 [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure Kunal Joshi
2021-05-05 8:19 ` Petri Latvala
2021-05-06 8:02 ` Joshi, Kunal1
2021-05-04 6:12 Kunal Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510175946.139597-1-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.