From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: "Latvala, Petri" <petri.latvala@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure
Date: Thu, 6 May 2021 08:02:54 +0000 [thread overview]
Message-ID: <7c8c8563ef984d0daa7bb2e0f0904f49@intel.com> (raw)
In-Reply-To: <YJJVE5S1Y1kEMCD+@platvala-desk.ger.corp.intel.com>
>>From: Latvala, Petri <petri.latvala@intel.com>
>>Sent: Wednesday, May 5, 2021 1:50 PM
>>To: Joshi, Kunal1 <kunal1.joshi@intel.com>
>>Cc: igt-dev@lists.freedesktop.org; Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
>>Subject: Re: [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure
>>On Tue, May 04, 2021 at 07:04:15AM +0000, Kunal Joshi wrote:
>> We have a thread called chamelium_fsm_mon which monitors HPD events
>>triggered by chamelium, Unfortunately not always the HPD event arrives
>> in a fixed interval (mostly does), Quick fix to this is to retry.
>>
>> v2: Remove redundant assert (Bhanu)
>>
>> Fixes :- https://gitlab.freedesktop.org/drm/intel/-/issues/262
>> Cc: Petri Latvala <petri.latvala@intel.com>
>> Cc: Modem Bhanuprakash <bhanuprakash.modem@intel.com>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>Another extra empty line.
>With the extra empty lines removed this is
>Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>Is CaptureVideo really the only method that needs this retrying?
CaptureVideo is the only command currently which can trigger DP FSM,
There are other commands such as StartVideoCapture but we don't use them,
But will add those incase somebody uses it.
Thanks for the review and feedback petri.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-05-06 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 7:04 [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure Kunal Joshi
2021-05-04 7:38 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium: Retry DP FSM on Failure (rev2) Patchwork
2021-05-04 9:06 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-05 8:19 ` [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure Petri Latvala
2021-05-06 8:02 ` Joshi, Kunal1 [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-10 17:59 Kunal Joshi
2021-05-04 6:12 Kunal Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8c8563ef984d0daa7bb2e0f0904f49@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.