[PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[Ross Burton]

These recipes don't build anything, so there's no need to depend on a
toolchain.

Change-Id: I49b641fb54839c30255a11a7c9d5798c8e4afd2a
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
index 2fbabfb..046ab62 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
@@ -1,3 +1,5 @@
+INHIBIT_DEFAULT_DEPS = "1"
+
 FILES_${PN} = "${datadir} ${bindir}"
 
 BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
-- 
2.25.1

[PATCH 2/3] arm-toolchain/armcompiler: add upstream release checking

[Ross Burton]

Change-Id: I2eb94f99a0c828a4d5f2f68756e83ebc1f6499c2
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/armcompiler_6.16.bb                 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
index b954e76..ca81294 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
@@ -33,6 +33,9 @@ SRC_URI = "https://developer.arm.com/-/media/Files/downloads/compiler/${ARMCLANG
 SRC_URI[md5sum] = "d41d8cd98f00b204e9800998ecf8427e"
 SRC_URI[sha256sum] = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
 
+UPSTREAM_CHECK_URI = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/"
+UPSTREAM_CHECK_REGEX = "Download Arm Compiler.*,(?P<pver>[\d\.]+)"
+
 S = "${WORKDIR}/${ARMCLANG_VERSION}"
 
 do_install() {
-- 
2.25.1

[PATCH 3/3] arm-toolchain/armcompiler: remove pointless PROVIDES

[Ross Burton]

There is only one provider for the armcompiler, so remove the virtual
provider.

Change-Id: I3492c49f5cf6eb6f3d3156adb3d87e315ed8183d
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/armcompiler_6.16.bb                 | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
index ca81294..60656b8 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.16.bb
@@ -22,14 +22,11 @@ LIC_FILES_CHKSUM = "file://license_terms/license_agreement.txt;md5=40cd57dbb1f9d
                     file://license_terms/supplementary_terms.txt;md5=17a2efdbd320ceda48a3521747e02dd9 \
                     file://license_terms/third_party_licenses.txt;md5=6273fa29eb26c0093e1a7deaef7bafec "
 
-PROVIDES = "virtual/armcompiler"
-
 ARMCLANG_VERSION = "DS500-BN-00026-r5p0-18rel0"
 
 COMPATIBLE_HOST = "x86_64.*-linux"
 
 SRC_URI = "https://developer.arm.com/-/media/Files/downloads/compiler/${ARMCLANG_VERSION}.tgz;subdir=${ARMCLANG_VERSION}"
-
 SRC_URI[md5sum] = "d41d8cd98f00b204e9800998ecf8427e"
 SRC_URI[sha256sum] = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
 
-- 
2.25.1

Re: [meta-arm] [PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[Sumit Garg]

On Mon, 10 May 2021 at 23:46, Ross Burton <ross@burtonini.com> wrote:
>
> These recipes don't build anything, so there's no need to depend on a
> toolchain.
>
> Change-Id: I49b641fb54839c30255a11a7c9d5798c8e4afd2a
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 ++
>  1 file changed, 2 insertions(+)
>

For the series:

Acked-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> index 2fbabfb..046ab62 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> @@ -1,3 +1,5 @@
> +INHIBIT_DEFAULT_DEPS = "1"
> +
>  FILES_${PN} = "${datadir} ${bindir}"
>
>  BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
> --
> 2.25.1
>
>
> 
>

Re: [meta-arm] [PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[Jon Mason]

On Tue, May 11, 2021 at 10:05:58AM +0530, Sumit Garg wrote:
> On Mon, 10 May 2021 at 23:46, Ross Burton <ross@burtonini.com> wrote:
> >
> > These recipes don't build anything, so there's no need to depend on a
> > toolchain.
> >
> > Change-Id: I49b641fb54839c30255a11a7c9d5798c8e4afd2a
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >  .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> 
> For the series:
> 
> Acked-by: Sumit Garg <sumit.garg@linaro.org>

Apologies, I was too quick with the trigger and pulled these in before
you acked.  In my defense, it did pass our internal build CI, and my
WIP testing. We're still working on a way to have it public, but here
is a preview of just the building:
https://gitlab.com/jonmason00/meta-arm/-/pipelines/298844578

You can see from the names that we are getting some coverage for
clang, Arm Binary toolchains, Arm GCC sources, and musl (for good
measure).  Not enough computing power currently for every possible
permutation, but if you can see any obvious coverage gaps, let me/us
know.

Thanks,
Jon

> 
> -Sumit
> 
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > index 2fbabfb..046ab62 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > @@ -1,3 +1,5 @@
> > +INHIBIT_DEFAULT_DEPS = "1"
> > +
> >  FILES_${PN} = "${datadir} ${bindir}"
> >
> >  BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
> > --
> > 2.25.1
> >
> >
> > 
> >

> 
> 
> 

Re: [meta-arm] [PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[Denys Dmytriyenko]

On Thu, May 13, 2021 at 10:58:31AM -0400, Jon Mason wrote:
> On Tue, May 11, 2021 at 10:05:58AM +0530, Sumit Garg wrote:
> > On Mon, 10 May 2021 at 23:46, Ross Burton <ross@burtonini.com> wrote:
> > >
> > > These recipes don't build anything, so there's no need to depend on a
> > > toolchain.
> > >
> > > Change-Id: I49b641fb54839c30255a11a7c9d5798c8e4afd2a
> > > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > > ---
> > >  .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > 
> > For the series:
> > 
> > Acked-by: Sumit Garg <sumit.garg@linaro.org>
> 
> Apologies, I was too quick with the trigger and pulled these in before
> you acked.  In my defense, it did pass our internal build CI, and my
> WIP testing. We're still working on a way to have it public, but here
> is a preview of just the building:
> https://gitlab.com/jonmason00/meta-arm/-/pipelines/298844578
> 
> You can see from the names that we are getting some coverage for
> clang, Arm Binary toolchains, Arm GCC sources, and musl (for good
> measure).  Not enough computing power currently for every possible
> permutation, but if you can see any obvious coverage gaps, let me/us
> know.

Jon,

This looks great and is really promising. Please let us know if you need 
anything. Thanks.


> > > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > index 2fbabfb..046ab62 100644
> > > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > @@ -1,3 +1,5 @@
> > > +INHIBIT_DEFAULT_DEPS = "1"
> > > +
> > >  FILES_${PN} = "${datadir} ${bindir}"
> > >
> > >  BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
> > > --
> > > 2.25.1
> > >
> > >
> > > 
> > >
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [meta-arm] [PATCH 1/3] arm-toolchain/external-arm-toolchain: inhibit build dependencies

[Sumit Garg]

On Thu, 13 May 2021 at 20:28, Jon Mason <jdmason@kudzu.us> wrote:
>
> On Tue, May 11, 2021 at 10:05:58AM +0530, Sumit Garg wrote:
> > On Mon, 10 May 2021 at 23:46, Ross Burton <ross@burtonini.com> wrote:
> > >
> > > These recipes don't build anything, so there's no need to depend on a
> > > toolchain.
> > >
> > > Change-Id: I49b641fb54839c30255a11a7c9d5798c8e4afd2a
> > > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > > ---
> > >  .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> >
> > For the series:
> >
> > Acked-by: Sumit Garg <sumit.garg@linaro.org>
>
> Apologies, I was too quick with the trigger and pulled these in before
> you acked.

No worries :)

> In my defense, it did pass our internal build CI, and my
> WIP testing. We're still working on a way to have it public, but here
> is a preview of just the building:
> https://gitlab.com/jonmason00/meta-arm/-/pipelines/298844578
>
> You can see from the names that we are getting some coverage for
> clang, Arm Binary toolchains, Arm GCC sources, and musl (for good
> measure).  Not enough computing power currently for every possible
> permutation, but if you can see any obvious coverage gaps, let me/us
> know.
>

Thanks for setting it up. Having a CI setup for toolchain testing is
great especially for binary toolchains. Following are additional test
scenarios that come to my mind:

1. SDK build and test.
2. If computation power allows then we should do a "bitbake world"
prior to every release as that would allow us to cover building almost
all recipes (for included layers) using Arm source/binary toolchains.

-Sumit

> Thanks,
> Jon
>
> >
> > -Sumit
> >
> > > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > index 2fbabfb..046ab62 100644
> > > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > > @@ -1,3 +1,5 @@
> > > +INHIBIT_DEFAULT_DEPS = "1"
> > > +
> > >  FILES_${PN} = "${datadir} ${bindir}"
> > >
> > >  BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
>
> >
> > 
> >
>