[xlnx:master 11929/12199] drivers/usb/dwc3/dwc3-xilinx.c:200:9: error: too many arguments to function 'zynqmp_pm_usb_set_state'

* [xlnx:master 11929/12199] drivers/usb/dwc3/dwc3-xilinx.c:200:9: error: too many arguments to function 'zynqmp_pm_usb_set_state'
@ 2021-05-10 14:49 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-05-10 14:49 UTC (permalink / raw)
  To: Manish Narani; +Cc: kbuild-all, linux-arm-kernel, Michal Simek

[-- Attachment #1: Type: text/plain, Size: 4185 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx master
head:   bea04171cb9e59f85602890504a91f4d1321df21
commit: d547e47f6e3cce45a3aa7f7d477558ba2cd77387 [11929/12199] usb: dwc3: Add power management support in DWC3 Xilinx driver
config: arm64-randconfig-r031-20210510 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/d547e47f6e3cce45a3aa7f7d477558ba2cd77387
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx master
        git checkout d547e47f6e3cce45a3aa7f7d477558ba2cd77387
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/dwc3-xilinx.c: In function 'dwc3_versal_power_req':
>> drivers/usb/dwc3/dwc3-xilinx.c:200:9: error: too many arguments to function 'zynqmp_pm_usb_set_state'
     200 |   ret = zynqmp_pm_usb_set_state(VERSAL_USB_NODE_ID,
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/dwc3-xilinx.c:21:
   include/linux/firmware/xlnx-zynqmp.h:835:19: note: declared here
     835 | static inline int zynqmp_pm_usb_set_state(u32 state, u32 value)
         |                   ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/dwc3-xilinx.c:215:9: error: too many arguments to function 'zynqmp_pm_usb_set_state'
     215 |   ret = zynqmp_pm_usb_set_state(VERSAL_USB_NODE_ID,
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/dwc3-xilinx.c:21:
   include/linux/firmware/xlnx-zynqmp.h:835:19: note: declared here
     835 | static inline int zynqmp_pm_usb_set_state(u32 state, u32 value)
         |                   ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/dwc3-xilinx.c: At top level:
   drivers/usb/dwc3/dwc3-xilinx.c:282:5: warning: no previous prototype for 'dwc3_xlnx_register_regulator' [-Wmissing-prototypes]
     282 | int dwc3_xlnx_register_regulator(struct device *dev,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/zynqmp_pm_usb_set_state +200 drivers/usb/dwc3/dwc3-xilinx.c

   180	
   181	static int dwc3_versal_power_req(struct device *dev, bool on)
   182	{
   183		int ret;
   184		struct dwc3_xlnx *priv_data;
   185	
   186		priv_data = dev_get_drvdata(dev);
   187	
   188		if (on) {
   189			dev_dbg(dev, "%s:Trying to set power state to D0....\n",
   190				 __func__);
   191	
   192			if (priv_data->pmu_state == D0_STATE)
   193				return 0;
   194	
   195			ret = zynqmp_pm_reset_assert(VERSAL_USB_RESET_ID,
   196						     PM_RESET_ACTION_RELEASE);
   197			if (ret < 0)
   198				dev_err(priv_data->dev, "failed to De-assert Reset\n");
   199	
 > 200			ret = zynqmp_pm_usb_set_state(VERSAL_USB_NODE_ID,
   201						      XLNX_REQ_PWR_STATE_D0,
   202						      DWC3_PWR_STATE_RETRIES *
   203						      DWC3_PWR_TIMEOUT);
   204			if (ret < 0)
   205				dev_err(priv_data->dev, "failed to enter D0 state\n");
   206	
   207			priv_data->pmu_state = D0_STATE;
   208		} else {
   209			dev_dbg(dev, "%s:Trying to set power state to D3...\n",
   210				__func__);
   211	
   212			if (priv_data->pmu_state == D3_STATE)
   213				return 0;
   214	
   215			ret = zynqmp_pm_usb_set_state(VERSAL_USB_NODE_ID,
   216						      XLNX_REQ_PWR_STATE_D3,
   217						      DWC3_PWR_STATE_RETRIES *
   218						      DWC3_PWR_TIMEOUT);
   219			if (ret < 0)
   220				dev_err(priv_data->dev, "failed to enter D3 state\n");
   221	
   222			ret = zynqmp_pm_reset_assert(VERSAL_USB_RESET_ID,
   223						     PM_RESET_ACTION_ASSERT);
   224			if (ret < 0)
   225				dev_err(priv_data->dev, "failed to assert Reset\n");
   226	
   227			priv_data->pmu_state = D3_STATE;
   228		}
   229	
   230		return ret;
   231	}
   232	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41725 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread