[nomadik:nomadik-nhk15-smsc 3/3] drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

[nomadik:nomadik-nhk15-smsc 3/3] drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Linus Walleij <linus.walleij@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git nomadik-nhk15-smsc
head:   8272c2e41330833ecf16669b97a251b502f21b94
commit: 8272c2e41330833ecf16669b97a251b502f21b94 [3/3] SMSC slask
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: h8300-randconfig-c004-20210510 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31395 bytes --]

[PATCH] fix irqf_oneshot.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Linus Walleij <linus.walleij@linaro.org>
CC: Nicolas Pitre <nico@fluxnic.net>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Allen Pais <apais@linux.microsoft.com>
CC: Colin Ian King <colin.king@canonical.com>
CC: Luo Jiaxing <luojiaxing@huawei.com>
CC: Wang Hai <wanghai38@huawei.com>
CC: Lee Jones <lee.jones@linaro.org>
CC: netdev(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Fixes: 8272c2e41330 ("SMSC slask")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git nomadik-nhk15-smsc
head:   8272c2e41330833ecf16669b97a251b502f21b94
commit: 8272c2e41330833ecf16669b97a251b502f21b94 [3/3] SMSC slask
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago

Please take the patch only if it's a positive warning. Thanks!

 smc91x.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1998,7 +1998,9 @@ static int smc_probe(struct net_device *
 
 	/* Grab the IRQ */
 	irq_flags |= IRQF_ONESHOT;
-	retval = request_threaded_irq(dev->irq, NULL, smc_interrupt, irq_flags, dev->name, dev);
+	retval = request_threaded_irq(dev->irq, NULL, smc_interrupt,
+				      irq_flags | IRQF_ONESHOT, dev->name,
+				      dev);
       	if (retval)
       		goto err_out;
 

[nomadik:nomadik-nhk15-smsc 3/3] drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Linus Walleij <linus.walleij@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git nomadik-nhk15-smsc
head:   75ac9d5e2268a8506be065fbacd25197135527bb
commit: 75ac9d5e2268a8506be065fbacd25197135527bb [3/3] SMSC slask
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago
config: xtensa-randconfig-c004-20200629 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30783 bytes --]