* [PATCH 1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe()
@ 2021-05-11 10:06 Zhen Lei
2021-05-12 11:38 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-11 10:06 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio; +Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpio/gpio-logicvc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
index 015632cf159f0b8..992cc958a43fd1e 100644
--- a/drivers/gpio/gpio-logicvc.c
+++ b/drivers/gpio/gpio-logicvc.c
@@ -114,10 +114,8 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
}
base = devm_ioremap_resource(dev, &res);
- if (IS_ERR(base)) {
- dev_err(dev, "Failed to map I/O base\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
logicvc_gpio_regmap_config.max_register = resource_size(&res) -
logicvc_gpio_regmap_config.reg_stride;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe()
2021-05-11 10:06 [PATCH 1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe() Zhen Lei
@ 2021-05-12 11:38 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-12 11:38 UTC (permalink / raw)
To: Zhen Lei; +Cc: Linus Walleij, linux-gpio
On Tue, May 11, 2021 at 12:07 PM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpio/gpio-logicvc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
> index 015632cf159f0b8..992cc958a43fd1e 100644
> --- a/drivers/gpio/gpio-logicvc.c
> +++ b/drivers/gpio/gpio-logicvc.c
> @@ -114,10 +114,8 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
> }
>
> base = devm_ioremap_resource(dev, &res);
> - if (IS_ERR(base)) {
> - dev_err(dev, "Failed to map I/O base\n");
> + if (IS_ERR(base))
> return PTR_ERR(base);
> - }
>
> logicvc_gpio_regmap_config.max_register = resource_size(&res) -
> logicvc_gpio_regmap_config.reg_stride;
> --
> 2.26.0.106.g9fadedd
>
>
Applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 10:06 [PATCH 1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe() Zhen Lei
2021-05-12 11:38 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.