* [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled
@ 2021-05-11 20:08 Tedd Ho-Jeong An
2021-05-11 20:08 ` [BlueZ PATCH v2 2/2] config: Change the config option for manpages Tedd Ho-Jeong An
2021-05-11 20:41 ` [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled bluez.test.bot
0 siblings, 2 replies; 4+ messages in thread
From: Tedd Ho-Jeong An @ 2021-05-11 20:08 UTC (permalink / raw)
To: linux-bluetooth
From: Tedd Ho-Jeong An <tedd.an@intel.com>
This patch adds a check if the conversion tool is installed when the
manpages is enabled, and show error if it is not installed.
---
configure.ac | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure.ac b/configure.ac
index f445589b0..2b044f8e5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -328,6 +328,9 @@ AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages],
[enable_manpages=${enableval}])
if (test "${enable_manpages}" != "no"); then
AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no")
+ if (test "${RST2MAN}" = "no" ); then
+ AC_MSG_ERROR([rst2man is required])
+ fi
fi
AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes")
AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no")
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [BlueZ PATCH v2 2/2] config: Change the config option for manpages
2021-05-11 20:08 [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled Tedd Ho-Jeong An
@ 2021-05-11 20:08 ` Tedd Ho-Jeong An
2021-05-11 20:41 ` [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled bluez.test.bot
1 sibling, 0 replies; 4+ messages in thread
From: Tedd Ho-Jeong An @ 2021-05-11 20:08 UTC (permalink / raw)
To: linux-bluetooth
From: Tedd Ho-Jeong An <tedd.an@intel.com>
The current config option for manpages provided by the configure.ac
alwasys enables the manpages whether 'enable-manpages' option is
specified or not. To clarify the expected behavior, this patch changes
the manpages option to 'disable-manpages' so the manpages are alwasy
enabled unless the '--disable-manpages' option is specified.
---
configure.ac | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2b044f8e5..5157da1b5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -323,8 +323,8 @@ AC_ARG_ENABLE(datafiles, AC_HELP_STRING([--disable-datafiles],
[enable_datafiles=${enableval}])
AM_CONDITIONAL(DATAFILES, test "${enable_datafiles}" != "no")
-AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages],
- [enable building of manual pages]),
+AC_ARG_ENABLE(manpages, AC_HELP_STRING([--disable-manpages],
+ [disable building of manual pages]),
[enable_manpages=${enableval}])
if (test "${enable_manpages}" != "no"); then
AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no")
@@ -332,8 +332,8 @@ if (test "${enable_manpages}" != "no"); then
AC_MSG_ERROR([rst2man is required])
fi
fi
-AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes")
-AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no")
+AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" != "no")
+AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" && test "${RST2MAN}" != "no")
AC_ARG_ENABLE(testing, AC_HELP_STRING([--enable-testing],
[enable testing tools]),
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled
2021-05-11 20:08 [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled Tedd Ho-Jeong An
2021-05-11 20:08 ` [BlueZ PATCH v2 2/2] config: Change the config option for manpages Tedd Ho-Jeong An
@ 2021-05-11 20:41 ` bluez.test.bot
2021-05-11 22:40 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: bluez.test.bot @ 2021-05-11 20:41 UTC (permalink / raw)
To: linux-bluetooth, hj.tedd.an
[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=480695
---Test result---
Test Summary:
CheckPatch PASS 0.80 seconds
GitLint PASS 0.26 seconds
Prep - Setup ELL PASS 48.35 seconds
Build - Prep PASS 0.11 seconds
Build - Configure PASS 8.59 seconds
Build - Make PASS 206.79 seconds
Make Check PASS 9.27 seconds
Make Dist PASS 13.27 seconds
Make Dist - Configure PASS 5.30 seconds
Make Dist - Make PASS 83.52 seconds
Build w/ext ELL - Configure PASS 8.53 seconds
Build w/ext ELL - Make PASS 194.49 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball
##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball
##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled
2021-05-11 20:41 ` [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled bluez.test.bot
@ 2021-05-11 22:40 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-11 22:40 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Tedd Ho-Jeong An
Hi Tedd,
On Tue, May 11, 2021 at 1:43 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=480695
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.80 seconds
> GitLint PASS 0.26 seconds
> Prep - Setup ELL PASS 48.35 seconds
> Build - Prep PASS 0.11 seconds
> Build - Configure PASS 8.59 seconds
> Build - Make PASS 206.79 seconds
> Make Check PASS 9.27 seconds
> Make Dist PASS 13.27 seconds
> Make Dist - Configure PASS 5.30 seconds
> Make Dist - Make PASS 83.52 seconds
> Build w/ext ELL - Configure PASS 8.53 seconds
> Build w/ext ELL - Make PASS 194.49 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Dist - PASS
> Desc: Run 'make dist' and build the distribution tarball
>
> ##############################
> Test: Make Dist - Configure - PASS
> Desc: Configure the source from distribution tarball
>
> ##############################
> Test: Make Dist - Make - PASS
> Desc: Build the source from distribution tarball
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 22:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 20:08 [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled Tedd Ho-Jeong An
2021-05-11 20:08 ` [BlueZ PATCH v2 2/2] config: Change the config option for manpages Tedd Ho-Jeong An
2021-05-11 20:41 ` [BlueZ,v2,1/2] config: Show error if rst2man not found when manpages are enabled bluez.test.bot
2021-05-11 22:40 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.