All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [v6 i-g-t 06/14] tests/kms_plane_scaling: Fix mode selection for 2x tests
Date: Wed, 12 May 2021 22:35:28 +0530	[thread overview]
Message-ID: <20210512170536.4778-7-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20210512170536.4778-1-bhanuprakash.modem@intel.com>

This patch will find the connector/mode combination that fits
into the bandwidth when more than one monitor is connected.

Example:
  When two monitors connected through MST, the second monitor
  also tries to use the same mode. So two such modes may not
  fit into the link bandwidth. So, iterate through connected
  outputs & modes and find a combination of modes those fit
  into the link BW.

V2:
* Fix commit message (Ankit)

Cc: Imre Deak <imre.deak@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 tests/kms_plane_scaling.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 34efc588e..7464b5bdf 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -630,9 +630,6 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	d->plane3 = igt_output_get_plane(output2, 0);
 	d->plane4 = get_num_scalers(d, pipe2) >= 2 ? igt_output_get_plane(output2, 1) : NULL;
 
-	mode1 = igt_output_get_mode(output1);
-	mode2 = igt_output_get_mode(output2);
-
 	igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
 						tiling));
 
@@ -658,8 +655,20 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_plane_set_fb(d->plane3, &d->fb[2]);
 	if (d->plane4)
 		igt_plane_set_fb(d->plane4, &d->fb[3]);
+
+	if (igt_display_try_commit_atomic(display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) != 0) {
+		bool found = igt_override_all_active_output_modes_to_fit_bw(display);
+		igt_require_f(found, "No valid mode combo found.\n");
+	}
+
 	igt_display_commit2(display, COMMIT_ATOMIC);
 
+	mode1 = igt_output_get_mode(output1);
+	mode2 = igt_output_get_mode(output2);
+
 	/* Upscaling Primary */
 	igt_plane_set_size(d->plane1, mode1->hdisplay, mode1->vdisplay);
 	igt_plane_set_size(d->plane3, mode2->hdisplay, mode2->vdisplay);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-05-12  9:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 17:05 [igt-dev] [v6 i-g-t 00/14] Fix mode selection for 2x tests Bhanuprakash Modem
2021-05-12 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix mode selection for 2x tests (rev6) Patchwork
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 01/14] lib/igt_kms: helper to override the mode on all connectors Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 02/14] tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 03/14] tests/kms_cursor_legacy: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 04/14] tests/debugfs_test: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 05/14] tests/kms_content_protection: " Bhanuprakash Modem
2021-05-12 17:05 ` Bhanuprakash Modem [this message]
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 07/14] tests/kms_atomic_transition: " Bhanuprakash Modem
2021-05-12 10:39   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 08/14] tests/kms_plane: Reset the state before exiting the test Bhanuprakash Modem
2021-05-19  5:40   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 09/14] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2021-05-19  6:50   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 10/14] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2021-05-19  5:50   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 11/14] tests/kms_plane_lowres: " Bhanuprakash Modem
2021-05-19  7:01   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 12/14] tests/kms_plane_cursor: " Bhanuprakash Modem
2021-05-19  6:44   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 13/14] tests/kms_flip_scaled_crc: " Bhanuprakash Modem
2021-05-19  6:42   ` Nautiyal, Ankit K
2021-05-19 15:30   ` [igt-dev] [v7 i-g-t 6/7] " Bhanuprakash Modem
2021-05-19 15:36     ` [igt-dev] [v8 i-g-t 13/14] " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 14/14] tests/kms_vblank: " Bhanuprakash Modem
2021-05-19  6:24   ` Nautiyal, Ankit K
2021-05-19  9:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix mode selection for 2x tests (rev8) Patchwork
2021-05-19  9:56 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512170536.4778-7-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.