All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [v6 i-g-t 14/14] tests/kms_vblank: Reset the state before exiting the test
Date: Wed, 19 May 2021 11:54:29 +0530	[thread overview]
Message-ID: <86012bf6-b883-503b-b2fa-3c740766ffc5@intel.com> (raw)
In-Reply-To: <20210512170536.4778-15-bhanuprakash.modem@intel.com>

LGTM

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

On 5/12/2021 10:35 PM, Bhanuprakash Modem wrote:
> Before starting the next subtest, clean up the states to default
> values, those are assumed by other tests.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_vblank.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index e561e41d7..93b01eba0 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -96,6 +96,8 @@ static void prepare_crtc(data_t *data, int fd, igt_output_t *output)
>   
>   static void cleanup_crtc(data_t *data, int fd, igt_output_t *output)
>   {
> +	igt_output_set_pipe(output, PIPE_NONE);
> +	igt_display_commit(&data->display);
>   	igt_remove_fb(fd, &data->primary_fb);
>   }
>   
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-05-19  6:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 17:05 [igt-dev] [v6 i-g-t 00/14] Fix mode selection for 2x tests Bhanuprakash Modem
2021-05-12 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix mode selection for 2x tests (rev6) Patchwork
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 01/14] lib/igt_kms: helper to override the mode on all connectors Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 02/14] tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 03/14] tests/kms_cursor_legacy: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 04/14] tests/debugfs_test: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 05/14] tests/kms_content_protection: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 06/14] tests/kms_plane_scaling: " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 07/14] tests/kms_atomic_transition: " Bhanuprakash Modem
2021-05-12 10:39   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 08/14] tests/kms_plane: Reset the state before exiting the test Bhanuprakash Modem
2021-05-19  5:40   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 09/14] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2021-05-19  6:50   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 10/14] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2021-05-19  5:50   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 11/14] tests/kms_plane_lowres: " Bhanuprakash Modem
2021-05-19  7:01   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 12/14] tests/kms_plane_cursor: " Bhanuprakash Modem
2021-05-19  6:44   ` Nautiyal, Ankit K
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 13/14] tests/kms_flip_scaled_crc: " Bhanuprakash Modem
2021-05-19  6:42   ` Nautiyal, Ankit K
2021-05-19 15:30   ` [igt-dev] [v7 i-g-t 6/7] " Bhanuprakash Modem
2021-05-19 15:36     ` [igt-dev] [v8 i-g-t 13/14] " Bhanuprakash Modem
2021-05-12 17:05 ` [igt-dev] [v6 i-g-t 14/14] tests/kms_vblank: " Bhanuprakash Modem
2021-05-19  6:24   ` Nautiyal, Ankit K [this message]
2021-05-19  9:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix mode selection for 2x tests (rev8) Patchwork
2021-05-19  9:56 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86012bf6-b883-503b-b2fa-3c740766ffc5@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.