* [PATCH] Unnecessary code change in spin_lock section.
[not found] <CGME20210513023747epcas1p23502f390781d1a5a8f6512982af1fd65@epcas1p2.samsung.com>
@ 2021-05-13 2:33 ` Chanwoo Lee
2021-05-17 11:34 ` Adrian Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Chanwoo Lee @ 2021-05-13 2:33 UTC (permalink / raw)
To: adrian.hunter, riteshh, asutoshd, ulf.hansson, linux-mmc, linux-kernel
Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee, cw9316.lee
From: ChanWoo Lee <cw9316.lee@samsung.com>
This is the spin_lock section for cq_host, and mmc setting is unnecessary.
Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
---
drivers/mmc/host/cqhci-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
index 93b0432bb601..4d76c858d45f 100644
--- a/drivers/mmc/host/cqhci-core.c
+++ b/drivers/mmc/host/cqhci-core.c
@@ -1090,8 +1090,8 @@ static void cqhci_recovery_finish(struct mmc_host *mmc)
spin_lock_irqsave(&cq_host->lock, flags);
cq_host->qcnt = 0;
cq_host->recovery_halt = false;
- mmc->cqe_on = false;
spin_unlock_irqrestore(&cq_host->lock, flags);
+ mmc->cqe_on = false;
/* Ensure all writes are done before interrupts are re-enabled */
wmb();
--
2.29.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Unnecessary code change in spin_lock section.
2021-05-13 2:33 ` [PATCH] Unnecessary code change in spin_lock section Chanwoo Lee
@ 2021-05-17 11:34 ` Adrian Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Hunter @ 2021-05-17 11:34 UTC (permalink / raw)
To: Chanwoo Lee, riteshh, asutoshd, ulf.hansson, linux-mmc, linux-kernel
Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee
On 13/05/21 5:33 am, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> This is the spin_lock section for cq_host, and mmc setting is unnecessary.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> ---
> drivers/mmc/host/cqhci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index 93b0432bb601..4d76c858d45f 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -1090,8 +1090,8 @@ static void cqhci_recovery_finish(struct mmc_host *mmc)
> spin_lock_irqsave(&cq_host->lock, flags);
> cq_host->qcnt = 0;
> cq_host->recovery_halt = false;
> - mmc->cqe_on = false;
> spin_unlock_irqrestore(&cq_host->lock, flags);
No, we don't want anyone to see mmc->cqe_on == true and
cq_host->recovery_halt == false at this point.
> + mmc->cqe_on = false;> /* Ensure all writes are done before interrupts are re-enabled */
> wmb();
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-17 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210513023747epcas1p23502f390781d1a5a8f6512982af1fd65@epcas1p2.samsung.com>
2021-05-13 2:33 ` [PATCH] Unnecessary code change in spin_lock section Chanwoo Lee
2021-05-17 11:34 ` Adrian Hunter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.