* [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static
@ 2021-05-13 5:05 Yang Yingliang
2021-05-14 7:25 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-05-13 5:05 UTC (permalink / raw)
To: linux-kernel, linux-usb; +Cc: balbi, gregkh
s3c2410_udc_set_ep0_ss() only used within this file. It should be static.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/usb/gadget/udc/s3c2410_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index b154b62abefa..902e9c3e940a 100644
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -198,7 +198,7 @@ static inline void s3c2410_udc_set_ep0_de(void __iomem *base)
udc_writeb(base, S3C2410_UDC_EP0_CSR_DE, S3C2410_UDC_EP0_CSR_REG);
}
-inline void s3c2410_udc_set_ep0_ss(void __iomem *b)
+static inline void s3c2410_udc_set_ep0_ss(void __iomem *b)
{
udc_writeb(b, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
udc_writeb(b, S3C2410_UDC_EP0_CSR_SENDSTL, S3C2410_UDC_EP0_CSR_REG);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static
2021-05-13 5:05 [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static Yang Yingliang
@ 2021-05-14 7:25 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-05-14 7:25 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-usb; +Cc: gregkh
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
Yang Yingliang <yangyingliang@huawei.com> writes:
> s3c2410_udc_set_ep0_ss() only used within this file. It should be static.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 5:05 [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static Yang Yingliang
2021-05-14 7:25 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.