* [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node
@ 2021-04-28 12:58 ` Mian Yousaf Kaukab
0 siblings, 0 replies; 4+ messages in thread
From: Mian Yousaf Kaukab @ 2021-04-28 12:58 UTC (permalink / raw)
To: shawnguo, leoyang.li, robh+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, Mian Yousaf Kaukab
On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
then its probe fails with the following warning:
[ 10.471363] couldn't get idr
[ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
...
[ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
[ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
Reason for the failure is that bus-num property is set for dspi node.
However, bus-num property is not set for the qspi node. If probe for
spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
Call to spi_register_controller() from spi-fsl-dspi driver then fails.
Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
optional") bus-num property is optional. Remove bus-num property from
dspi node to fix the issue.
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
---
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 135ac8210871..801ba9612d36 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -929,7 +929,6 @@ dspi: spi@2100000 {
QORIQ_CLK_PLL_DIV(4)>;
clock-names = "dspi";
spi-num-chipselects = <5>;
- bus-num = <0>;
};
esdhc: esdhc@2140000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node
@ 2021-04-28 12:58 ` Mian Yousaf Kaukab
0 siblings, 0 replies; 4+ messages in thread
From: Mian Yousaf Kaukab @ 2021-04-28 12:58 UTC (permalink / raw)
To: shawnguo, leoyang.li, robh+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, Mian Yousaf Kaukab
On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
then its probe fails with the following warning:
[ 10.471363] couldn't get idr
[ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
...
[ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
[ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
Reason for the failure is that bus-num property is set for dspi node.
However, bus-num property is not set for the qspi node. If probe for
spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
Call to spi_register_controller() from spi-fsl-dspi driver then fails.
Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
optional") bus-num property is optional. Remove bus-num property from
dspi node to fix the issue.
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
---
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 135ac8210871..801ba9612d36 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -929,7 +929,6 @@ dspi: spi@2100000 {
QORIQ_CLK_PLL_DIV(4)>;
clock-names = "dspi";
spi-num-chipselects = <5>;
- bus-num = <0>;
};
esdhc: esdhc@2140000 {
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node
2021-04-28 12:58 ` Mian Yousaf Kaukab
@ 2021-05-13 7:59 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-05-13 7:59 UTC (permalink / raw)
To: Mian Yousaf Kaukab
Cc: leoyang.li, robh+dt, linux-arm-kernel, devicetree, linux-kernel
On Wed, Apr 28, 2021 at 02:58:07PM +0200, Mian Yousaf Kaukab wrote:
> On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
> then its probe fails with the following warning:
>
> [ 10.471363] couldn't get idr
> [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
> ...
> [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
> [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
>
> Reason for the failure is that bus-num property is set for dspi node.
> However, bus-num property is not set for the qspi node. If probe for
> spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
> Call to spi_register_controller() from spi-fsl-dspi driver then fails.
> Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
> optional") bus-num property is optional. Remove bus-num property from
> dspi node to fix the issue.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node
@ 2021-05-13 7:59 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-05-13 7:59 UTC (permalink / raw)
To: Mian Yousaf Kaukab
Cc: leoyang.li, robh+dt, linux-arm-kernel, devicetree, linux-kernel
On Wed, Apr 28, 2021 at 02:58:07PM +0200, Mian Yousaf Kaukab wrote:
> On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
> then its probe fails with the following warning:
>
> [ 10.471363] couldn't get idr
> [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
> ...
> [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
> [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
>
> Reason for the failure is that bus-num property is set for dspi node.
> However, bus-num property is not set for the qspi node. If probe for
> spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
> Call to spi_register_controller() from spi-fsl-dspi driver then fails.
> Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
> optional") bus-num property is optional. Remove bus-num property from
> dspi node to fix the issue.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-13 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 12:58 [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node Mian Yousaf Kaukab
2021-04-28 12:58 ` Mian Yousaf Kaukab
2021-05-13 7:59 ` Shawn Guo
2021-05-13 7:59 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.