All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold"
@ 2021-05-13 10:52 Martin Jansa
  2021-05-14  3:08 ` [meta-virtualization] " Bruce Ashfield
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2021-05-13 10:52 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

This reverts commit dda5ae36b44c61e61439341ea3153e6be5cb015e.

binutils gold linker was fixed with:
https://git.openembedded.org/openembedded-core/commit/?id=d07d4d739ae17787017f771dd2068fda0e836722

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-containers/runc/runc-opencontainers_git.bb | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/recipes-containers/runc/runc-opencontainers_git.bb b/recipes-containers/runc/runc-opencontainers_git.bb
index 51ba7c9..f3ff9a8 100644
--- a/recipes-containers/runc/runc-opencontainers_git.bb
+++ b/recipes-containers/runc/runc-opencontainers_git.bb
@@ -8,10 +8,3 @@ SRC_URI = " \
 RUNC_VERSION = "1.0.0-rc93"
 
 CVE_PRODUCT = "runc"
-
-# use BFD when ld-is-gold is used to work around:
-# http://errors.yoctoproject.org/Errors/Details/580099/
-# CGO_ENABLED=1 x86_64-oe-linux-go build -trimpath  -tags "seccomp seccomp                       netgo osusergo" -ldflags "-w -extldflags -static -X main.gitCommit="fce58ab2d5c488bc573d02712db476a6daa9a60c-dirty" -X main.version=1.0.0-rc93+dev " -o runc .
-# TOPDIR/tmp-glibc/work/core2-64-oe-linux/runc-opencontainers/1.0.0-rc93+gitAUTOINC+fce58ab2d5-r0/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/11.0.1/ld: internal error in format_file_lineno, at ../../gold/dwarf_reader.cc:2278
-# collect2: error: ld returned 1 exit status
-LDFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-virtualization] [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold"
  2021-05-13 10:52 [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold" Martin Jansa
@ 2021-05-14  3:08 ` Bruce Ashfield
  2021-05-14  6:50   ` Martin Jansa
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Ashfield @ 2021-05-14  3:08 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

merged.

Bruce

On Thu, May 13, 2021 at 6:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> This reverts commit dda5ae36b44c61e61439341ea3153e6be5cb015e.
>
> binutils gold linker was fixed with:
> https://git.openembedded.org/openembedded-core/commit/?id=d07d4d739ae17787017f771dd2068fda0e836722
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-containers/runc/runc-opencontainers_git.bb | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/recipes-containers/runc/runc-opencontainers_git.bb b/recipes-containers/runc/runc-opencontainers_git.bb
> index 51ba7c9..f3ff9a8 100644
> --- a/recipes-containers/runc/runc-opencontainers_git.bb
> +++ b/recipes-containers/runc/runc-opencontainers_git.bb
> @@ -8,10 +8,3 @@ SRC_URI = " \
>  RUNC_VERSION = "1.0.0-rc93"
>
>  CVE_PRODUCT = "runc"
> -
> -# use BFD when ld-is-gold is used to work around:
> -# http://errors.yoctoproject.org/Errors/Details/580099/
> -# CGO_ENABLED=1 x86_64-oe-linux-go build -trimpath  -tags "seccomp seccomp                       netgo osusergo" -ldflags "-w -extldflags -static -X main.gitCommit="fce58ab2d5c488bc573d02712db476a6daa9a60c-dirty" -X main.version=1.0.0-rc93+dev " -o runc .
> -# TOPDIR/tmp-glibc/work/core2-64-oe-linux/runc-opencontainers/1.0.0-rc93+gitAUTOINC+fce58ab2d5-r0/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/11.0.1/ld: internal error in format_file_lineno, at ../../gold/dwarf_reader.cc:2278
> -# collect2: error: ld returned 1 exit status
> -LDFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
> --
> 2.30.2
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-virtualization] [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold"
  2021-05-14  3:08 ` [meta-virtualization] " Bruce Ashfield
@ 2021-05-14  6:50   ` Martin Jansa
  2021-05-14 12:20     ` Bruce Ashfield
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2021-05-14  6:50 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: meta-virtualization

[-- Attachment #1: Type: text/plain, Size: 2137 bytes --]

On Thu, May 13, 2021 at 11:08:50PM -0400, Bruce Ashfield wrote:
> merged.

Thanks for merge, now please push it as well :).

("xen, rpi4: fix typo in raspberrypi dynamic-layers inclusion" is also
missing in master branch)

Cheers,

> On Thu, May 13, 2021 at 6:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> >
> > This reverts commit dda5ae36b44c61e61439341ea3153e6be5cb015e.
> >
> > binutils gold linker was fixed with:
> > https://git.openembedded.org/openembedded-core/commit/?id=d07d4d739ae17787017f771dd2068fda0e836722
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  recipes-containers/runc/runc-opencontainers_git.bb | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/recipes-containers/runc/runc-opencontainers_git.bb b/recipes-containers/runc/runc-opencontainers_git.bb
> > index 51ba7c9..f3ff9a8 100644
> > --- a/recipes-containers/runc/runc-opencontainers_git.bb
> > +++ b/recipes-containers/runc/runc-opencontainers_git.bb
> > @@ -8,10 +8,3 @@ SRC_URI = " \
> >  RUNC_VERSION = "1.0.0-rc93"
> >
> >  CVE_PRODUCT = "runc"
> > -
> > -# use BFD when ld-is-gold is used to work around:
> > -# http://errors.yoctoproject.org/Errors/Details/580099/
> > -# CGO_ENABLED=1 x86_64-oe-linux-go build -trimpath  -tags "seccomp seccomp                       netgo osusergo" -ldflags "-w -extldflags -static -X main.gitCommit="fce58ab2d5c488bc573d02712db476a6daa9a60c-dirty" -X main.version=1.0.0-rc93+dev " -o runc .
> > -# TOPDIR/tmp-glibc/work/core2-64-oe-linux/runc-opencontainers/1.0.0-rc93+gitAUTOINC+fce58ab2d5-r0/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/11.0.1/ld: internal error in format_file_lineno, at ../../gold/dwarf_reader.cc:2278
> > -# collect2: error: ld returned 1 exit status
> > -LDFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
> > --
> > 2.30.2
> >
> >
> > 
> >
> 
> 
> -- 
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-virtualization] [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold"
  2021-05-14  6:50   ` Martin Jansa
@ 2021-05-14 12:20     ` Bruce Ashfield
  0 siblings, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2021-05-14 12:20 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

Something went insane with my setup and my master-wip branch was
pushed to master.

I just did a history reset, because the recipes that were on that
master push were so bad, they needed more than a reset.

Apologies if this throws anyone's fetches into chaos, but I just
didn't want those bad/broken commits around at all.

Bruce

On Fri, May 14, 2021 at 2:50 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Thu, May 13, 2021 at 11:08:50PM -0400, Bruce Ashfield wrote:
> > merged.
>
> Thanks for merge, now please push it as well :).
>
> ("xen, rpi4: fix typo in raspberrypi dynamic-layers inclusion" is also
> missing in master branch)
>
> Cheers,
>
> > On Thu, May 13, 2021 at 6:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > >
> > > This reverts commit dda5ae36b44c61e61439341ea3153e6be5cb015e.
> > >
> > > binutils gold linker was fixed with:
> > > https://git.openembedded.org/openembedded-core/commit/?id=d07d4d739ae17787017f771dd2068fda0e836722
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > >  recipes-containers/runc/runc-opencontainers_git.bb | 7 -------
> > >  1 file changed, 7 deletions(-)
> > >
> > > diff --git a/recipes-containers/runc/runc-opencontainers_git.bb b/recipes-containers/runc/runc-opencontainers_git.bb
> > > index 51ba7c9..f3ff9a8 100644
> > > --- a/recipes-containers/runc/runc-opencontainers_git.bb
> > > +++ b/recipes-containers/runc/runc-opencontainers_git.bb
> > > @@ -8,10 +8,3 @@ SRC_URI = " \
> > >  RUNC_VERSION = "1.0.0-rc93"
> > >
> > >  CVE_PRODUCT = "runc"
> > > -
> > > -# use BFD when ld-is-gold is used to work around:
> > > -# http://errors.yoctoproject.org/Errors/Details/580099/
> > > -# CGO_ENABLED=1 x86_64-oe-linux-go build -trimpath  -tags "seccomp seccomp                       netgo osusergo" -ldflags "-w -extldflags -static -X main.gitCommit="fce58ab2d5c488bc573d02712db476a6daa9a60c-dirty" -X main.version=1.0.0-rc93+dev " -o runc .
> > > -# TOPDIR/tmp-glibc/work/core2-64-oe-linux/runc-opencontainers/1.0.0-rc93+gitAUTOINC+fce58ab2d5-r0/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/11.0.1/ld: internal error in format_file_lineno, at ../../gold/dwarf_reader.cc:2278
> > > -# collect2: error: ld returned 1 exit status
> > > -LDFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
> > > --
> > > 2.30.2
> > >
> > >
> > > 
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-14 12:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 10:52 [PATCH] Revert "runc-opencontainers: use bfd even with ld-is-gold" Martin Jansa
2021-05-14  3:08 ` [meta-virtualization] " Bruce Ashfield
2021-05-14  6:50   ` Martin Jansa
2021-05-14 12:20     ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.