From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Will Deacon <will@kernel.org>,
Kirti Wankhede <kwankhede@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Thu, 13 May 2021 09:00:58 -0300 [thread overview]
Message-ID: <20210513120058.GG1096940@ziepe.ca> (raw)
In-Reply-To: <MWHPR11MB1886E02BF7DE371E9665AA328C519@MWHPR11MB1886.namprd11.prod.outlook.com>
On Thu, May 13, 2021 at 03:28:52AM +0000, Tian, Kevin wrote:
> Are you specially concerned about this iommu_device hack which
> directly connects mdev_device to iommu layer or the entire removed
> logic including the aux domain concept? For the former we are now
> following up the referred thread to find a clean way. But for the latter
> we feel it's still necessary regardless of how iommu interface is redesigned
> to support device connection from the upper level driver. The reason is
> that with mdev or subdevice one physical device could be attached to
> multiple domains now. there could be a primary domain with DOMAIN_
> DMA type for DMA_API use by parent driver itself, and multiple auxiliary
> domains with DOMAIN_UNMANAGED types for subdevices assigned to
> different VMs.
Why do we need more domains than just the physical domain for the
parent? How does auxdomain appear in /dev/ioasid?
I never understood what this dead code was supposed to be used for.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Will Deacon <will@kernel.org>,
Kirti Wankhede <kwankhede@nvidia.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@lst.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Thu, 13 May 2021 09:00:58 -0300 [thread overview]
Message-ID: <20210513120058.GG1096940@ziepe.ca> (raw)
In-Reply-To: <MWHPR11MB1886E02BF7DE371E9665AA328C519@MWHPR11MB1886.namprd11.prod.outlook.com>
On Thu, May 13, 2021 at 03:28:52AM +0000, Tian, Kevin wrote:
> Are you specially concerned about this iommu_device hack which
> directly connects mdev_device to iommu layer or the entire removed
> logic including the aux domain concept? For the former we are now
> following up the referred thread to find a clean way. But for the latter
> we feel it's still necessary regardless of how iommu interface is redesigned
> to support device connection from the upper level driver. The reason is
> that with mdev or subdevice one physical device could be attached to
> multiple domains now. there could be a primary domain with DOMAIN_
> DMA type for DMA_API use by parent driver itself, and multiple auxiliary
> domains with DOMAIN_UNMANAGED types for subdevices assigned to
> different VMs.
Why do we need more domains than just the physical domain for the
parent? How does auxdomain appear in /dev/ioasid?
I never understood what this dead code was supposed to be used for.
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Will Deacon <will@kernel.org>,
Kirti Wankhede <kwankhede@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Thu, 13 May 2021 09:00:58 -0300 [thread overview]
Message-ID: <20210513120058.GG1096940@ziepe.ca> (raw)
In-Reply-To: <MWHPR11MB1886E02BF7DE371E9665AA328C519@MWHPR11MB1886.namprd11.prod.outlook.com>
On Thu, May 13, 2021 at 03:28:52AM +0000, Tian, Kevin wrote:
> Are you specially concerned about this iommu_device hack which
> directly connects mdev_device to iommu layer or the entire removed
> logic including the aux domain concept? For the former we are now
> following up the referred thread to find a clean way. But for the latter
> we feel it's still necessary regardless of how iommu interface is redesigned
> to support device connection from the upper level driver. The reason is
> that with mdev or subdevice one physical device could be attached to
> multiple domains now. there could be a primary domain with DOMAIN_
> DMA type for DMA_API use by parent driver itself, and multiple auxiliary
> domains with DOMAIN_UNMANAGED types for subdevices assigned to
> different VMs.
Why do we need more domains than just the physical domain for the
parent? How does auxdomain appear in /dev/ioasid?
I never understood what this dead code was supposed to be used for.
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-13 12:01 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 6:53 more iommu dead code removal Christoph Hellwig
2021-05-10 6:53 ` Christoph Hellwig
2021-05-10 6:53 ` Christoph Hellwig
2021-05-10 6:54 ` [PATCH 1/6] iommu: remove the unused dev_has_feat method Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` [PATCH 2/6] iommu: remove the unused iommu_aux_get_pasid interface Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` [PATCH 3/6] vfio: remove the unused mdev iommu hook Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 15:54 ` Jason Gunthorpe
2021-05-10 15:54 ` Jason Gunthorpe
2021-05-10 15:54 ` Jason Gunthorpe
2021-05-13 3:28 ` Tian, Kevin
2021-05-13 3:28 ` Tian, Kevin
2021-05-13 3:28 ` Tian, Kevin
2021-05-13 12:00 ` Jason Gunthorpe [this message]
2021-05-13 12:00 ` Jason Gunthorpe
2021-05-13 12:00 ` Jason Gunthorpe
2021-05-14 6:27 ` Tian, Kevin
2021-05-14 6:27 ` Tian, Kevin
2021-05-14 6:27 ` Tian, Kevin
2021-05-14 6:54 ` Tian, Kevin
2021-05-14 6:54 ` Tian, Kevin
2021-05-14 6:54 ` Tian, Kevin
2021-05-14 12:19 ` Jason Gunthorpe
2021-05-14 12:19 ` Jason Gunthorpe
2021-05-14 12:19 ` Jason Gunthorpe
2021-05-14 12:58 ` Tian, Kevin
2021-05-14 12:58 ` Tian, Kevin
2021-05-14 12:58 ` Tian, Kevin
2021-05-14 13:31 ` Jason Gunthorpe
2021-05-14 13:31 ` Jason Gunthorpe
2021-05-14 13:31 ` Jason Gunthorpe
2021-05-17 12:22 ` Joerg Roedel
2021-05-17 12:22 ` Joerg Roedel
2021-05-17 12:22 ` Joerg Roedel
2021-05-17 12:30 ` Jason Gunthorpe
2021-05-17 12:30 ` Jason Gunthorpe
2021-05-17 12:30 ` Jason Gunthorpe
2021-05-17 12:53 ` Joerg Roedel
2021-05-17 12:53 ` Joerg Roedel
2021-05-17 12:53 ` Joerg Roedel
2021-05-17 13:35 ` Jason Gunthorpe
2021-05-17 13:35 ` Jason Gunthorpe
2021-05-17 13:35 ` Jason Gunthorpe
2021-05-17 15:35 ` Joerg Roedel
2021-05-17 15:35 ` Joerg Roedel
2021-05-17 15:35 ` Joerg Roedel
2021-05-19 15:23 ` Robin Murphy
2021-05-19 15:23 ` Robin Murphy
2021-05-19 15:23 ` Robin Murphy
2021-05-19 18:06 ` Jason Gunthorpe
2021-05-19 18:06 ` Jason Gunthorpe
2021-05-19 18:06 ` Jason Gunthorpe
2021-05-19 23:12 ` Tian, Kevin
2021-05-19 23:12 ` Tian, Kevin
2021-05-19 23:12 ` Tian, Kevin
2021-05-19 23:24 ` Jason Gunthorpe
2021-05-19 23:24 ` Jason Gunthorpe
2021-05-19 23:24 ` Jason Gunthorpe
2021-05-20 14:13 ` Robin Murphy
2021-05-20 14:13 ` Robin Murphy
2021-05-20 14:13 ` Robin Murphy
2021-05-20 14:34 ` Jason Gunthorpe
2021-05-20 14:34 ` Jason Gunthorpe
2021-05-20 14:34 ` Jason Gunthorpe
2021-05-24 18:18 ` Robin Murphy
2021-05-24 18:18 ` Robin Murphy
2021-05-24 18:18 ` Robin Murphy
2021-05-25 0:00 ` Jason Gunthorpe
2021-05-25 0:00 ` Jason Gunthorpe
2021-05-25 0:00 ` Jason Gunthorpe
2021-06-30 9:08 ` Tian, Kevin
2021-06-30 9:08 ` Tian, Kevin
2021-06-30 9:08 ` Tian, Kevin
2021-07-22 13:34 ` Christoph Hellwig
2021-07-22 13:34 ` Christoph Hellwig
2021-07-22 13:34 ` Christoph Hellwig
2021-07-23 5:36 ` Tian, Kevin
2021-07-23 5:36 ` Tian, Kevin
2021-07-23 5:36 ` Tian, Kevin
2021-07-23 5:41 ` Christoph Hellwig
2021-07-23 5:41 ` Christoph Hellwig
2021-07-23 5:41 ` Christoph Hellwig
2021-07-23 5:44 ` Tian, Kevin
2021-07-23 5:44 ` Tian, Kevin
2021-07-23 5:44 ` Tian, Kevin
2021-07-22 6:02 ` Tian, Kevin
2021-07-22 6:02 ` Tian, Kevin
2021-07-22 6:02 ` Tian, Kevin
2021-05-14 13:17 ` Tian, Kevin
2021-05-14 13:17 ` Tian, Kevin
2021-05-14 13:17 ` Tian, Kevin
2021-05-14 13:39 ` Jason Gunthorpe
2021-05-14 13:39 ` Jason Gunthorpe
2021-05-14 13:39 ` Jason Gunthorpe
2021-05-14 14:08 ` Liu Yi L
2021-05-14 14:28 ` Tian, Kevin
2021-05-14 14:28 ` Tian, Kevin
2021-05-14 14:28 ` Tian, Kevin
2021-05-14 14:44 ` Jason Gunthorpe
2021-05-14 14:44 ` Jason Gunthorpe
2021-05-14 14:44 ` Jason Gunthorpe
2021-05-10 6:54 ` [PATCH 4/6] iommu: remove iommu_aux_{attach,detach}_device Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` [PATCH 5/6] iommu: remove IOMMU_DEV_FEAT_AUX Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` [PATCH 6/6] iommu: remove iommu_dev_feature_enabled Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 6:54 ` Christoph Hellwig
2021-05-10 11:54 ` more iommu dead code removal Jason Gunthorpe
2021-05-10 11:54 ` Jason Gunthorpe
2021-05-10 11:54 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513120058.GG1096940@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.