From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv
Date: Thu, 13 May 2021 15:34:24 +0200 [thread overview]
Message-ID: <20210513133423.GB2222@otheros> (raw)
In-Reply-To: <c5634f19-f9f3-5966-a5b3-a0a64ca4534b@nvidia.com>
On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote:
> Nice work overall, thank you. I hope it was tested well. :)
> It'd be great if later you could add some selftests.
>
> Cheers,
> Nik
Hi Nikolay,
I think I found a way now to better deal with the protocol
specific hlist_for_each_entry(), by using hlist_for_each()
and a helper function, to reduce the duplicate code
with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested
(and also removing duplicate code with
br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7
and 9 a bit for that...
Sorry for the inconvience and my bad timing with your reviews. But
thanks a lot for all your valuable feedback!
Also netdevbpf patchwork had a few more remarks, they should
hopefully be fixed now, too.
Regards, Linus
WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv
Date: Thu, 13 May 2021 15:34:24 +0200 [thread overview]
Message-ID: <20210513133423.GB2222@otheros> (raw)
In-Reply-To: <c5634f19-f9f3-5966-a5b3-a0a64ca4534b@nvidia.com>
On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote:
> Nice work overall, thank you. I hope it was tested well. :)
> It'd be great if later you could add some selftests.
>
> Cheers,
> Nik
Hi Nikolay,
I think I found a way now to better deal with the protocol
specific hlist_for_each_entry(), by using hlist_for_each()
and a helper function, to reduce the duplicate code
with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested
(and also removing duplicate code with
br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7
and 9 a bit for that...
Sorry for the inconvience and my bad timing with your reviews. But
thanks a lot for all your valuable feedback!
Also netdevbpf patchwork had a few more remarks, they should
hopefully be fixed now, too.
Regards, Linus
next prev parent reply other threads:[~2021-05-13 13:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 23:19 [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-12 23:19 ` [net-next v3 01/11] net: bridge: mcast: rename multicast router lists and timers Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:29 ` Nikolay Aleksandrov
2021-05-13 11:29 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 02/11] net: bridge: mcast: add wrappers for router node retrieval Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:29 ` Nikolay Aleksandrov
2021-05-13 11:29 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 03/11] net: bridge: mcast: prepare mdb netlink for mcast router split Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:30 ` Nikolay Aleksandrov
2021-05-13 11:30 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 04/11] net: bridge: mcast: prepare query reception " Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:30 ` Nikolay Aleksandrov
2021-05-13 11:30 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 05/11] net: bridge: mcast: prepare is-router function " Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:32 ` Nikolay Aleksandrov
2021-05-13 11:32 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 06/11] net: bridge: mcast: prepare expiry functions " Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:33 ` Nikolay Aleksandrov
2021-05-13 11:33 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 07/11] net: bridge: mcast: prepare add-router function " Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:35 ` Nikolay Aleksandrov
2021-05-13 11:35 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 08/11] net: bridge: mcast: split router port del+notify " Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:46 ` Nikolay Aleksandrov
2021-05-13 11:46 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6 Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:59 ` Nikolay Aleksandrov
2021-05-13 11:59 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 10/11] net: bridge: mcast: add ip4+ip6 mcast router timers to mdb netlink Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:38 ` Nikolay Aleksandrov
2021-05-13 11:38 ` [Bridge] " Nikolay Aleksandrov
2021-05-12 23:19 ` [net-next v3 11/11] net: bridge: mcast: export multicast router presence adjacent to a port Linus Lüssing
2021-05-12 23:19 ` [Bridge] " Linus Lüssing
2021-05-13 11:39 ` Nikolay Aleksandrov
2021-05-13 11:39 ` [Bridge] " Nikolay Aleksandrov
2021-05-13 12:02 ` [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv Nikolay Aleksandrov
2021-05-13 12:02 ` [Bridge] " Nikolay Aleksandrov
2021-05-13 13:34 ` Linus Lüssing [this message]
2021-05-13 13:34 ` Linus Lüssing
2021-05-13 13:36 ` Nikolay Aleksandrov
2021-05-13 13:36 ` [Bridge] " Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513133423.GB2222@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.