Re: [PATCH v6 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels'

From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels'
Date: Fri, 14 May 2021 08:18:33 -0400	[thread overview]
Message-ID: <20210514081728-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210503211020.894589-1-philmd@redhat.com>

On Mon, May 03, 2021 at 11:10:08PM +0200, Philippe Mathieu-Daudé wrote:
> Missing review: 10-12 (bios-tables-test)

So the main functional changes is ARM stuff I think?
Pls use that tree to merge.

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> Hi,
> 
> This series aims at having accelerator-independent qtests
> by querying a QEMU instance at runtime to check the list
> of built-in accelerators.
> 
> First we add the 'query-accels' QMP command,
> then we add the qtest_has_accel() method to libqtest,
> finally we use this new method to allow running
> bios-tables-test on KVM-only builds.
> 
> Since v5:
> - Rename bios-tables tests (Igor)
> - Do not restrict bios-tables tests to TCG (Igor)
> - Reset bios-tables-test R-b tags
> 
> Since v4:
> - Removed patch 10 (Markus, patch justification not clear)
>   'qtest/qmp-cmd-test: Make test build-independent from accelerator'
> - Removed patch 12 (Alex, icount / record/replay issue)
>   'tests/meson: Only build softfloat objects if TCG is selected (again)'
> - Sorted @Accelerator QAPI enum (Eric)
> - Added R-b/T-b
> 
> Since v3:
> - Added Markus review comments
> - Added R-b/A-b tags
> 
> Since v2:
> - Addressed Markus & Drew review comments
> - Added qtest/migration-test patch
> 
> Since v1:
> - Addressed Eric & Paolo review comments
> 
> Since v0:
> - kept over-engineered union (I don't how to do simple enum)
> - dropped arm-cpu-features patches for now
> - fixed typos (Eric)
> - rename qtest_has_accel (Thomas)
> - probe accel with machine none previous qtest (Paolo)
> - iterate over QAPI enum (Markus)
> 
> Eric's suggestion of conditional QAPI didn't worked out,
> as accelerator definitions are poisoned.
> 
> Phil.
> 
> Philippe Mathieu-Daudé (12):
>   MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section
>   accel: Introduce 'query-accels' QMP command
>   qtest: Add qtest_has_accel() method
>   qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM
>   qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM
>   qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests
>   qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG
>   qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64
>   qtest/bios-tables-test: Rename tests not TCG specific
>   qtest/bios-tables-test: Rename TCG specific tests
>   qtest/bios-tables-test: Make test build-independent from accelerator
>   qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore
> 
>  qapi/machine.json              |  47 ++++++++++
>  tests/qtest/libqos/libqtest.h  |   8 ++
>  accel/accel-qmp.c              |  49 +++++++++++
>  tests/qtest/arm-cpu-features.c |  55 ++++--------
>  tests/qtest/bios-tables-test.c | 156 ++++++++++++++++-----------------
>  tests/qtest/libqtest.c         |  29 ++++++
>  tests/qtest/migration-test.c   |   4 +-
>  MAINTAINERS                    |   1 +
>  accel/meson.build              |   2 +-
>  tests/qtest/meson.build        |   3 +-
>  10 files changed, 232 insertions(+), 122 deletions(-)
>  create mode 100644 accel/accel-qmp.c
> 
> -- 
> 2.26.3
> 