All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC
Date: Fri, 14 May 2021 10:53:36 +0100	[thread overview]
Message-ID: <20210514095339.12979-1-ionela.voinescu@arm.com> (raw)

Hi all,

These are a few trivial patches to populate cpu capacity information
using performance information from ACPI's CPPC.

I've tied this functionality to the existing function
init_freq_invariance_cppc() called in acpi_cppc_processor_probe().
This function is renamed to a more generic arch_init_invariance_cppc().

The patches have been build tested on x86 and more thoroughly tested on
Juno R2 (arm64), which uses the new functionality, with the following
results:


root@ubuntu:~# dmesg | grep cpu_capacity
[    2.157494] init_cpu_capacity_cppc: CPU0 cpu_capacity=38300 (raw).
[    2.163699] init_cpu_capacity_cppc: CPU1 cpu_capacity=38300 (raw).
[    2.169899] init_cpu_capacity_cppc: CPU2 cpu_capacity=38300 (raw).
[    2.176098] init_cpu_capacity_cppc: CPU3 cpu_capacity=38300 (raw).
[    2.182296] init_cpu_capacity_cppc: CPU4 cpu_capacity=102400 (raw).
[    2.188581] init_cpu_capacity_cppc: CPU5 cpu_capacity=102400 (raw).
[    2.194867] cpu_capacity: capacity_scale=102400
[    2.199409] cpu_capacity: CPU0 cpu_capacity=383
[    2.203952] cpu_capacity: CPU1 cpu_capacity=383
[    2.208495] cpu_capacity: CPU2 cpu_capacity=383
[    2.213037] cpu_capacity: CPU3 cpu_capacity=383
[    2.217580] cpu_capacity: CPU4 cpu_capacity=1024
[    2.222209] cpu_capacity: CPU5 cpu_capacity=1024
[    2.226886] init_cpu_capacity_cppc: cpu_capacity initialization done

root@ubuntu:~# tail -n +1 /sys/devices/system/cpu/cpu*/cpu_capacity
==> /sys/devices/system/cpu/cpu0/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu1/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu2/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu3/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu4/cpu_capacity <==
1024
==> /sys/devices/system/cpu/cpu5/cpu_capacity <==
1024

All works as expected even if ACPI processor support is built as a
module.

Patches are based on v5.13-rc1.

Let me know what you think!

Thanks,
Ionela.

Ionela Voinescu (3):
  x86, ACPI: rename init_freq_invariance_cppc to
    arch_init_invariance_cppc
  arch_topology: obtain cpu capacity using information from CPPC
  arm64, topology: enable use of init_cpu_capacity_cppc()

 arch/arm64/include/asm/topology.h |  4 ++++
 arch/x86/include/asm/topology.h   |  2 +-
 drivers/acpi/cppc_acpi.c          |  6 ++---
 drivers/base/arch_topology.c      | 39 +++++++++++++++++++++++++++++++
 include/linux/arch_topology.h     |  4 ++++
 5 files changed, 51 insertions(+), 4 deletions(-)

-- 
2.29.2.dirty


WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC
Date: Fri, 14 May 2021 10:53:36 +0100	[thread overview]
Message-ID: <20210514095339.12979-1-ionela.voinescu@arm.com> (raw)

Hi all,

These are a few trivial patches to populate cpu capacity information
using performance information from ACPI's CPPC.

I've tied this functionality to the existing function
init_freq_invariance_cppc() called in acpi_cppc_processor_probe().
This function is renamed to a more generic arch_init_invariance_cppc().

The patches have been build tested on x86 and more thoroughly tested on
Juno R2 (arm64), which uses the new functionality, with the following
results:


root@ubuntu:~# dmesg | grep cpu_capacity
[    2.157494] init_cpu_capacity_cppc: CPU0 cpu_capacity=38300 (raw).
[    2.163699] init_cpu_capacity_cppc: CPU1 cpu_capacity=38300 (raw).
[    2.169899] init_cpu_capacity_cppc: CPU2 cpu_capacity=38300 (raw).
[    2.176098] init_cpu_capacity_cppc: CPU3 cpu_capacity=38300 (raw).
[    2.182296] init_cpu_capacity_cppc: CPU4 cpu_capacity=102400 (raw).
[    2.188581] init_cpu_capacity_cppc: CPU5 cpu_capacity=102400 (raw).
[    2.194867] cpu_capacity: capacity_scale=102400
[    2.199409] cpu_capacity: CPU0 cpu_capacity=383
[    2.203952] cpu_capacity: CPU1 cpu_capacity=383
[    2.208495] cpu_capacity: CPU2 cpu_capacity=383
[    2.213037] cpu_capacity: CPU3 cpu_capacity=383
[    2.217580] cpu_capacity: CPU4 cpu_capacity=1024
[    2.222209] cpu_capacity: CPU5 cpu_capacity=1024
[    2.226886] init_cpu_capacity_cppc: cpu_capacity initialization done

root@ubuntu:~# tail -n +1 /sys/devices/system/cpu/cpu*/cpu_capacity
==> /sys/devices/system/cpu/cpu0/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu1/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu2/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu3/cpu_capacity <==
383
==> /sys/devices/system/cpu/cpu4/cpu_capacity <==
1024
==> /sys/devices/system/cpu/cpu5/cpu_capacity <==
1024

All works as expected even if ACPI processor support is built as a
module.

Patches are based on v5.13-rc1.

Let me know what you think!

Thanks,
Ionela.

Ionela Voinescu (3):
  x86, ACPI: rename init_freq_invariance_cppc to
    arch_init_invariance_cppc
  arch_topology: obtain cpu capacity using information from CPPC
  arm64, topology: enable use of init_cpu_capacity_cppc()

 arch/arm64/include/asm/topology.h |  4 ++++
 arch/x86/include/asm/topology.h   |  2 +-
 drivers/acpi/cppc_acpi.c          |  6 ++---
 drivers/base/arch_topology.c      | 39 +++++++++++++++++++++++++++++++
 include/linux/arch_topology.h     |  4 ++++
 5 files changed, 51 insertions(+), 4 deletions(-)

-- 
2.29.2.dirty


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-05-14  9:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  9:53 Ionela Voinescu [this message]
2021-05-14  9:53 ` [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Ionela Voinescu
2021-05-14  9:53 ` [PATCH 1/3] x86, ACPI: rename init_freq_invariance_cppc to arch_init_invariance_cppc Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14  9:53 ` [PATCH 2/3] arch_topology: obtain cpu capacity using information from CPPC Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14 16:16   ` Dietmar Eggemann
2021-05-14 16:16     ` Dietmar Eggemann
2021-05-19  9:46     ` Ionela Voinescu
2021-05-19  9:46       ` Ionela Voinescu
2021-05-18 13:12   ` Valentin Schneider
2021-05-18 13:12     ` Valentin Schneider
2021-05-14  9:53 ` [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14 10:35   ` Catalin Marinas
2021-05-14 10:35     ` Catalin Marinas
2021-05-14 16:17   ` Dietmar Eggemann
2021-05-14 16:17     ` Dietmar Eggemann
2021-05-19  9:48     ` Ionela Voinescu
2021-05-19  9:48       ` Ionela Voinescu
2021-05-18 13:12 ` [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Valentin Schneider
2021-05-18 13:12   ` Valentin Schneider
2021-05-19  9:51   ` Ionela Voinescu
2021-05-19  9:51     ` Ionela Voinescu
2021-06-28 13:58 ` [tip: sched/core] sched/debug: Don't update sched_domain debug directories before sched_debug_init() tip-bot2 for Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514095339.12979-1-ionela.voinescu@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=ggherdovich@suse.cz \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.