* [PATCH 0/3] Add crypto nodes for J7200 and AM64x
@ 2021-05-14 21:07 ` Suman Anna
0 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: devicetree, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
linux-arm-kernel
Hi Nishanth,
The following series adds the crypto nodes including the underlying
rng nodes for J7200 and AM64x SoCs. Patches are on top of 5.13-rc1.
Note that AM64x supports only a limited number of algos compared to
the other K3 SoCs. The AM64x driver support accounting for this is
merged in v5.13-rc1. Also, the IP appears at the same address on
J7200 and AM64x but is in different domains.
I have verified the basic crypto self-tests, extra-tests and some
basic tcrypt tests on both J7200 EVM and AM64x EVM boards.
regards
Suman
Peter Ujfalusi (2):
arm64: dts: ti: k3-j7200-mcu: Add the mcu sa2ul crypto node
arm64: dts: ti: k3-am64-main: Enable crypto accelerator
Suman Anna (1):
arm64: dts: ti: k3-am64: Add SA2UL address space to Main CBASS ranges
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 19 ++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am64.dtsi | 1 +
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 20 +++++++++++++++++++
3 files changed, 40 insertions(+)
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] arm64: dts: ti: k3-j7200-mcu: Add the mcu sa2ul crypto node
2021-05-14 21:07 ` Suman Anna
@ 2021-05-14 21:07 ` Suman Anna
-1 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta, devicetree,
linux-arm-kernel, Suman Anna
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Add sa2ul crypto accelarator node.
In comparision to j721e, The sa2ul crypto device on j7200
has moved to mcu domain and is available for linux usage as
a shared device.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[praneeth@ti.com: picked recommendation from author to
k3-j7200-mcu-wakeup.dtsi and verified functionality]
Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
[s-anna@ti.com: minor formatting cleanups]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index 5e74e43822c3..f24bd4af62c8 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -380,4 +380,24 @@ mcu_r5fss0_core1: r5f@41400000 {
ti,loczrama = <1>;
};
};
+
+ mcu_crypto: crypto@40900000 {
+ compatible = "ti,j721e-sa2ul";
+ reg = <0x00 0x40900000 0x00 0x1200>;
+ power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+ dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
+ <&mcu_udmap 0x7503>;
+ dma-names = "tx", "rx1", "rx2";
+ dma-coherent;
+
+ rng: rng@40910000 {
+ compatible = "inside-secure,safexcel-eip76";
+ reg = <0x00 0x40910000 0x00 0x7d>;
+ interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&k3_clks 265 1>;
+ };
+ };
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/3] arm64: dts: ti: k3-j7200-mcu: Add the mcu sa2ul crypto node
@ 2021-05-14 21:07 ` Suman Anna
0 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: devicetree, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
linux-arm-kernel
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Add sa2ul crypto accelarator node.
In comparision to j721e, The sa2ul crypto device on j7200
has moved to mcu domain and is available for linux usage as
a shared device.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[praneeth@ti.com: picked recommendation from author to
k3-j7200-mcu-wakeup.dtsi and verified functionality]
Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
[s-anna@ti.com: minor formatting cleanups]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index 5e74e43822c3..f24bd4af62c8 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -380,4 +380,24 @@ mcu_r5fss0_core1: r5f@41400000 {
ti,loczrama = <1>;
};
};
+
+ mcu_crypto: crypto@40900000 {
+ compatible = "ti,j721e-sa2ul";
+ reg = <0x00 0x40900000 0x00 0x1200>;
+ power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+ dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
+ <&mcu_udmap 0x7503>;
+ dma-names = "tx", "rx1", "rx2";
+ dma-coherent;
+
+ rng: rng@40910000 {
+ compatible = "inside-secure,safexcel-eip76";
+ reg = <0x00 0x40910000 0x00 0x7d>;
+ interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&k3_clks 265 1>;
+ };
+ };
};
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm64: dts: ti: k3-am64: Add SA2UL address space to Main CBASS ranges
2021-05-14 21:07 ` Suman Anna
@ 2021-05-14 21:07 ` Suman Anna
-1 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta, devicetree,
linux-arm-kernel, Suman Anna
Add the address space for the SA2UL in MAIN domain to the ranges property
of the cbass_main interconnect node so that the addresses within the
corresponding sram nodes and its children can be translated properly by
the relevant OF address API.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64.dtsi b/arch/arm64/boot/dts/ti/k3-am64.dtsi
index de6805b0c72c..8ccd03ee3036 100644
--- a/arch/arm64/boot/dts/ti/k3-am64.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64.dtsi
@@ -77,6 +77,7 @@ cbass_main: bus@f4000 {
<0x00 0x3b000000 0x00 0x3b000000 0x00 0x00000400>, /* GPMC0_CFG */
<0x00 0x3cd00000 0x00 0x3cd00000 0x00 0x00000200>, /* TIMERMGR0_CONFIG */
<0x00 0x3f004000 0x00 0x3f004000 0x00 0x00000400>, /* GICSS0_REGS */
+ <0x00 0x40900000 0x00 0x40900000 0x00 0x00030000>, /* SA2_UL0 */
<0x00 0x43000000 0x00 0x43000000 0x00 0x00020000>, /* CTRL_MMR0 */
<0x00 0x44043000 0x00 0x44043000 0x00 0x00000fe0>, /* TI SCI DEBUG */
<0x00 0x48000000 0x00 0x48000000 0x00 0x06400000>, /* DMASS */
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] arm64: dts: ti: k3-am64: Add SA2UL address space to Main CBASS ranges
@ 2021-05-14 21:07 ` Suman Anna
0 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: devicetree, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
linux-arm-kernel
Add the address space for the SA2UL in MAIN domain to the ranges property
of the cbass_main interconnect node so that the addresses within the
corresponding sram nodes and its children can be translated properly by
the relevant OF address API.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64.dtsi b/arch/arm64/boot/dts/ti/k3-am64.dtsi
index de6805b0c72c..8ccd03ee3036 100644
--- a/arch/arm64/boot/dts/ti/k3-am64.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64.dtsi
@@ -77,6 +77,7 @@ cbass_main: bus@f4000 {
<0x00 0x3b000000 0x00 0x3b000000 0x00 0x00000400>, /* GPMC0_CFG */
<0x00 0x3cd00000 0x00 0x3cd00000 0x00 0x00000200>, /* TIMERMGR0_CONFIG */
<0x00 0x3f004000 0x00 0x3f004000 0x00 0x00000400>, /* GICSS0_REGS */
+ <0x00 0x40900000 0x00 0x40900000 0x00 0x00030000>, /* SA2_UL0 */
<0x00 0x43000000 0x00 0x43000000 0x00 0x00020000>, /* CTRL_MMR0 */
<0x00 0x44043000 0x00 0x44043000 0x00 0x00000fe0>, /* TI SCI DEBUG */
<0x00 0x48000000 0x00 0x48000000 0x00 0x06400000>, /* DMASS */
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: ti: k3-am64-main: Enable crypto accelerator
2021-05-14 21:07 ` Suman Anna
@ 2021-05-14 21:07 ` Suman Anna
-1 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta, devicetree,
linux-arm-kernel, Suman Anna
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Add the node for SA2UL including the random number generator.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[s-anna@ti.com: drop label, minor cleanups]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index b2bcbf23eefd..43f982291350 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -672,4 +672,23 @@ mailbox0_cluster7: mailbox@29070000 {
ti,mbox-num-users = <4>;
ti,mbox-num-fifos = <16>;
};
+
+ crypto: crypto@40900000 {
+ compatible = "ti,am64-sa2ul";
+ reg = <0x00 0x40900000 0x00 0x1200>;
+ power-domains = <&k3_pds 133 TI_SCI_PD_EXCLUSIVE>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+ dmas = <&main_pktdma 0xc001 0>, <&main_pktdma 0x4002 0>,
+ <&main_pktdma 0x4003 0>;
+ dma-names = "tx", "rx1", "rx2";
+
+ rng: rng@40910000 {
+ compatible = "inside-secure,safexcel-eip76";
+ reg = <0x00 0x40910000 0x00 0x7d>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&k3_clks 133 0>;
+ };
+ };
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] arm64: dts: ti: k3-am64-main: Enable crypto accelerator
@ 2021-05-14 21:07 ` Suman Anna
0 siblings, 0 replies; 10+ messages in thread
From: Suman Anna @ 2021-05-14 21:07 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: devicetree, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
linux-arm-kernel
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Add the node for SA2UL including the random number generator.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[s-anna@ti.com: drop label, minor cleanups]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index b2bcbf23eefd..43f982291350 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -672,4 +672,23 @@ mailbox0_cluster7: mailbox@29070000 {
ti,mbox-num-users = <4>;
ti,mbox-num-fifos = <16>;
};
+
+ crypto: crypto@40900000 {
+ compatible = "ti,am64-sa2ul";
+ reg = <0x00 0x40900000 0x00 0x1200>;
+ power-domains = <&k3_pds 133 TI_SCI_PD_EXCLUSIVE>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+ dmas = <&main_pktdma 0xc001 0>, <&main_pktdma 0x4002 0>,
+ <&main_pktdma 0x4003 0>;
+ dma-names = "tx", "rx1", "rx2";
+
+ rng: rng@40910000 {
+ compatible = "inside-secure,safexcel-eip76";
+ reg = <0x00 0x40910000 0x00 0x7d>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&k3_clks 133 0>;
+ };
+ };
};
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add crypto nodes for J7200 and AM64x
2021-05-14 21:07 ` Suman Anna
@ 2021-05-14 22:11 ` Nishanth Menon
-1 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2021-05-14 22:11 UTC (permalink / raw)
To: Suman Anna
Cc: Tero Kristo, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
devicetree, linux-arm-kernel
On 16:07-20210514, Suman Anna wrote:
> The following series adds the crypto nodes including the underlying
> rng nodes for J7200 and AM64x SoCs. Patches are on top of 5.13-rc1.
>
> Note that AM64x supports only a limited number of algos compared to
> the other K3 SoCs. The AM64x driver support accounting for this is
> merged in v5.13-rc1. Also, the IP appears at the same address on
> J7200 and AM64x but is in different domains.
>
> I have verified the basic crypto self-tests, extra-tests and some
> basic tcrypt tests on both J7200 EVM and AM64x EVM boards.
>
Thanks..
While this is an appropriate description for a subset of hardware,
this maybe missing the pieces needed for certain "high security"
(HS-*) device variants. Public channels, shared data flows and lack of
full control on RNG (we can read RNG, but not seed it) come to mind
immediately and further, I am not completely sure I understand how
this plays well with DKEK with OPTEE.
I know that u-boot does have capability to disable some of these, but:
a) TF-A can definitely boot to linux kernel without the need for u-boot.
b) We still need to be able to leverage h/w acceleration support that
the high security devices is already capable of.
As a result, I am not entirely sure what we can do with this series
without breaking existing "high-security" devices (which can boot mainline
linux today with TF-A).
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add crypto nodes for J7200 and AM64x
@ 2021-05-14 22:11 ` Nishanth Menon
0 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2021-05-14 22:11 UTC (permalink / raw)
To: Suman Anna
Cc: Tero Kristo, Gowtham Tammana, Praneeth Bajjuri, Vaibhav Gupta,
devicetree, linux-arm-kernel
On 16:07-20210514, Suman Anna wrote:
> The following series adds the crypto nodes including the underlying
> rng nodes for J7200 and AM64x SoCs. Patches are on top of 5.13-rc1.
>
> Note that AM64x supports only a limited number of algos compared to
> the other K3 SoCs. The AM64x driver support accounting for this is
> merged in v5.13-rc1. Also, the IP appears at the same address on
> J7200 and AM64x but is in different domains.
>
> I have verified the basic crypto self-tests, extra-tests and some
> basic tcrypt tests on both J7200 EVM and AM64x EVM boards.
>
Thanks..
While this is an appropriate description for a subset of hardware,
this maybe missing the pieces needed for certain "high security"
(HS-*) device variants. Public channels, shared data flows and lack of
full control on RNG (we can read RNG, but not seed it) come to mind
immediately and further, I am not completely sure I understand how
this plays well with DKEK with OPTEE.
I know that u-boot does have capability to disable some of these, but:
a) TF-A can definitely boot to linux kernel without the need for u-boot.
b) We still need to be able to leverage h/w acceleration support that
the high security devices is already capable of.
As a result, I am not entirely sure what we can do with this series
without breaking existing "high-security" devices (which can boot mainline
linux today with TF-A).
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread