From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Jonathan Corbet <corbet@lwn.net>, Marc Koderer <marc@koderer.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Heiko Carstens <hca@linux.ibm.com>,
Jisheng Zhang <jszhang@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()
Date: Fri, 14 May 2021 22:20:04 +0900 [thread overview]
Message-ID: <20210514222004.54f4c2b12099b569a872a2ee@kernel.org> (raw)
In-Reply-To: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn>
On Fri, 14 May 2021 16:10:10 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> It should use post_handler instead of pre_handler in handler_post().
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
>
> Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> v2: rebase on the latest mainline kernel
>
> samples/kprobes/kprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index c495664..602db3f 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> p->symbol_name, p->addr, regs->status);
> #endif
> #ifdef CONFIG_S390
> - pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
> + pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
> p->symbol_name, p->addr, regs->flags);
> #endif
> }
> --
> 2.1.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-05-14 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:10 [PATCH v2] samples/kprobes: Fix typo in handler_post() Tiezhu Yang
2021-05-14 9:28 ` Koderer, Marc
2021-05-14 13:20 ` Masami Hiramatsu [this message]
2021-05-14 15:26 ` Joe Perches
2021-05-15 1:29 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514222004.54f4c2b12099b569a872a2ee@kernel.org \
--to=mhiramat@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=corbet@lwn.net \
--cc=hca@linux.ibm.com \
--cc=jszhang@kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@koderer.com \
--cc=mchehab+huawei@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.